Servlet Filter Support adding sling.filter.pattern support

2014-12-04 Thread Antonio Sanso
hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit

Servlet Filter Support adding sling.filter.pattern support

2014-12-04 Thread Antonio Sanso
hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit

Build failed in Jenkins: sling-healthcheck-1.6 #563

2014-12-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-healthcheck-1.6/563/ -- [...truncated 212 lines...] Caused by: svn: E175002: timed out waiting for server at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at

Should the AdapterManager register some kind of marker service when an adaptation is available?

2014-12-04 Thread Justin Edelson
Hi, One ongoing problem (which has been a bit exacerbated by Sling Models) is when code depends upon the AdapterManager being able to handle a particular adaptation. Right now, the only way to deal with this is by listening for the AdapterManager events. But these events aren't particularly easy

Re: Servlet Filter Support adding sling.filter.pattern support

2014-12-04 Thread Justin Edelson
Hi Antonio, I'd suggest starting with support for resource type and *then* add path support. Justin On Thu, Dec 4, 2014 at 5:46 AM, Antonio Sanso asa...@adobe.com wrote: hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD,

Re: Servlet Filter Support adding sling.filter.pattern support

2014-12-04 Thread Justin Edelson
Hi Antonio, I'd suggest starting with support for resource type and *then* add path support if it was still necessary. Regards, Justin On Thu, Dec 4, 2014 at 5:46 AM, Antonio Sanso asa...@adobe.com wrote: hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent

Re: Using adapters on Sling startup

2014-12-04 Thread Justin Edelson
Hi, I thought I sent this earlier, but it appears not to have gotten through (at least not according to markmail). Weird... -- Hi, One ongoing problem (which has been a bit exacerbated by Sling Models) is when code depends upon the AdapterManager being able to handle a particular adaptation.

Re: Using adapters on Sling startup

2014-12-04 Thread Robert Munteanu
Hi Justin, On Wed, Dec 3, 2014 at 10:19 PM, Justin Edelson jus...@justinedelson.com wrote: Hi, I thought I sent this earlier, but it appears not to have gotten through (at least not according to markmail). Weird... It came through as a separate email with a new subject. Anyway ... --

Re: Using adapters on Sling startup

2014-12-04 Thread Bertrand Delacretaz
On Wed, Dec 3, 2014 at 9:11 PM, Robert Munteanu romb...@apache.org wrote: ...When Sling starts up, it's perfectly legal for Bundle B to be STARTED while Bundle A is just RESOLVED Would the OSGi Require-Capability help make sure that the required adapters are available before starting bundle

Re: Using adapters on Sling startup

2014-12-04 Thread Felix Meschberger
Hi Am 04.12.2014 um 15:00 schrieb Bertrand Delacretaz bdelacre...@apache.org: On Wed, Dec 3, 2014 at 9:11 PM, Robert Munteanu romb...@apache.org wrote: ...When Sling starts up, it's perfectly legal for Bundle B to be STARTED while Bundle A is just RESOLVED Would the OSGi

Re: Servlet Filter Support adding sling.filter.pattern support

2014-12-04 Thread Antonio Sanso
thanks Justin for your feedback, if you would not mind I would try to do the opposite :) The only reason is that I have already a Pocs for this that it actually requires really few modifications.. (Felix gave me some good hints on how to implement it :)) It would probably be the same for

Re: Using adapters on Sling startup

2014-12-04 Thread Bertrand Delacretaz
Hi, On Thursday, December 4, 2014, Robert Munteanu rob...@lmn.ro wrote: ... @RequiresAdapter(adaptable=Resource.class, adapter=MyClass.class) ... This looks good to me, although it would be even more obvious as @RequiresAdapter(from=Resource.class, to=MyClass.class) The adaptable/adapter

Re: Using adapters on Sling startup

2014-12-04 Thread Robert Munteanu
On Thu, Dec 4, 2014 at 5:25 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Thursday, December 4, 2014, Robert Munteanu rob...@lmn.ro wrote: ... @RequiresAdapter(adaptable=Resource.class, adapter=MyClass.class) ... This looks good to me, although it would be even more obvious

[jira] [Created] (SLING-4216) Limit the number of MapEntry

2014-12-04 Thread Antonio Sanso (JIRA)
Antonio Sanso created SLING-4216: Summary: Limit the number of MapEntry Key: SLING-4216 URL: https://issues.apache.org/jira/browse/SLING-4216 Project: Sling Issue Type: Improvement

Re: Using adapters on Sling startup

2014-12-04 Thread Robert Munteanu
On Wed, 2014-12-03 at 15:19 -0500, Justin Edelson wrote: @Component @Service @Reference(referenceInterface=Adaptation.class, target=((adaptable=com.myco.MyClass)(adaptable=org.apache.sling.api.Resource))) public class Foo { public void doSomething(Resource resource) { MyClass cfgMan =

[jira] [Updated] (SLING-4216) Limit the number of vanityPath MapEntry

2014-12-04 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-4216: - Summary: Limit the number of vanityPath MapEntry (was: Limit the number of MapEntry ) Limit

Build failed in Jenkins: sling-healthcheck-1.6 #564

2014-12-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-healthcheck-1.6/564/ -- [...truncated 226 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

[jira] [Created] (SLING-4217) Register OSGi services corresponding to available adapter factories

2014-12-04 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-4217: -- Summary: Register OSGi services corresponding to available adapter factories Key: SLING-4217 URL: https://issues.apache.org/jira/browse/SLING-4217 Project: Sling

[jira] [Updated] (SLING-4217) Register OSGi services corresponding to available adapter factories

2014-12-04 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4217: --- Attachment: SLING-4217-1.diff Register OSGi services corresponding to available adapter

Re: Using adapters on Sling startup

2014-12-04 Thread Robert Munteanu
I took a quick stab at a patch ( org.apache.sling.adapter only, no SCR annotations for now), https://issues.apache.org/jira/browse/SLING-4217 Patch attached, a review would be appreciated. It works for my specific scenario, but might not be 100% correct. Thanks, Robert

[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector

2014-12-04 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234789#comment-14234789 ] Stefan Seifert commented on SLING-4212: --- the patch looks fine for me. (two really

Jenkins build is still unstable: sling-trunk-1.6 ยป Apache Sling Launchpad Testing #2830

2014-12-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2830/

Jenkins build is unstable: sling-trunk-1.6 #2830

2014-12-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/2830/changes