Re: Resource.getParent() on NonExistingResource

2016-06-02 Thread Georg Henzler
Hi Konrad, +1 for making the behaviour of NonExistingResource more consistent - I personally can't think of any places this would break existing code. Regards Georg On 2016-06-01 15:09, Konrad Windszus wrote: Hi Robert, thanks for your input. I am not sure whether this would confuse exis

[jira] [Created] (SLING-5756) Sling-logback integration | Change in log level removes appenders attached to async appender

2016-06-02 Thread Piyush Goyal (JIRA)
Piyush Goyal created SLING-5756: --- Summary: Sling-logback integration | Change in log level removes appenders attached to async appender Key: SLING-5756 URL: https://issues.apache.org/jira/browse/SLING-5756

Re: Resource.getParent() on NonExistingResource

2016-06-02 Thread Daniel Klco
I would imagine that the only thing this would change is to make a small number of null checks irrelevant. +1 for making the behavior more consistent, however, the JavaDocs and release notes should be explicit about this change. On Thu, Jun 2, 2016 at 4:45 AM, Georg Henzler wrote: > Hi Konrad,

[jira] [Updated] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

2016-06-02 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5757: --- Component/s: API > NonExistingResource.getParent() should not return null in case the parent i

[jira] [Created] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

2016-06-02 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-5757: -- Summary: NonExistingResource.getParent() should not return null in case the parent is non-existing Key: SLING-5757 URL: https://issues.apache.org/jira/browse/SLING-5757

Re: Resource.getParent() on NonExistingResource

2016-06-02 Thread Konrad Windszus
Thanks for the input. I created https://issues.apache.org/jira/browse/SLING-5757 for tracking that and I am going to propose a patch in there. What about SyntheticResources which are not NonExistingResources? If we would follow the same approach as for NonExistingResources the question is, with

[jira] [Created] (SLING-5758) Write Pipe should handle interpreting multi value properties

2016-06-02 Thread Jordan Shurmer (JIRA)
Jordan Shurmer created SLING-5758: - Summary: Write Pipe should handle interpreting multi value properties Key: SLING-5758 URL: https://issues.apache.org/jira/browse/SLING-5758 Project: Sling

[jira] [Updated] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

2016-06-02 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5757: --- Attachment: SLING-5757-v01.patch Attached is a patch which fixes the NonExistingResource.getPa

[jira] [Commented] (SLING-5758) Write Pipe should handle interpreting multi value properties

2016-06-02 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312356#comment-15312356 ] Nicolas Peltier commented on SLING-5758: Hi [~jshurmer], just for sake of clarity,

[jira] [Commented] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

2016-06-02 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312385#comment-15312385 ] Konrad Windszus commented on SLING-5726: Coming back to this bq. I'm entirely sup

[jira] [Updated] (SLING-5679) Move interface Customizer and customize() from junit.core to junit.teleporter

2016-06-02 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5679: --- Assignee: (was: Konrad Windszus) > Move interface Customizer and customize() from junit.co

[jira] [Commented] (SLING-5758) Write Pipe should handle interpreting multi value properties

2016-06-02 Thread Jordan Shurmer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312431#comment-15312431 ] Jordan Shurmer commented on SLING-5758: --- That's correct. I have this working already

[jira] [Commented] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

2016-06-02 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313626#comment-15313626 ] Carsten Ziegeler commented on SLING-5757: - Patch looks good, I'm not so happy with

[jira] [Created] (SLING-5759) Distribution agents cannot be created via API

2016-06-02 Thread Marius Petria (JIRA)
Marius Petria created SLING-5759: Summary: Distribution agents cannot be created via API Key: SLING-5759 URL: https://issues.apache.org/jira/browse/SLING-5759 Project: Sling Issue Type: Bug

[jira] [Resolved] (SLING-5757) NonExistingResource.getParent() should not return null in case the parent is non-existing

2016-06-02 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-5757. Resolution: Fixed Fix Version/s: API 2.12.0 I applied the patch with a different test