Etiquettes while merging PR from contributors

2017-10-31 Thread Chetan Mehrotra
Hi Team, Given the switch to git I am now bit in dilemma on how to handle the PR merge. With svn it was always done by applying the patch and committing it. Keeps history fine. With Git there is choice to 'merge' or rebase. For external contributors it would be good if commit retains the original

[jira] [Resolved] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-7223. Resolution: Fixed Assignee: Chetan Mehrotra Fix Version/s: Commons Metrics RR

[jira] [Commented] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233656#comment-16233656 ] Chetan Mehrotra commented on SLING-7223: Done with [commit|https://gitbox.apache.

[jira] [Commented] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233655#comment-16233655 ] ASF GitHub Bot commented on SLING-7223: --- chetanmeh closed pull request #1: SLING-722

[jira] [Commented] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233654#comment-16233654 ] ASF GitHub Bot commented on SLING-7223: --- chetanmeh commented on issue #1: SLING-7223

[jira] [Commented] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226943#comment-16226943 ] ASF GitHub Bot commented on SLING-7223: --- mreutegg opened a new pull request #1: SLIN

[jira] [Resolved] (SLING-7222) Too frequent samples

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-7222. Resolution: Fixed Assignee: Chetan Mehrotra Fix Version/s: Commons Metrics RR

[jira] [Commented] (SLING-7222) Too frequent samples

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226884#comment-16226884 ] Chetan Mehrotra commented on SLING-7222: Applied patch with [commit|https://gitbo

[jira] [Resolved] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-7218. Resolution: Fixed Fix Version/s: Security 1.1.8 Fixed in https://github.com/apache/s

[jira] [Updated] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7218: --- Affects Version/s: (was: Security 1.1.6) Security 1.1.4 > NPE in or

[jira] [Updated] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7218: --- Affects Version/s: Security 1.1.6 > NPE in org.apache.sling.security.impl.ContentDispositionFi

[jira] [Assigned] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-7218: -- Assignee: Konrad Windszus (was: Antonio Sanso) > NPE in org.apache.sling.security.impl

[jira] [Comment Edited] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226783#comment-16226783 ] Konrad Windszus edited comment on SLING-7218 at 10/31/17 1:31 PM: --

[jira] [Commented] (SLING-7218) NPE in org.apache.sling.security.impl.ContentDispositionFilter#activate

2017-10-31 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226783#comment-16226783 ] Konrad Windszus commented on SLING-7218: This is correct. According to DS 1.3 an a

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226687#comment-16226687 ] Chetan Mehrotra commented on SLING-3049: bq. How about adding bundle + version onl

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2017-10-31 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226685#comment-16226685 ] Julian Reschke commented on SLING-3049: --- How about adding bundle + version only when

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2017-10-31 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226665#comment-16226665 ] Chetan Mehrotra commented on SLING-3049: So with bundle name included stacktrace l

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

2017-10-31 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226482#comment-16226482 ] Bertrand Delacretaz commented on SLING-3049: Thanks for this, looks very usefu

[jira] [Commented] (SLING-7223) Spikes in RRD after restart

2017-10-31 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226407#comment-16226407 ] Marcel Reutegger commented on SLING-7223: - I didn't know Sling is on github now. C