[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836974#comment-16836974
]
Thomas Mueller commented on SLING-8407:
---
There is at least one other place where th
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836977#comment-16836977
]
Carsten Ziegeler commented on SLING-8407:
-
[~tmueller] I think you're misinterpre
[
https://issues.apache.org/jira/browse/SLING-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836999#comment-16836999
]
Hans-Peter Stoerr commented on SLING-8404:
--
[~kwin]: I agree to what [~ch...@die
[
https://issues.apache.org/jira/browse/SLING-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836999#comment-16836999
]
Hans-Peter Stoerr edited comment on SLING-8404 at 5/10/19 7:48 AM:
[
https://issues.apache.org/jira/browse/SLING-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836999#comment-16836999
]
Hans-Peter Stoerr edited comment on SLING-8404 at 5/10/19 7:49 AM:
[
https://issues.apache.org/jira/browse/SLING-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836999#comment-16836999
]
Hans-Peter Stoerr edited comment on SLING-8404 at 5/10/19 7:49 AM:
Hi Gaston,
On Thu, 2019-05-09 at 12:10 -0700, Gaston Gonzalez wrote:
> Hi All,
>
> I have been researching an SSO solution for Sling for the last week
> and noticed that some work has been done around OpenID Connect.
> During my research I stumbled upon SLING-2759 and was able to get it
> working
[
https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837018#comment-16837018
]
Tommaso Teofili commented on SLING-8408:
I think the suggested patch looks good,
[
https://issues.apache.org/jira/browse/SLING-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837080#comment-16837080
]
Julian Sedding commented on SLING-8411:
---
[~karlpauls] Could you please explain the
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837083#comment-16837083
]
Brian Ka Sing Li commented on SLING-8377:
-
[~rombert] please review my pull reque
briankasingli opened a new pull request #10: SLING-8377 : [BUGFIX] Sling
Dynamic Include - Does not support empty "include selector" option.
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10
After testing out Sling Dynamic Include 3.1.2, it seems like setting an
rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include -
Does not support empty "include selector" option.
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491225339
Thanks a lot for the PR @briankasingli - looks good to me! Th
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-8377:
--
Assignee: Robert Munteanu
> Sling Dynamic Include - Does not support empty "include se
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-8377:
---
Fix Version/s: Dynamic Include 3.1.4
> Sling Dynamic Include - Does not support empty "includ
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837099#comment-16837099
]
Robert Munteanu commented on SLING-8377:
Thanks [~briankasingli] - I added a comm
briankasingli commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic
Include - Does not support empty "include selector" option.
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491235247
@rombert I've rebased my code with the master. Please r
briankasingli edited a comment on issue #10: SLING-8377 : [BUGFIX] Sling
Dynamic Include - Does not support empty "include selector" option.
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491235247
@rombert I've rebased my code with the master. P
Simone Tripodi created SLING-8412:
-
Summary: APIs jar MOJO includes wrapped classes which are not OSGi
exported and potentially override public APIs
Key: SLING-8412
URL: https://issues.apache.org/jira/browse/SLING
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837142#comment-16837142
]
Brian Ka Sing Li commented on SLING-8377:
-
[~rombert] I modified the code upon yo
[
https://issues.apache.org/jira/browse/SLING-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved SLING-8412.
---
Resolution: Fixed
fixed in
[41b701b|https://github.com/apache/sling-slingfeature-maven-plugi
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837160#comment-16837160
]
Thomas Mueller commented on SLING-8407:
---
> I prefer catching bugs at test time inst
[
https://issues.apache.org/jira/browse/SLING-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837193#comment-16837193
]
Konrad Windszus commented on SLING-8404:
[~hanspeterstoerr] Thanks for the explan
rombert commented on issue #10: SLING-8377 : [BUGFIX] Sling Dynamic Include -
Does not support empty "include selector" option.
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10#issuecomment-491249919
I've applied the patch in a separate commit since we avoid me
rombert closed pull request #10: SLING-8377 : [BUGFIX] Sling Dynamic Include -
Does not support empty "include selector" option.
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/10
This is an automa
[
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-8377.
Resolution: Fixed
Applied in
https://github.com/apache/sling-org-apache-sling-dynamic-incl
kwin merged pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR
URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SLING-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8272:
---
Fix Version/s: Context-Aware Configuration Impl 1.4.18
Context-Aware Config
[
https://issues.apache.org/jira/browse/SLING-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-8272.
Resolution: Fixed
Both PRs are merged now (after several review rounds):
API:
https://gith
Thomas Mueller created SLING-8413:
-
Summary: JobManagerImpl.findJobs does not escape some values when
running queries
Key: SLING-8413
URL: https://issues.apache.org/jira/browse/SLING-8413
Project: Sli
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837230#comment-16837230
]
Thomas Mueller commented on SLING-8407:
---
About adding a new API: I tried changing
[
https://issues.apache.org/jira/browse/SLING-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837246#comment-16837246
]
Karl Pauls commented on SLING-8411:
---
[~jsedding], sure - however, it sounds like you al
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837252#comment-16837252
]
Timothee Maret commented on SLING-8407:
---
There may be a way between blocking everyt
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837247#comment-16837247
]
Jason E Bailey commented on SLING-8407:
---
[~tmueller] Allow me to provide a thought
Christian Schneider created SLING-8414:
--
Summary: Add support for Azure Eventhubs as backend
Key: SLING-8414
URL: https://issues.apache.org/jira/browse/SLING-8414
Project: Sling
Issue Ty
[
https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837265#comment-16837265
]
Thomas Mueller commented on SLING-8408:
---
The exception can also be thrown if the qu
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837262#comment-16837262
]
Thomas Mueller commented on SLING-8407:
---
Pull request: https://github.com/apache/sl
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837267#comment-16837267
]
Carsten Ziegeler commented on SLING-8407:
-
[~marett] I think that's a way better
thomasmueller opened a new pull request #17: SLING-8408
DistributionQueueHealthCheck should deal with failing queries
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/17
This is an automated messa
[
https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837284#comment-16837284
]
Thomas Mueller commented on SLING-8408:
---
Pull request:
https://github.com/apache/s
tteofili commented on issue #17: SLING-8408 DistributionQueueHealthCheck should
deal with failing queries
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/17#issuecomment-491289726
+1 LGTM
This is
[
https://issues.apache.org/jira/browse/SLING-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837296#comment-16837296
]
Thomas Mueller commented on SLING-8413:
---
A possible patch (without test case):
{nof
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837309#comment-16837309
]
Vikas Saurabh commented on SLING-8407:
--
bq. register a service implementing this API
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837316#comment-16837316
]
Timothee Maret commented on SLING-8407:
---
[~catholicon] I agree one marker may be to
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837320#comment-16837320
]
Vikas Saurabh commented on SLING-8407:
--
[~marett],
bq. to wait on a specific m
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837360#comment-16837360
]
Timothee Maret commented on SLING-8407:
---
{quote}Queries and indexes are de-coupled
Hi,
The vote has passed with the following result :
+4 (binding): Daniel Klco, Radu Cotescu, Robert Munteanu, Stefan Seifert
+1 (non binding): Timothee Maret
Can a PMC copy this release to the Sling dist directory?
Staging Repository:
https://repository.apache.org/content/repositories/orgapac
[
https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837424#comment-16837424
]
Vikas Saurabh commented on SLING-8407:
--
[~marett], option traversal fail is a loose
Done!
On Fri, May 10, 2019 at 12:00 PM Andreas Schaefer
wrote:
> Hi,
>
> The vote has passed with the following result :
>
> +4 (binding): Daniel Klco, Radu Cotescu, Robert Munteanu, Stefan Seifert
> +1 (non binding): Timothee Maret
>
> Can a PMC copy this release to the Sling dist directory?
>
Thanks. Released the Staging Repository and updated the Release page.
- Andy
> On May 10, 2019, at 10:52 AM, Daniel Klco wrote:
>
> Done!
>
> On Fri, May 10, 2019 at 12:00 PM Andreas Schaefer
> wrote:
>
>> Hi,
>>
>> The vote has passed with the following result :
>>
>> +4 (binding): Daniel
49 matches
Mail list logo