[GitHub] [sling-org-apache-sling-feature-launcher] cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#discussion_r284984356 ## File path: src/main/java/org/apache/sling/feature/launc

[GitHub] [sling-org-apache-sling-feature-launcher] cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#discussion_r284984198 ## File path: src/main/java/org/apache/sling/feature/launc

[GitHub] [sling-org-apache-sling-feature-launcher] cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
cziegeler commented on a change in pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#discussion_r284984239 ## File path: src/main/java/org/apache/sling/feature/launc

[GitHub] [sling-org-apache-sling-feature-io] cziegeler commented on a change in pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
cziegeler commented on a change in pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/12#discussion_r284984009 ## File path: src/main/java/org/apache/sling/feature/io/file/s

[GitHub] [sling-org-apache-sling-feature-io] cziegeler commented on a change in pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
cziegeler commented on a change in pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/12#discussion_r284983694 ## File path: src/main/java/org/apache/sling/feature/io/file/Ar

Re: [VOTE] Release Sling Default POST Servlets 2.3.30, Sling Form Based Authentication Handler 1.0.14, Sling Starter Content 1.0.4

2019-05-16 Thread Georg Henzler
+1 On 2019-05-15 22:58, Georg Henzler wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20in%20(%22Starter%20Content%201.0.4%22%2C%20%22Form%20Based%20Authentication%201.0.14%22%2C%20%22Servlets%20Post%202.3.30%2

[jira] [Created] (SLING-8423) Make Provisioning to Feature Model Usable for Sling Conversion

2019-05-16 Thread Andreas Schaefer (JIRA)
Andreas Schaefer created SLING-8423: --- Summary: Make Provisioning to Feature Model Usable for Sling Conversion Key: SLING-8423 URL: https://issues.apache.org/jira/browse/SLING-8423 Project: Sling

[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
karlpauls commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#issuecomment-493216317 Jenkins can't be green for this one at this point because it requires https://github

[jira] [Created] (SLING-8422) SlingQuery doesn't convert 'has' selector to query properly

2019-05-16 Thread Jordan Shurmer (JIRA)
Jordan Shurmer created SLING-8422: - Summary: SlingQuery doesn't convert 'has' selector to query properly Key: SLING-8422 URL: https://issues.apache.org/jira/browse/SLING-8422 Project: Sling

[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
kwin edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493159539 @ncautotest IIUC at the point where you try to set properties the node(and by that also

[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
kwin edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493159539 @ncautotest IIUC at the point where you try to set properties the node(and by that also

[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin commented on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
kwin commented on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493159539 @ncautotest IIUC at the point where you try to set properties the node(and by that also the und

[GitHub] [sling-org-apache-sling-jcr-contentloader] ncautotest edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
ncautotest edited a comment on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493138961 @rombert: my understanding was that something like `node.getProperty(name)` would

[GitHub] [sling-org-apache-sling-jcr-contentloader] ncautotest commented on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
ncautotest commented on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493138961 @rombert: my understanding was that something like `node.getProperty(name);` would only w

[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert edited a comment on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
stefanseifert edited a comment on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4#issuecomment-493128366 thanks for bringing this up. to avoid breaking the compatibility with pr

[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
stefanseifert commented on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4#issuecomment-493128366 thanks for bringing this up. to avoid breaking the compatibility with previous

[GitHub] [sling-org-apache-sling-feature-launcher] bosschaert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
bosschaert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#issuecomment-493126770 +1 (assuming Jenkins is green) Ps @rombert thanks for the tip on rebuilding.

[GitHub] [sling-org-apache-sling-feature-io] bosschaert commented on issue #12: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
bosschaert commented on issue #12: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/12#issuecomment-493126025 Good stuff. Assuming that Jenkins is green now (I kicked it off again to pick up the 1.

[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga opened a new pull request #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
rmcdouga opened a new pull request #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4 … (was geStatusMessage). This is an au

[GitHub] [sling-org-apache-sling-servlet-helpers] rombert edited a comment on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
rombert edited a comment on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4#issuecomment-493120216 @rmcdouga - this is indeed just a typo. However, since this is API, the baseline

[GitHub] [sling-org-apache-sling-servlet-helpers] rombert closed pull request #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
rombert closed pull request #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4 This is an automated message from the Apache

[GitHub] [sling-org-apache-sling-servlet-helpers] rombert commented on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()…

2019-05-16 Thread GitBox
rombert commented on issue #4: Fixed a small typo in MockSlingHttpServletResponse.getStatusMessage()… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/4#issuecomment-493120216 @rmcdouga - this is indeed just a typo. However, since this is API, the baseline check

[GitHub] [sling-org-apache-sling-jcr-contentloader] rombert commented on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
rombert commented on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493119263 @ncautotest - instead of `node.setProperty(name, value)` you can do something like ``

[GitHub] [sling-org-apache-sling-jcr-contentloader] ncautotest commented on issue #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
ncautotest commented on issue #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2#issuecomment-493118033 @rombert: Using `javax.jcr.nodetype.ItemDefinition.isProtected()` would definitely be a b

[GitHub] [sling-org-apache-sling-feature-launcher] rombert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
rombert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#issuecomment-493104558 @bosschaert - click the 'details' link thext to the failed check. If logged in, there

[GitHub] [sling-org-apache-sling-feature-launcher] bosschaert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
bosschaert commented on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#issuecomment-493101681 The reason that the build failed is that this commit depends on Feature Model 1.0.2

[GitHub] [sling-org-apache-sling-feature-launcher] bosschaert edited a comment on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
bosschaert edited a comment on issue #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9#issuecomment-493101681 The reason that the build failed is that this commit depends on Feature Mode

[RESULT][VOTE] Release Sling Feature Components 1.0.2

2019-05-16 Thread davidb
With 7 +1 votes this release succeeds. I've promoted the artifacts and will update the Dist folder. Best regards, On Mon, 13 May 2019 at 14:11, wrote: > Hi all, > > I would like to call the 1.0.2 release on the following components: > > org.apache.sling.feature 1.0.2 > fixed issues: > https://i

Re: [VOTE] Release Sling Feature Components 1.0.2

2019-05-16 Thread David Bosschaert
Here's my +1 too. David On Tue, 14 May 2019 at 19:21, Daniel Klco wrote: > +1 > > On Tue, May 14, 2019 at 1:38 AM Carsten Ziegeler > wrote: > > > I think it's fine if these modules require additional bundles like > > commons text or the converter to be installed. > > > > The only one that worr

[jira] [Updated] (SLING-8421) Allow artifact providers that work with URLs instead of Files

2019-05-16 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert updated SLING-8421: Fix Version/s: (was: Feature Model IO 1.0.2) Feature Model IO 1.0.4

[jira] [Commented] (SLING-8375) SlingPostServlet: :import operation must skip protected properties if present

2019-05-16 Thread Viorel Lupu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841369#comment-16841369 ] Viorel Lupu commented on SLING-8375: [~rombert]: I've made a PR which is linked in th

[jira] [Commented] (SLING-8421) Allow artifact providers that work with URLs instead of Files

2019-05-16 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841328#comment-16841328 ] Karl Pauls commented on SLING-8421: --- I created the following two PR to address this: [

[GitHub] [sling-org-apache-sling-feature-io] karlpauls opened a new pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
karlpauls opened a new pull request #12: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/12 …iles This is an automated message from

[GitHub] [sling-org-apache-sling-jcr-contentloader] ncautotest opened a new pull request #2: SLING-8375 - Allow import if data contains protected properties

2019-05-16 Thread GitBox
ncautotest opened a new pull request #2: SLING-8375 - Allow import if data contains protected properties URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/2 - possibly the try/catch solution is a bit of a brute-force approach and a better solution might exist whi

[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls opened a new pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F…

2019-05-16 Thread GitBox
karlpauls opened a new pull request #9: SLING-8421: Allow artifact providers that work with URLs instead of F… URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/9 …iles. This is an automated message

[jira] [Created] (SLING-8421) Allow artifact providers that work with URLs instead of Files

2019-05-16 Thread Karl Pauls (JIRA)
Karl Pauls created SLING-8421: - Summary: Allow artifact providers that work with URLs instead of Files Key: SLING-8421 URL: https://issues.apache.org/jira/browse/SLING-8421 Project: Sling Issue

[GitHub] [sling-org-apache-sling-feature-cpconverter] simonetripodi merged pull request #4: SLING-8420 - making sure that vault filters for subpackages are set t…

2019-05-16 Thread GitBox
simonetripodi merged pull request #4: SLING-8420 - making sure that vault filters for subpackages are set t… URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/4 This is an automated message from

[GitHub] [sling-org-apache-sling-feature-cpconverter] simonetripodi commented on issue #4: SLING-8420 - making sure that vault filters for subpackages are set t…

2019-05-16 Thread GitBox
simonetripodi commented on issue #4: SLING-8420 - making sure that vault filters for subpackages are set t… URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/4#issuecomment-493054231 thanks a lot for the hard work @DominikSuess , your modifications are now mer

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess opened a new pull request #4: SLING-8420 - making sure that vault filters for subpackages are set t…

2019-05-16 Thread GitBox
DominikSuess opened a new pull request #4: SLING-8420 - making sure that vault filters for subpackages are set t… URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/4 …o a noop filter (root path / excluding everything with mode=merge) the resulting package will

[jira] [Created] (SLING-8420) Converter generates buggy vault packages

2019-05-16 Thread JIRA
Dominik Süß created SLING-8420: -- Summary: Converter generates buggy vault packages Key: SLING-8420 URL: https://issues.apache.org/jira/browse/SLING-8420 Project: Sling Issue Type: Bug

Re: [Feature Analyser] Usage scenario gap

2019-05-16 Thread Karl Pauls
I would make it an external extension because that way you can have the analyser on the classpath without affecting the launcher. regards, Karl On Thu, May 16, 2019 at 11:25 AM Dominik Süß wrote: > > Sounds good to me - would you suggest to make this a default behavior of > the analyser or maki

Re: [Feature Analyser] Usage scenario gap

2019-05-16 Thread Dominik Süß
Sounds good to me - would you suggest to make this a default behavior of the analyser or making this an explicit external extension? Depending on this I'd either add that to the whiteboard or a PR to the existing analyser artifact. Cheers Dominik On Thu, May 16, 2019 at 10:55 AM Karl Pauls wrote

[jira] [Commented] (SLING-8411) Provide a way to bifurcate a repository path to a provider mount

2019-05-16 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841137#comment-16841137 ] Karl Pauls commented on SLING-8411: --- [~cziegeler], I agree. Furthermore, I guess there

Re: [Feature Analyser] Usage scenario gap

2019-05-16 Thread Karl Pauls
You don't need a standalone CLI nor add the analyser capabilites to the feature launcher. You should be able to create a launcher extension that you can hook into the launcher to act as an analyser. I added that possibility in SLING-8386. In sort, you use the feature launcher and provide a org.apa

Re: [Feature Analyser] Usage scenario gap

2019-05-16 Thread Dominik Süß
I just noticed that I missed to add details why using the maven build failed for me - at this build time I only have the cachefolder available as "local repository" - the way that the repository goal produces this cache folder doesn't generate/download the pom.xml files for the artifacts. I first w

Re: [Feature Analyser] Usage scenario gap

2019-05-16 Thread Dominik Süß
Hi Carsten, hi David, basically, there are 2 scenarios (where I currently primarily focus on scenario 1) 1) we have a set of base features developed by one party and have another party developing a "customer" feature that is running on top of base feature. Both features have their own lifecycle