[Jenkins] Sling » sling-org-apache-sling-starter » master #87 is BROKEN

2019-11-08 Thread Apache Jenkins Server
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/87/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 228 lines...] 09.11.2019 07:50:56.573 *INFO* [OsgiInstallerImpl] org.apa

Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10

2019-11-08 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Nov 7, 2019, at 2:01 AM, Carsten Ziegeler wrote: > > Hi, > > We solved 4 issues > > https://issues.apache.org/jira/browse/SLING-8831?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22slingfeature-maven-plugin%201.1.10%22 > > Staging repository: > https://re

Sling FM Starter Module

2019-11-08 Thread Andreas Schaefer
Hi I am wondering how a Sling FM Starter Module would look like and how it is used by clients like Peregrine. It is my assumption that any FM slingosgifeature project will install that file on release on a public Maven repository like all of our Sling Module. Then the Sling FM Starter Module w

[jira] [Resolved] (SLING-8762) Sling CMS - Create Archetype

2019-11-08 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8762. - Resolution: Fixed Fixed on  https://github.com/apache/sling-org-apache-sling-app-cms/commit/467816fc4b19a

[jira] [Assigned] (SLING-8762) Sling CMS - Create Archetype

2019-11-08 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-8762: --- Assignee: Dan Klco > Sling CMS - Create Archetype > > >

[jira] [Resolved] (SLING-8719) CMS - Add Support for Basic Forms

2019-11-08 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8719. - Assignee: Dan Klco Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-ap

[jira] [Created] (SLING-8835) CMS - Make Transformations Based on Definitions

2019-11-08 Thread Dan Klco (Jira)
Dan Klco created SLING-8835: --- Summary: CMS - Make Transformations Based on Definitions Key: SLING-8835 URL: https://issues.apache.org/jira/browse/SLING-8835 Project: Sling Issue Type: Improvement

[jira] [Created] (SLING-8836) CMS - Add Grid View

2019-11-08 Thread Dan Klco (Jira)
Dan Klco created SLING-8836: --- Summary: CMS - Add Grid View Key: SLING-8836 URL: https://issues.apache.org/jira/browse/SLING-8836 Project: Sling Issue Type: New Feature Affects Versions: Version

[jira] [Resolved] (SLING-8836) CMS - Add Grid View

2019-11-08 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8836. - Resolution: Fixed Fixed in  https://github.com/apache/sling-org-apache-sling-app-cms/commit/38833c0315a62

[jira] [Resolved] (SLING-8835) CMS - Make Transformations Based on Definitions

2019-11-08 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8835. - Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/38833c0315a6

Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10

2019-11-08 Thread Daniel Klco
+1 On Fri, Nov 8, 2019 at 5:46 AM Nicolas Peltier wrote: > +1 > > Le ven. 8 nov. 2019 à 10:59, Stefan Seifert a > écrit : > > > +1 > > > > >

[GitHub] [sling-org-apache-sling-scripting-esx] HarisAdzemovic commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()"

2019-11-08 Thread GitBox
HarisAdzemovic commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#discussion_r344179168 ## File path: src/main/java/org/apache/sling/scripting/esx/Module.ja

[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"

2019-11-08 Thread GitBox
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551787523 Sorry, you're right that it should probably be changed. I missed one case: ``` Integ

Re: [feature] Analyser complains that 'Bundle contains classes in the default package'

2019-11-08 Thread Carsten Ziegeler
Hi it seems you run with all available checks. You should only run api region checks if you use api regions. We recently moved all analysers that use api regions to the regions extension. The other check is done by the analyser for OSGi connect; I can't recall why this check was useful thoug

[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"

2019-11-08 Thread GitBox
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551771185 They differ in how they handle null: ``` Integer a = new Integer(10); Int

[GitHub] [sling-org-apache-sling-scripting-esx] rombert commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()"

2019-11-08 Thread GitBox
rombert commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#discussion_r344144888 ## File path: src/main/java/org/apache/sling/scripting/esx/Module.java ###

[GitHub] [sling-org-apache-sling-feature] rombert commented on issue #15: Strings and Boxed types should be compared using "equals()"

2019-11-08 Thread GitBox
rombert commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551677421 @bosschaert , @HarisAdzemovic - shouldn't we use `Integer.compare(o1, o2)` here? --

[feature] Analyser complains that 'Bundle contains classes in the default package'

2019-11-08 Thread Robert Munteanu
Hi, I'm build an application using the feature model tooling. I enabled analysers and got shout at by the 'api-regions-check-order' checker since it required configuration. I don't use API regions, so I disabled that. Then I ran into a problem due to jackson jar having classes in the default pack

Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10

2019-11-08 Thread Nicolas Peltier
+1 Le ven. 8 nov. 2019 à 10:59, Stefan Seifert a écrit : > +1 > >

RE: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10

2019-11-08 Thread Stefan Seifert
+1

[jira] [Resolved] (SLING-8834) sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin

2019-11-08 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-8834. --- Resolution: Fixed https://github.com/apache/sling-parent/commit/cef099f9ebf55a23a99b1b297e42a

[jira] [Created] (SLING-8834) sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin

2019-11-08 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-8834: - Summary: sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin Key: SLING-8834 URL: https://issues.apache.org/jira/browse/SLING-8834 Project: Sling

[jira] [Commented] (SLING-8743) Move DistributionQueueBuilderFactory class from impl to api surface

2019-11-08 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969990#comment-16969990 ] Timothee Maret commented on SLING-8743: --- IMO it makes sense to expose a cleaned up