[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on issue #2: SLING-9200 Adding a global timeout for waitForSystemStartup

2020-03-13 Thread GitBox
sonarcloud[bot] commented on issue #2: SLING-9200 Adding a global timeout for waitForSystemStartup URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/2#issuecomment-598580912 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_

[GitHub] [sling-org-apache-sling-servlets-annotations] kwin opened a new pull request #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
kwin opened a new pull request #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3 This is an automated message from the Apache Git Service. To respond to

[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598588671 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apach

[jira] [Commented] (SLING-9055) Implement a new SlingServletPathsStrict annotation

2020-03-13 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058479#comment-17058479 ] Konrad Windszus commented on SLING-9055: The approach from https://github.com/ap

[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598589664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apach

[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] removed a comment on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
sonarcloud[bot] removed a comment on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598588671 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-

[jira] [Resolved] (SLING-9202) Repository init may fail with ClassCastException

2020-03-13 Thread Marcel Reutegger (Jira)
[ https://issues.apache.org/jira/browse/SLING-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved SLING-9202. - Resolution: Duplicate Indeed, this is a duplicate of SLING-9195. > Repository init may f

[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] removed a comment on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
sonarcloud[bot] removed a comment on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598589664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-

[GitHub] [sling-org-apache-sling-servlets-annotations] sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
sonarcloud[bot] commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598596350 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apach

[jira] [Commented] (SLING-9090) AclLine.Action.REMOVE and AclLine.Action.REMOVE_ALL not handled in jcr implementation

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058572#comment-17058572 ] Bertrand Delacretaz commented on SLING-9090: It looks like the impact of REMO

[GitHub] [sling-org-apache-sling-servlets-annotations] bdelacretaz commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
bdelacretaz commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598652519 The companion https://github.com/apache/sling-org-apache-sling-servlets-annotations-it tests fail for me with the

[GitHub] [sling-org-apache-sling-servlets-annotations] kwin commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
kwin commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598658115 Indeed I tested against the wrong bundle version, let me look up the according bnd code to find another way on how to gen

[GitHub] [sling-org-apache-sling-servlets-annotations] kwin edited a comment on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
kwin edited a comment on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598658115 Indeed I tested against the wrong bundle version, let me look up the according bnd code to find another way on how

[GitHub] [sling-org-apache-sling-servlets-annotations] kwin edited a comment on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
kwin edited a comment on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598658115 Indeed I tested against the wrong bundle version, let me look up the according bnd code to find another way on how

[GitHub] [sling-org-apache-sling-servlets-annotations] bdelacretaz commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
bdelacretaz commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598694367 Thank you, I have commented at https://osgi.org/bugzilla/show_bug.cgi?id=250 as I think this matches the spec's in

[GitHub] [sling-org-apache-sling-servlets-annotations] kwin commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
kwin commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598695583 No, that shouldn't block the release. Just add an additional comment on the method https://github.com/apache/sling-org-a

[GitHub] [sling-org-apache-sling-servlets-annotations] bdelacretaz commented on issue #3: Feature/paths strict metaannotation

2020-03-13 Thread GitBox
bdelacretaz commented on issue #3: Feature/paths strict metaannotation URL: https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/3#issuecomment-598697455 Makes sense, I have added a loud comment there: > * This value should NOT BE CHANGED: this annotation m

[jira] [Commented] (SLING-9055) Implement a new SlingServletPathsStrict annotation

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058693#comment-17058693 ] Bertrand Delacretaz commented on SLING-9055: As explained in Konrad's PR the

[jira] [Commented] (SLING-6793) Remove unused methods from XSSAPI

2020-03-13 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058708#comment-17058708 ] Konrad Windszus commented on SLING-6793: [~cziegeler] Although it is pretty easy

[jira] [Commented] (SLING-6793) Remove unused methods from XSSAPI

2020-03-13 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058720#comment-17058720 ] Carsten Ziegeler commented on SLING-6793: - First of all, my recommendation is to

[jira] [Resolved] (SLING-9195) Repoinit rep:restrictions gives error in some cases

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-9195. Resolution: Fixed Thank you for your contribution! I have merged your PR and made m

[jira] [Assigned] (SLING-9195) Repoinit rep:restrictions gives error in some cases

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-9195: -- Assignee: Bertrand Delacretaz > Repoinit rep:restrictions gives error in some

[jira] [Updated] (SLING-9195) Repoinit rep:restrictions gives error in some cases

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-9195: --- Fix Version/s: Repoinit JCR 1.1.22 > Repoinit rep:restrictions gives error in some ca

[jira] [Resolved] (SLING-9084) Add members to groups during repoinit

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-9084. Resolution: Fixed I have now merged your second PR for jcr-repoinit, thanks for the

[jira] [Updated] (SLING-9084) Add members to groups during repoinit

2020-03-13 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-9084: --- Fix Version/s: Repoinit Parser 1.5.2 Repoinit JCR 1.1.22 > Add mem