[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node

2020-05-05 Thread GitBox
sonarcloud[bot] commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-624461073 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-resource&pullRequest=8&re

[GitHub] [sling-org-apache-sling-discovery-base] Mahir92 commented on pull request #1: Change for security concern

2020-05-05 Thread GitBox
Mahir92 commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/1#issuecomment-624423118 Hi @rombert , if there is any update from you or @stefan-egli regarding the proposed fix, please let me know. It would be helpful in understanding if it'

[GitHub] [sling-org-apache-sling-discovery-base] Mahir92 removed a comment on pull request #1: Change for security concern

2020-05-05 Thread GitBox
Mahir92 removed a comment on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/1#issuecomment-624422772 Hi @rombert , if there is any update from you or @stefan-egli regarding the proposed fix then please let me know. It will be very appreciated.

[GitHub] [sling-org-apache-sling-discovery-base] Mahir92 commented on pull request #1: Change for security concern

2020-05-05 Thread GitBox
Mahir92 commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/1#issuecomment-624422772 Hi @rombert , if there is any update from you or @stefan-egli regarding the proposed fix then please let me know. It will be very appreciated. Tha

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #10: SLING-9406: Add bundled script support to the servlets resolver

2020-05-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-624063448 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pul

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #10: SLING-9406: Add bundled script support to the servlets resolver

2020-05-05 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-624321076 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest

Re: Ianal Maven Plugin?

2020-05-05 Thread Robert Munteanu
On Tue, 2020-05-05 at 19:11 +0200, Bertrand Delacretaz wrote: > On Tue, May 5, 2020 at 6:21 PM Konrad Windszus > wrote: > > ...interesting finding but unfortunately last updated in 2008 > > ( > > https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin > > ). > > S

[GitHub] [sling-whiteboard] cmrockwell edited a comment on pull request #51: SAML2 Service Provider Pull Request

2020-05-05 Thread GitBox
cmrockwell edited a comment on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623685394 Sound good. Thank you for merging this. I'll spend some time to analyze the build issue you identified and report back once I'm able to reproduce it. Updat

Re: Ianal Maven Plugin?

2020-05-05 Thread Bertrand Delacretaz
On Tue, May 5, 2020 at 6:21 PM Konrad Windszus wrote: > ...interesting finding but unfortunately last updated in 2008 > ( > https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin). > Seems dead as well But that's code that already belongs to the ASF, if some

Re: Ianal Maven Plugin?

2020-05-05 Thread Konrad Windszus
Hi, interesting finding but unfortunately last updated in 2008 ( https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plugin). Seems dead as well Konrad > On 5. May 2020, at 17:19, Bertrand Delacretaz wrote: > > Hi, > > On Tue, May 5, 2020 at 11:23 AM Robert

Re: Ianal Maven Plugin?

2020-05-05 Thread Bertrand Delacretaz
Hi, On Tue, May 5, 2020 at 11:23 AM Robert Munteanu wrote: > ...If we would find a way to replace it, it would be even > better :-).. I stumbled on https://geronimo.apache.org/maven/genesis/plugins/tools-maven-plugin/usage.html by chance, which apparently ("verify-legal-file") does check for LI

[jira] [Resolved] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-9419. Resolution: Fixed > JCR Repoinit integration tests fail on Windows > --

[jira] [Assigned] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-9419: -- Assignee: Bertrand Delacretaz > JCR Repoinit integration tests fail on Windows

[jira] [Updated] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-9419: --- Affects Version/s: Repoinit JCR 1.1.26 > JCR Repoinit integration tests fail on Windo

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-05-05 Thread GitBox
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-624092740 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration

[jira] [Commented] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099944#comment-17099944 ] Stefan Seifert commented on SLING-9419: --- confirmed! - both unit tests and integrati

Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.2

2020-05-05 Thread Daniel Klco
+1 On Tue, May 5, 2020 at 6:11 AM wrote: > +1 > > David > > On Tue, 5 May 2020 at 11:07, Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > On 05.05.2020 11:55, dav...@apache.org wrote: > > > Hi all, > > > > > > I would like to call the release on the Sling Feature Model API Regions > >

[jira] [Commented] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099934#comment-17099934 ] Bertrand Delacretaz commented on SLING-9419: I changed the test to use {{File

[jira] [Commented] (SLING-9419) JCR Repoinit integration tests fail on Windows

2020-05-05 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099920#comment-17099920 ] Bertrand Delacretaz commented on SLING-9419: Thank you! So the failure scenar

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #10: SLING-9406: Add bundled script support to the servlets resolver

2020-05-05 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-624063448 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #10: SLING-9406: Add bundled script support to the servlets resolver

2020-05-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-622153482 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pul

[jira] [Created] (SLING-9424) Use dependencies for apis and sources

2020-05-05 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9424: --- Summary: Use dependencies for apis and sources Key: SLING-9424 URL: https://issues.apache.org/jira/browse/SLING-9424 Project: Sling Issue Type: Improve

[jira] [Created] (SLING-9423) Provide javadoc links per bundle for javadoc generation

2020-05-05 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9423: --- Summary: Provide javadoc links per bundle for javadoc generation Key: SLING-9423 URL: https://issues.apache.org/jira/browse/SLING-9423 Project: Sling I

[GitHub] [sling-org-apache-sling-servlets-resolver] raducotescu commented on a change in pull request #10: SLING-9406: Add bundled script support to the servlets resolver

2020-05-05 Thread GitBox
raducotescu commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#discussion_r420018244 ## File path: src/main/java/org/apache/sling/servlets/resolver/bundle/tracker/BundledScriptFinder.java ## @@ -0,0 +1,32

Re: Building a main + test jar from the provisioning model

2020-05-05 Thread Carsten Ziegeler
I'm not sure if this works ootb, but you could try creating a model archive out of the testing provisioning model and then at runtime use the osgi installer (with the prov model plugin) to install the testing part. I think the slingfeature maven plugin is flexible enough to do so for feature m

[jira] [Commented] (SLING-9417) Content-type and InputStream are null when accessing nt:file resources with ";v="

2020-05-05 Thread Matthias Herold (Jira)
[ https://issues.apache.org/jira/browse/SLING-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099797#comment-17099797 ] Matthias Herold commented on SLING-9417: In addition to the integration test, a l

Re: Building a main + test jar from the provisioning model

2020-05-05 Thread Konrad Windszus
Hi Robert, I guess you need some tweaks in https://github.com/apache/sling-slingstart-maven-plugin/blob/5bbdae1d61698ac202845e5f242ecc8b602e7ed6/src/main/java/org/apache/sling/maven/slingstart/run/StartMojo.java#L366. The launchpad to start must consist of the merged 2 provisioning models, so mos

[GitHub] [sling-org-apache-sling-jcr-resource] alldaysunshine opened a new pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node

2020-05-05 Thread GitBox
alldaysunshine opened a new pull request #8: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8 See issue in Jira. This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.2

2020-05-05 Thread davidb
+1 David On Tue, 5 May 2020 at 11:07, Carsten Ziegeler wrote: > +1 > > Carsten > > On 05.05.2020 11:55, dav...@apache.org wrote: > > Hi all, > > > > I would like to call the release on the Sling Feature Model API Regions > > Runtime Fragment 1.1.2. > > > > Resolved issues: > > https://issues.ap

Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.2

2020-05-05 Thread Carsten Ziegeler
+1 Carsten On 05.05.2020 11:55, dav...@apache.org wrote: Hi all, I would like to call the release on the Sling Feature Model API Regions Runtime Fragment 1.1.2. Resolved issues: https://issues.apache.org/jira/projects/SLING/versions/12348198 Staging repository: https://repository.apache.org/

Building a main + test jar from the provisioning model

2020-05-05 Thread Robert Munteanu
Hi, I am trying out moving the launchpad-testing module to the sling starter. This is just an experiment for now, will get back to the list in case I am successful for a proper discussion. The launchpad-testing module has its own limited provisioning model file [1]. I am trying to add it to the s

[VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.2

2020-05-05 Thread davidb
Hi all, I would like to call the release on the Sling Feature Model API Regions Runtime Fragment 1.1.2. Resolved issues: https://issues.apache.org/jira/projects/SLING/versions/12348198 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2256 You can use this UN

[jira] [Commented] (SLING-9410) BSN to feature cache does not get udpated when new configuration arrives

2020-05-05 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099733#comment-17099733 ] A. J. David Bosschaert commented on SLING-9410: --- Fixed via PR #8 https://g

[jira] [Resolved] (SLING-9410) BSN to feature cache does not get udpated when new configuration arrives

2020-05-05 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-9410. --- Resolution: Fixed > BSN to feature cache does not get udpated when new config

Re: Ianal Maven Plugin?

2020-05-05 Thread Robert Munteanu
Ack. Feel free to file an issue against the parent pom so we don't forget about it. If would find a way to replace it, it would be even better :-) Thanks, Robert On Mon, 2020-05-04 at 12:01 -0700, Andreas Schaefer wrote: > I had an issue where the plugin (because I used Sling Parent POM) and > co

Re: Do we still need https://sling.apache.org/releases.html ?

2020-05-05 Thread Bertrand Delacretaz
Hi, On Tue, May 5, 2020 at 10:18 AM Carsten Ziegeler wrote: > ...So the question is, whether we want or need to keep three lists. > We have: > - the reporter data > - the releases page > - the downloads list/page .. Good point, I only considered the first two so far. We actually also have Maven

Re: Do we still need https://sling.apache.org/releases.html ?

2020-05-05 Thread Carsten Ziegeler
Right, thanks Robert So the question is, whether we want or need to keep three lists. We have: - the reporter data - the releases page - the downloads list/page I'm usually not updating the reporter data on a release and it seems others are not doing that either. The same happens sometimes to t

Re: Do we still need https://sling.apache.org/releases.html ?

2020-05-05 Thread Robert Munteanu
On Tue, 2020-05-05 at 08:11 +0200, Carsten Ziegeler wrote: > > On 04.05.2020 16:36, Bertrand Delacretaz wrote: > > On Mon, May 4, 2020 at 4:22 PM Carsten Ziegeler < > > cziege...@apache.org> wrote: > > > ...Today, if someone forgets to add a release to our webpage, we > > > can easily > > > fix th

[jira] [Commented] (SLING-9417) Content-type and InputStream are null when accessing nt:file resources with ";v="

2020-05-05 Thread Matthias Herold (Jira)
[ https://issues.apache.org/jira/browse/SLING-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099590#comment-17099590 ] Matthias Herold commented on SLING-9417: Thank you for the pointer to the integra

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] alldaysunshine opened a new pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2020-05-05 Thread GitBox
alldaysunshine opened a new pull request #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1 When adding a file as a child of a versioned node, it is not possible to receive old versions of the file via the DefaultGetServlet. It is possible to rece