Re: Intra Sling Calls

2020-06-02 Thread Carsten Ziegeler
Hi, so you rather want to call the http service instead (which then eventually calls Sling), correct? Regards Carsten Am 02.06.2020 um 19:32 schrieb Andreas Schaefer: Hi Carsten Not really an HTTP request but internally go through the HTTP stack. We are using these Intra Sling Calls for Im

[jira] [Commented] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build

2020-06-02 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124506#comment-17124506 ] Andreas Schaefer commented on SLING-9498: - [~rombert] BTW if you want to see how

[jira] [Commented] (SLING-9497) Announce + discuss intention to drop WAR file support to users

2020-06-02 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124456#comment-17124456 ] Andreas Schaefer commented on SLING-9497: - >From my point of view a WAR file beco

[jira] [Commented] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build

2020-06-02 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124453#comment-17124453 ] Andreas Schaefer commented on SLING-9498: - In the long run Sling Starter will be

[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #9: SLING-9498 - Create feature model aggregates on the fly from the Sling Starter build

2020-06-02 Thread GitBox
rombert opened a new pull request #9: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SLING-9497) Announce + discuss intention to drop WAR file support to users

2020-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124321#comment-17124321 ] Robert Munteanu commented on SLING-9497: - https://lists.apache.org/thread.html/

Re: [discuss] Migrating the Sling Starter to the Feature Model

2020-06-02 Thread Robert Munteanu
On Mon, 2020-05-25 at 17:32 +0200, Robert Munteanu wrote: > Top-posting as an attempt to sum up the next steps. > > I think we are more or less in agreement over what to do, and what > each > piece of the puzzle should do ( starter, ITs, feature model tooling, > kickstart, etc). > > I would like

[jira] [Created] (SLING-9499) Launchpad-Testing: branch which runs ITs against oak_tar feature model aggregate

2020-06-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9499: -- Summary: Launchpad-Testing: branch which runs ITs against oak_tar feature model aggregate Key: SLING-9499 URL: https://issues.apache.org/jira/browse/SLING-9499 Pr

[jira] [Created] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build

2020-06-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9498: -- Summary: Create feature model aggregates on the fly from the Sling Starter build Key: SLING-9498 URL: https://issues.apache.org/jira/browse/SLING-9498 Project: Sl

[jira] [Created] (SLING-9497) Announce + discuss intention to drop WAR file support to users

2020-06-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9497: -- Summary: Announce + discuss intention to drop WAR file support to users Key: SLING-9497 URL: https://issues.apache.org/jira/browse/SLING-9497 Project: Sling

[jira] [Reopened] (SLING-8350) Switch the Sling starter to the feature model

2020-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reopened SLING-8350: Assignee: Robert Munteanu (was: Andreas Schaefer) Reopening as per dev@sling discussion.

[jira] [Updated] (SLING-8350) Switch the Sling starter to the feature model

2020-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-8350: --- Fix Version/s: (was: Feature Model Sling Maven Kickstart Plugin 0.0.2)

[jira] [Commented] (SLING-6950) Support Content-Package based development

2020-06-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124297#comment-17124297 ] Robert Munteanu commented on SLING-6950: Yes, it would be nice to get SLING-6344.

[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] commented on pull request #10: SLING-9496 Dead code in the API Regions runtime

2020-06-02 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/10#issuecomment-637704927 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pu

[GitHub] [sling-org-apache-sling-feature-apiregions] bosschaert opened a new pull request #10: SLING-9496 Dead code in the API Regions runtime

2020-06-02 Thread GitBox
bosschaert opened a new pull request #10: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: Intra Sling Calls

2020-06-02 Thread Andreas Schaefer
Hi Carsten Not really an HTTP request but internally go through the HTTP stack. We are using these Intra Sling Calls for Image Rendering and to delegate Composum Package handling because we cannot use an OSGI services, or there is code executed before hitting an OSGi service. Cheers - Andy >

[jira] [Updated] (SLING-9496) Dead code in the API Regions runtime

2020-06-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9496: -- Fix Version/s: Feature Model API Regions Runtime Fragment 1.1.4 > Dead code in

[jira] [Updated] (SLING-9496) Dead code in the API Regions runtime

2020-06-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9496: -- Affects Version/s: Feature Model API Regions Runtime Fragment 1.1.2 > Dead code

[jira] [Updated] (SLING-9494) Always log which candidates where removed by the API Regions

2020-06-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9494: -- Component/s: Feature Model > Always log which candidates where removed by the A

[jira] [Updated] (SLING-9496) Dead code in the API Regions runtime

2020-06-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert updated SLING-9496: -- Component/s: Feature Model > Dead code in the API Regions runtime > ---

[jira] [Created] (SLING-9496) Dead code in the API Regions runtime

2020-06-02 Thread A. J. David Bosschaert (Jira)
A. J. David Bosschaert created SLING-9496: - Summary: Dead code in the API Regions runtime Key: SLING-9496 URL: https://issues.apache.org/jira/browse/SLING-9496 Project: Sling Issue Ty

Re: Intra Sling Calls

2020-06-02 Thread Andreas Schaefer
Hi Dirk First I do not like to use a “Mock” class for a in-production code. Second I cannot do multiparts forms in the Mock classes (getParts(), getPart() is throwing an Unsupported Operation Exception). - Andy > On Jun 2, 2020, at 12:14 AM, Dirk Rudolph wrote: > > The mock implementations i

[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] commented on pull request #9: SLING-9494 Always log which candidates where removed by the API Regions

2020-06-02 Thread GitBox
sonarcloud[bot] commented on pull request #9: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/9#issuecomment-637652865 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pull

[GitHub] [sling-org-apache-sling-feature-apiregions] bosschaert opened a new pull request #9: SLING-9494 Always log which candidates where removed by the API Regions

2020-06-02 Thread GitBox
bosschaert opened a new pull request #9: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Assigned] (SLING-9495) Distributed Event is sending package type as distribution type

2020-06-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph reassigned SLING-9495: --- Assignee: (was: Dirk Rudolph) > Distributed Event is sending package type as distributio

[jira] [Assigned] (SLING-9495) Distributed Event is sending package type as distribution type

2020-06-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph reassigned SLING-9495: --- Assignee: Dirk Rudolph > Distributed Event is sending package type as distribution type > --

[jira] [Created] (SLING-9495) Distributed Event is sending package type as distribution type

2020-06-02 Thread Dirk Rudolph (Jira)
Dirk Rudolph created SLING-9495: --- Summary: Distributed Event is sending package type as distribution type Key: SLING-9495 URL: https://issues.apache.org/jira/browse/SLING-9495 Project: Sling I

[jira] [Created] (SLING-9494) Always log which candidates where removed by the API Regions

2020-06-02 Thread A. J. David Bosschaert (Jira)
A. J. David Bosschaert created SLING-9494: - Summary: Always log which candidates where removed by the API Regions Key: SLING-9494 URL: https://issues.apache.org/jira/browse/SLING-9494 Project:

[jira] [Commented] (SLING-9479) GraphQL fetcher comments convert to headings in GraphiQL docs

2020-06-02 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123925#comment-17123925 ] Bertrand Delacretaz commented on SLING-9479: I have now added a [SchemaDescr

[GitHub] [sling-org-apache-sling-commons-log] cziegeler commented on a change in pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-06-02 Thread GitBox
cziegeler commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#discussion_r433934366 ## File path: src/main/java/org/apache/sling/commons/log/logback/internal/config/LoggerManagedServiceFactory.java ## @@ -20,17 +2

[jira] [Resolved] (SLING-9493) Upgrade to bnd 5.1.0

2020-06-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9493. Resolution: Fixed Fixed in  [https://github.com/apache/sling-parent/commit/133c73392e9575cb

[jira] [Created] (SLING-9493) Upgrade to bnd 5.1.0

2020-06-02 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-9493: -- Summary: Upgrade to bnd 5.1.0 Key: SLING-9493 URL: https://issues.apache.org/jira/browse/SLING-9493 Project: Sling Issue Type: Improvement Comp

[jira] [Commented] (SLING-9479) GraphQL fetcher comments convert to headings in GraphiQL docs

2020-06-02 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123795#comment-17123795 ] Bertrand Delacretaz commented on SLING-9479: BTW the field descriptions spec

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #825 is BROKEN

2020-06-02 Thread Apache Jenkins Server
/withMaven401384d7/maven-spy-20200602-133221-3013966626393373581502.log [Pipeline] } [withMaven] Publishers: Pipeline Graph Publisher: 5 ms, JGiven Publisher: 1 ms [Pipeline] // withMaven [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (SonarCloud) [Pipeline] withCredentials Masking

[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models

2020-06-02 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123707#comment-17123707 ] A. J. David Bosschaert commented on SLING-9489: --- Thank for the ideas, [~czi

[jira] [Commented] (SLING-9389) Distribution Event Packages should contain queue item creation time

2020-06-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123667#comment-17123667 ] Dirk Rudolph commented on SLING-9389: - Hey [~harshchiki], quick question: couldn't yo

[jira] [Commented] (SLING-9447) Add packageId property to distribution events

2020-06-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123638#comment-17123638 ] Dirk Rudolph commented on SLING-9447: - While we are adding properties to the distribu

[jira] [Created] (SLING-9492) Add deepPaths property to distribution events

2020-06-02 Thread Dirk Rudolph (Jira)
Dirk Rudolph created SLING-9492: --- Summary: Add deepPaths property to distribution events Key: SLING-9492 URL: https://issues.apache.org/jira/browse/SLING-9492 Project: Sling Issue Type: Improve

[jira] [Commented] (SLING-9447) Add packageId property to distribution events

2020-06-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123633#comment-17123633 ] Dirk Rudolph commented on SLING-9447: - Hi [~marett], [~cschneider], in the context of

[jira] [Commented] (SLING-9479) GraphQL fetcher comments convert to headings in GraphiQL docs

2020-06-02 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123629#comment-17123629 ] Bertrand Delacretaz commented on SLING-9479: I dug deeper into this and it lo

Re: Intra Sling Calls

2020-06-02 Thread Bertrand Delacretaz
Hi Andy, On Tue, Jun 2, 2020 at 6:10 AM Andreas Schaefer wrote: > ...So I am wondering if you guys would mind for me to build a service > providing the means to make > internal Sling calls through the HTTP stack with an official internal Sling > Request / Response object > that provides all fea

Re: Check if bundle resolves during build

2020-06-02 Thread Konrad Windszus
First step tracked in https://issues.apache.org/jira/browse/SLING-9491 . Unfortunately I hit a bug in the indexer plugin: https://github.com/bndtools/bnd/issues/4125 . Konrad > On 31. May 2020, at 16

Re: [VOTE] move o.a.s.graphql.samples.website to its own repo

2020-06-02 Thread Robert Munteanu
On Fri, 2020-05-29 at 18:59 +0200, Bertrand Delacretaz wrote: > On Fri, May 29, 2020 at 4:21 PM Bertrand Delacretaz > wrote: > > ...you're right that if my code > > has no need for a Jenkins build for example that's good enough... > > Turns out that a build is already setup for > https://github.c

Re: Check if bundle resolves during build

2020-06-02 Thread Robert Munteanu
On Sun, 2020-05-31 at 16:42 +0200, Konrad Windszus wrote: > Hi, > I recently integrated > https://github.com/bndtools/bnd/tree/master/maven/bnd-resolver-maven-plugin > in the FileVault plugin [1] and I would propose to do something > similar for Sling. > > That way incompatibilities of bundles wo

Re: Documentation for content-package based development

2020-06-02 Thread Robert Munteanu
Looks good, thanks! Robert On Sun, 2020-05-31 at 16:30 +0200, Konrad Windszus wrote: > I enriched a bit further with regards to OSGi installer support in > https://github.com/apache/sling-site/commit/b0951a5c2fb56b68d036d2e52a5adf488a19d8f0 > < > https://github.com/apache/sling-site/commit/b0951

Re: Intra Sling Calls

2020-06-02 Thread Dirk Rudolph
The mock implementations in o.a.s.servlet-helpers are actually quite complete for common use cases. What do you have in mind that might be missing? Kind regards, Dirk On Tue, 2 Jun 2020 at 08:58, Konrad Windszus wrote: > If you don’t have a request at hand it will be impossible to implement > f