Re: [security] new use case for a checkPermission API

2020-08-07 Thread Nicolas Peltier
here you are [3], it is not merged in as it still break some unit tests right now [3] https://github.com/npeltier/sling-org-apache-sling-pipes/commit/72d0c2bed3d7a7e31de6e4d6a90b815837ab0009#diff-3e9bcd2a44e6dc255a6d8c3cc17adddaR164-R171 Le ven. 7 août 2020 à 10:50, Nicolas Peltier a écrit : >

Re: Sling Starter switched to the Feature Model

2020-08-07 Thread Eric Norman
Hi Robert, I think I stumbled upon a regression with the changes done to the build of the org-apache-sling-launchpad-testing project. Specifically, if I combine the "eclipse:eclipse" goal with the "install" or "verify" goal in the same mvn command line, it results in an error about a duplicate

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670579047 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670478604 Kudos, SonarCloud Quality Gate passed!

[jira] [Created] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-07 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9648: -- Summary: SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided Key: SLING-9648 URL:

[jira] [Commented] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173215#comment-17173215 ] Robert Munteanu commented on SLING-9648: [~kwin] - is this maybe related to your recent work on

[jira] [Commented] (SLING-9634) Sling Dynamic Include not working with version 3.2.0

2020-08-07 Thread Geetika Chhabra (Jira)
[ https://issues.apache.org/jira/browse/SLING-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173214#comment-17173214 ] Geetika Chhabra commented on SLING-9634: Hi [~jfmitchell], Wondering if you got a chance to

[jira] [Commented] (SLING-9635) Create a kickstart jar during the Sling Starter build

2020-08-07 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173210#comment-17173210 ] Andreas Schaefer commented on SLING-9635: - The Kickstart Maven Plugin is OOTB just starting /

[jira] [Created] (SLING-9647) [Testing Clients] Store request and response on a ClientException

2020-08-07 Thread Andrei Dulvac (Jira)
Andrei Dulvac created SLING-9647: Summary: [Testing Clients] Store request and response on a ClientException Key: SLING-9647 URL: https://issues.apache.org/jira/browse/SLING-9647 Project: Sling

Re: Sling GraphQL

2020-08-07 Thread Andreea Miruna Moise
>3) Clients run such prepared queries by making GET requests to URLs like /graphqlservlet/prepared/cf81d4.json To be able to do this a different endpoint would be needed instead of org.apache.sling.graphql.core.servlet. GraphQLServlet right? >4) The responses to such prepared queries

Re: Sling GraphQL

2020-08-07 Thread Bertrand Delacretaz
Hi Andreea, On Fri, Aug 7, 2020 at 12:41 PM Andreea Miruna Moise wrote: > ...1. In case we provide hooks for SlingDataFetchers we will end up with > fine-grained cache hints... > But the major limitation is that this can be used only in case of GET > requests > ...2. Now if we think of

[jira] [Created] (SLING-9646) not able to exclude jsp in jspc-maven-plugin configuration

2020-08-07 Thread Pulkit Gupta (Jira)
Pulkit Gupta created SLING-9646: --- Summary: not able to exclude jsp in jspc-maven-plugin configuration Key: SLING-9646 URL: https://issues.apache.org/jira/browse/SLING-9646 Project: Sling Issue

[jira] [Commented] (SLING-9620) ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173123#comment-17173123 ] Robert Munteanu commented on SLING-9620: [~angela] - yes, I will definitely look the optimisation

[jira] [Resolved] (SLING-9628) Send log messages from subscriber to publisher

2020-08-07 Thread Christian Schneider (Jira)
[ https://issues.apache.org/jira/browse/SLING-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-9628. Resolution: Fixed > Send log messages from subscriber to publisher >

[jira] [Commented] (SLING-9620) ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173102#comment-17173102 ] Angela Schreiber commented on SLING-9620: - [~rombert], sure... i didn't invest a ton of time in

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread GitBox
rombert commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670480617 This still needs work, there are a number of failures in the Sling ITs ``` [ERROR] Tests run: 62, Failures: 9, Errors: 0, Skipped: 0, Time

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-670478604 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-resourceresolver] rombert opened a new pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread GitBox
rombert opened a new pull request #18: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (SLING-9620) ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173085#comment-17173085 ] Robert Munteanu commented on SLING-9620: [~angela] - thank your for the report and for the patch.

[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173073#comment-17173073 ] Robert Munteanu commented on SLING-9594: I am not too worried about overwhelming the new Jenkins

[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-07 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173067#comment-17173067 ] Konrad Windszus commented on SLING-9594: There is a hint in

Re: Sling GraphQL

2020-08-07 Thread Andreea Miruna Moise
Hi Bertrand, I'm mostly referring to server-side queries. Here are my thoughts: 1. In case we provide hooks for SlingDataFetchers we will end up with fine-grained cache hints (for eg

[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-07 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173052#comment-17173052 ] Bertrand Delacretaz commented on SLING-9594: If we take this

Re: [VOTE] Release Apache Sling JCR Base 3.1.4

2020-08-07 Thread Nicolas Peltier
+1 Le mer. 5 août 2020 à 12:20, Stefan Seifert a écrit : > +1 > > (sorry for the wrong mail von JCR base 3.1.2 - i validated 3.1.4) > > stefan > > >

[jira] [Commented] (SLING-9594) Move Sling builds to ci-builds.apache.org

2020-08-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173015#comment-17173015 ] Robert Munteanu commented on SLING-9594: The build was successful, including SNAPSHOT deployment

[jira] [Commented] (SLING-9556) add pipes execution through a simple text POST

2020-08-07 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173001#comment-17173001 ] Nicolas Peltier commented on SLING-9556: [~enorman] well yeah, this suppose that you authorize

[jira] [Comment Edited] (SLING-9556) add pipes execution through a simple text POST

2020-08-07 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173001#comment-17173001 ] Nicolas Peltier edited comment on SLING-9556 at 8/7/20, 8:56 AM: -

Re: [security] new use case for a checkPermission API

2020-08-07 Thread Nicolas Peltier
i was planning to make the API internal for 4.0, and use the outside one later, so no change to the API surface. Le ven. 7 août 2020 à 10:41, Oliver Lietz a écrit : > On Friday, August 7, 2020 9:15:10 AM CEST Bertrand Delacretaz wrote: > > On Fri, Aug 7, 2020 at 9:14 AM Nicolas Peltier > > > >

Re: [security] new use case for a checkPermission API

2020-08-07 Thread Oliver Lietz
On Friday, August 7, 2020 9:15:10 AM CEST Bertrand Delacretaz wrote: > On Fri, Aug 7, 2020 at 9:14 AM Nicolas Peltier > > wrote: > > ...Assuming we are good to go, should I use an internal API for now in > > pipes, and we discuss around moving it to a bundle later?... > > I think that's a good

Re: [security] new use case for a checkPermission API

2020-08-07 Thread Bertrand Delacretaz
On Fri, Aug 7, 2020 at 9:14 AM Nicolas Peltier wrote: > > ...Assuming we are good to go, should I use an internal API for now in pipes, > and we discuss around moving it to a bundle later?... I think that's a good starting point. -Bertrand

Re: [security] new use case for a checkPermission API

2020-08-07 Thread Nicolas Peltier
Assuming we are good to go, should I use an internal API for now in pipes, and we discuss around moving it to a bundle later? Nicolas On 06/08/2020 16:48, "Bertrand Delacretaz" wrote: Hi, On Thu, Aug 6, 2020 at 4:00 PM Nicolas Peltier wrote: > ...we have > if i count