paul-bjorkstrand commented on pull request #8:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/8#issuecomment-684127336
@raducotescu: https://issues.apache.org/jira/browse/SLING-9715
This is an
Paul Bjorkstrand created SLING-9715:
---
Summary: Sling models JavaUseProvider does not properly handle the
adaptable argument for Sling Model classes
Key: SLING-9715
URL:
you're right - the "@Inject @Source" pattern is the "old-style" syntax which we
still have to support for backwards compatibility but probably should
discourage in the docs and position the injector-specific annotations more
prominently, as they are the recommended way in my pov.
stefan
cmrockwell commented on pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/6#issuecomment-684011942
Is there a reason why this PR has not been merged?
This is an automated message
[
https://issues.apache.org/jira/browse/SLING-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187883#comment-17187883
]
Mohit Arora commented on SLING-9714:
[~kpauls], [~radu] As part of this fix, could you please also
[
https://issues.apache.org/jira/browse/SLING-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohit Arora updated SLING-9714:
---
Summary: ServletResourceProviderFactory should check for default
resourceSuperType to determine if
[
https://issues.apache.org/jira/browse/SLING-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohit Arora updated SLING-9714:
---
Description: After SLING-8170, ServletResourceProviderFactory checks only
for [non empty
[
https://issues.apache.org/jira/browse/SLING-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohit Arora updated SLING-9714:
---
Description: After SLING-8170,
> ServletResourceProviderFactory should process the resourceTypes
[
https://issues.apache.org/jira/browse/SLING-9714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohit Arora updated SLING-9714:
---
Affects Version/s: Servlets Resolver 2.7.8
> ServletResourceProviderFactory should process the
Mohit Arora created SLING-9714:
--
Summary: ServletResourceProviderFactory should process the
resourceTypes only if explicit resourceSuperType is provided in a servlet
Key: SLING-9714
URL:
sonarcloud[bot] edited a comment on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/2#issuecomment-683900153
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=2=false=BUG)
sonarcloud[bot] edited a comment on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/2#issuecomment-683900153
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=2=false=BUG)
sonarcloud[bot] commented on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/2#issuecomment-683900153
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=2=false=BUG)
raducotescu commented on pull request #8:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/8#issuecomment-683900253
@paul-bjorkstrand, can you please create a SLING issue and link the PR to
it? I'll have a look tomorrow, to make sure that the IT still passes.
raducotescu opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/2
* implemented support for persisted queries, by default under the
`/persisted` request suffix
* queries are cached in a size-bound in-memory LRU cache, which can be size
paul-bjorkstrand opened a new pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/8
When Sling Models instantiation was added in SLING-9320 ([commit][1]), it
did not treat the `adaptable` argument the same for all types of instantiations
(Sling
Hi,
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/
has been failing often lately, and IIUC it's timing out after 15
minutes.
I see at
On Mon, Aug 31, 2020 at 2:40 PM Robert Munteanu wrote:
> ...Regenerating existing ones is probably a
> large investment, but adding new diagrams should IMO use this kind of
> mechanism...
+1
Note that I was a bit optimistic about which diagram engines work out
of the box in a Maven build, IIUC
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187750#comment-17187750
]
Robert Munteanu commented on SLING-9707:
[~karlpauls] - right, {{sling.home}} and friends are a
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187742#comment-17187742
]
Karl Pauls commented on SLING-9707:
---
[~rombert], declaring it without a default (aka, null) should be
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187739#comment-17187739
]
Robert Munteanu commented on SLING-9707:
I see. That is a bit confusing, though. Would it work if
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187739#comment-17187739
]
Robert Munteanu edited comment on SLING-9707 at 8/31/20, 1:24 PM:
--
I
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187735#comment-17187735
]
Carsten Ziegeler commented on SLING-9707:
-
No, that only sets the value if a variable is used in
[
https://issues.apache.org/jira/browse/SLING-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187733#comment-17187733
]
Nicolas Peltier commented on SLING-9712:
thanks [~hwong] . I've allowed myself to change the
[
https://issues.apache.org/jira/browse/SLING-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-9712:
---
Summary: Move pipe should support relative path as expression (was: Move
pipe should
[
https://issues.apache.org/jira/browse/SLING-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-9712:
---
Description: The Move pipe should support relative paths as argument from
the expression.
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187728#comment-17187728
]
Robert Munteanu commented on SLING-9707:
Shouldn't it be automatically available because of
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187724#comment-17187724
]
Carsten Ziegeler commented on SLING-9707:
-
I think "sling.home" needs to be declared as a
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187720#comment-17187720
]
Robert Munteanu commented on SLING-9707:
[~cziegeler], [~karlpauls], [~davidb] - my understanding
[
https://issues.apache.org/jira/browse/SLING-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-9707:
---
Summary: Variable ${sling.home} not replaced in configuration values (was:
Variable
Hi Bertrand,
On Mon, 2020-08-31 at 12:46 +0200, Bertrand Delacretaz wrote:
> Hi,
>
> FYI I have added a sample at
> https://github.com/apache/sling-whiteboard/tree/master/asciidoctor-diagrams
> of how to generate diagrams for our README and other documentation
> files using
[
https://issues.apache.org/jira/browse/SLING-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187687#comment-17187687
]
Robert Munteanu commented on SLING-9713:
[~olli] - we don't have an {{asf.yaml}} file in that
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/69/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 1523 lines...]
[INFO] Running
[
https://issues.apache.org/jira/browse/SLING-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187656#comment-17187656
]
Oliver Lietz commented on SLING-9713:
-
[~rombert], Can you please have a look?
> invalid syntax in
Oliver Lietz created SLING-9713:
---
Summary: invalid syntax in 15-asf-yaml.py
Key: SLING-9713
URL: https://issues.apache.org/jira/browse/SLING-9713
Project: Sling
Issue Type: Bug
i guess doc is a bit misleading here and we should not expose what you
righteously call "implementation details" in the documentation (see
"script-bindings" in
https://sling.apache.org/documentation/bundles/models.html)
Le lun. 31 août 2020 à 12:34, Nicolas Peltier a
écrit :
> mm i thought some
Hi,
FYI I have added a sample at
https://github.com/apache/sling-whiteboard/tree/master/asciidoctor-diagrams
of how to generate diagrams for our README and other documentation
files using https://asciidoctor.org/docs/asciidoctor-diagram/
That tool supports a large number of diagram syntaxes
mm i thought some of them were only available through the @Source
annotation, but i will work my models annotations a bit more :-)
Le lun. 31 août 2020 à 12:10, Stefan Seifert a
écrit :
> these string constants are normally not used in application code, because
> they use the typed injector
Honwai Wong created SLING-9712:
--
Summary: Move pipe should support relative path as input
Key: SLING-9712
URL: https://issues.apache.org/jira/browse/SLING-9712
Project: Sling
Issue Type:
these string constants are normally not used in application code, because they
use the typed injector annotations.
so this is more an implementation detail and there is no need to publish those
constants as part of the API?
stefan
>-Original Message-
>From: Nicolas Peltier
>Sent:
Hey
all injectors have name declared as direct string constants in getName
implementations (script-bindings, child-resources, self, ...)
not entirely sure it's still best practice to use constants rather than
literals in annotation, but if it's still the case, i guess declaring &
exposing those
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/68/
for details.
No further emails will be sent until the status of the build is changed.
42 matches
Mail list logo
