[GitHub] [sling-tooling-jenkins] kwin commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-20 Thread GitBox
kwin commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695937689 I would like to decouple parent from a specific CI (like Jenkins). That profile id can also be easily set with Github Actions, Travis CI, ... and whatever we may use in t

[jira] [Commented] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

2020-09-20 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199197#comment-17199197 ] Robert Munteanu commented on SLING-9735: This is a great improvement, thanks [~en

[GitHub] [sling-tooling-jenkins] rombert commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-20 Thread GitBox
rombert commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695929929 @kwin - wouldn't it be more obvious is the profile would be activated thorugh the parent pom by looking at an env variable that we know is always defined on Jenkins?

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-20 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199095#comment-17199095 ] Henry Kuijpers commented on SLING-2938: --- Added the annotations here:  [https://gith

[jira] [Commented] (SLING-9742) CLONE - DistributionPublisher does not validate queue names

2020-09-20 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199087#comment-17199087 ] Timothee Maret commented on SLING-9742: --- [~dsuess] could you describe how to reprod

Re: [DISCUSS] Resource Mapping SPI

2020-09-20 Thread Georg Henzler
Considering that URIs like 'mailto:j...@example.com', '?name=val' or '#fragment' do not relate to a resource and thinking about it a bit more, I would now propose to change the name of ResourceUri/ResourceUriBuilder to SlingUri/SlingUriBuilder (see also [1]) - objections? -Georg [1] https://git

[GitHub] [sling-org-apache-sling-api] ghenzler commented on a change in pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-20 Thread GitBox
ghenzler commented on a change in pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#discussion_r491726353 ## File path: src/main/java/org/apache/sling/api/resource/uri/ResourceUri.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-20 Thread GitBox
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-695826452 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=23&resolved=false&ty

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-20 Thread GitBox
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-694838914 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api&pullRequest=23&resolved=

[jira] [Resolved] (SLING-9751) Command execution should be possible on several lines

2020-09-20 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-9751. Fix Version/s: Pipes 4.0.0 Assignee: Nicolas Peltier Resolution: Fixed > Co

[jira] [Updated] (SLING-9751) Command execution should be possible on several lines

2020-09-20 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9751: --- Description: for big pipes sent on command files, we might want to have it spread on multipl

[jira] [Created] (SLING-9751) Command execution should be possible on several lines

2020-09-20 Thread Nicolas Peltier (Jira)
Nicolas Peltier created SLING-9751: -- Summary: Command execution should be possible on several lines Key: SLING-9751 URL: https://issues.apache.org/jira/browse/SLING-9751 Project: Sling Issue