[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-04-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-814497153 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-04-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-815309693 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://

[jira] [Updated] (SLING-10193) SAML Auth Handler Initial Release

2021-04-07 Thread Cris Rockwell (Jira)
[ https://issues.apache.org/jira/browse/SLING-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cris Rockwell updated SLING-10193: -- Description: Tasks for initial release [done] Test Coverage >80% [done] JAAS configuration pr

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-07 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815078938 Thx @kwin for the review, will have a look! Re the flaky tests : it looks to me as if that is due to `AbstractJobHandlingTest.waitConsumerChangeCount

[jira] [Commented] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-07 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316497#comment-17316497 ] Joerg Hoh commented on SLING-8759: -- Anyway, using {{computeIfAbsent}} makes sense anyway

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-07 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815059476 or .. : ``` [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.681 s <<< FAILURE! - in org.apache.sling.event.it.Classloading

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-07 Thread GitBox
kwin commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r608816926 ## File path: pom.xml ## @@ -57,39 +57,98 @@ -org.apache.felix -maven-bundle-

[jira] [Commented] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316455#comment-17316455 ] Angela Schreiber commented on SLING-10277: -- [~bdelacretaz], initial WIP at htt

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-07 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815033401 eg : ```[ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 137.763 s <<< FAILURE! - in org.apache.sling.event.it.JobHandlingTest

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-07 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815022868 With [this commit](https://github.com/apache/sling-org-apache-sling-event/pull/10/commits/4a536c9a282871c2bbe015c9b4cd6daf5eeb0077) based on @joerghoh 's [

[jira] [Comment Edited] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-07 Thread Stefan Bischof (Jira)
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770 ] Stefan Bischof edited comment on SLING-10229 at 4/7/21, 3:35 PM: -

[jira] [Assigned] (SLING-10274) Consistently use platform independent line separator

2021-04-07 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-10274: -- Assignee: Karl Pauls > Consistently use platform independent line separator > ---

[jira] [Updated] (SLING-10274) Consistently use platform independent line separator

2021-04-07 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10274: --- Fix Version/s: Content-Package to Feature Model Converter 1.0.26 > Consistently use platform indepen

[jira] [Resolved] (SLING-10274) Consistently use platform independent line separator

2021-04-07 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-10274. Resolution: Fixed [~cziegeler], that is a good question - however, I think it doesn't have to be

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls merged pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
anchela commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608639067 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,5

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-07 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-814905186 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-812123958 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
anchela commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608635199 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,5

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814893126 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814891257 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814891257 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814823622 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpco

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608625482 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,

[jira] [Updated] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10277: - Description: [~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in

[jira] [Updated] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10277: - Description: [~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in

[jira] [Updated] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10277: - Description: [~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in

[jira] [Updated] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10277: - Attachment: SLING-10277.patch > Privilege aggregates cannot have namespaced name but AC-

[jira] [Updated] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10277: - Description: [~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in

[jira] [Created] (SLING-10277) Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names

2021-04-07 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10277: Summary: Privilege aggregates cannot have namespaced name but AC-Lines require namespaced privilege names Key: SLING-10277 URL: https://issues.apache.org/jira/browse/SLING

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
anchela commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608593275 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,5

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
anchela commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608590392 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,5

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #416 is FIXED

2021-04-07 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/416/ for details. No further emails will be sent until the status of the build is changed.

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #415 is BROKEN

2021-04-07 Thread Apache Jenkins Server
Default locale: en_US, platform encoding: ISO-8859-1 OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix" [INFO] [jenkins-event-spy] Generate /home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven9784f60a/m

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls commented on a change in pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364 ## File path: src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml ## @@ -17,

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814823622 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[jira] [Commented] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316221#comment-17316221 ] Robert Munteanu commented on SLING-10276: - Good point, thanks. > javadoc: add s

[jira] [Updated] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10276: Fix Version/s: (was: Resource Resolver 1.7.4) API 2.23.4 > javadoc:

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #69: SLING-10274: use the repoinit parser to normalize line separators

2021-04-07 Thread GitBox
karlpauls opened a new pull request #69: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316202#comment-17316202 ] Joerg Hoh commented on SLING-10276: --- Shouldn't the fix version a release of the Sling

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #68: SLING-10268 : Use Operation.asRepoInitString instead of hardcoding repo-init statements

2021-04-07 Thread GitBox
anchela commented on pull request #68: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/68#issuecomment-814732569 @karlpauls , merge as discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (SLING-10268) Use Operation.asRepoInitString instead of hardcoding repo-init statements

2021-04-07 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-10268. -- Fix Version/s: Content-Package to Feature Model Converter 1.0.26 Resolution: Fix

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #68: SLING-10268 : Use Operation.asRepoInitString instead of hardcoding repo-init statements

2021-04-07 Thread GitBox
anchela merged pull request #68: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[jira] [Created] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-10276: - Summary: javadoc: add statement about modifications outside of Sling resource API Key: SLING-10276 URL: https://issues.apache.org/jira/browse/SLING-10276 Project: Sling

[jira] [Comment Edited] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-07 Thread Stefan Bischof (Jira)
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770 ] Stefan Bischof edited comment on SLING-10229 at 4/7/21, 8:07 AM: -

[jira] [Updated] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10276: Fix Version/s: Resource Resolver 1.7.4 > javadoc: add statement about modifications outsid

[jira] [Commented] (SLING-10276) javadoc: add statement about modifications outside of Sling resource API

2021-04-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316093#comment-17316093 ] Robert Munteanu commented on SLING-10276: - Tentatively adding fix version so thi

[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #43: SLING-10269 cache the result of isResourceType()

2021-04-07 Thread GitBox
joerghoh merged pull request #43: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[jira] [Commented] (SLING-10269) cache results of isResourceType()

2021-04-07 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316092#comment-17316092 ] Joerg Hoh commented on SLING-10269: --- [~rombert]: Yes, this chance existed already befo

[jira] [Commented] (SLING-10269) cache results of isResourceType()

2021-04-07 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316070#comment-17316070 ] Robert Munteanu commented on SLING-10269: - [~joerghoh] - IIUC you're saying that