sonarcloud[bot] removed a comment on pull request #69:
URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-814497153
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG)
[](
sonarcloud[bot] commented on pull request #69:
URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-815309693
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG)
[](https://
[
https://issues.apache.org/jira/browse/SLING-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cris Rockwell updated SLING-10193:
--
Description:
Tasks for initial release
[done] Test Coverage >80%
[done] JAAS configuration pr
stefan-egli commented on pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815078938
Thx @kwin for the review, will have a look!
Re the flaky tests : it looks to me as if that is due to
`AbstractJobHandlingTest.waitConsumerChangeCount
[
https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316497#comment-17316497
]
Joerg Hoh commented on SLING-8759:
--
Anyway, using {{computeIfAbsent}} makes sense anyway
stefan-egli commented on pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815059476
or .. :
```
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
31.681 s <<< FAILURE! - in org.apache.sling.event.it.Classloading
kwin commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r608816926
##
File path: pom.xml
##
@@ -57,39 +57,98 @@
-org.apache.felix
-maven-bundle-
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316455#comment-17316455
]
Angela Schreiber commented on SLING-10277:
--
[~bdelacretaz], initial WIP at
htt
stefan-egli commented on pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815033401
eg :
```[ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
137.763 s <<< FAILURE! - in org.apache.sling.event.it.JobHandlingTest
stefan-egli commented on pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-815022868
With [this
commit](https://github.com/apache/sling-org-apache-sling-event/pull/10/commits/4a536c9a282871c2bbe015c9b4cd6daf5eeb0077)
based on @joerghoh 's [
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770
]
Stefan Bischof edited comment on SLING-10229 at 4/7/21, 3:35 PM:
-
[
https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls reassigned SLING-10274:
--
Assignee: Karl Pauls
> Consistently use platform independent line separator
> ---
[
https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10274:
---
Fix Version/s: Content-Package to Feature Model Converter 1.0.26
> Consistently use platform indepen
[
https://issues.apache.org/jira/browse/SLING-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-10274.
Resolution: Fixed
[~cziegeler], that is a good question - however, I think it doesn't have to be
karlpauls merged pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
anchela commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608639067
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,5
sonarcloud[bot] commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-814905186
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7
sonarcloud[bot] removed a comment on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-812123958
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR
anchela commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608635199
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,5
sonarcloud[bot] commented on pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814893126
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&
sonarcloud[bot] removed a comment on pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814891257
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter
sonarcloud[bot] commented on pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814891257
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq
sonarcloud[bot] removed a comment on pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814823622
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpco
karlpauls commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608625482
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10277:
-
Description:
[~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10277:
-
Description:
[~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10277:
-
Description:
[~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10277:
-
Attachment: SLING-10277.patch
> Privilege aggregates cannot have namespaced name but AC-
[
https://issues.apache.org/jira/browse/SLING-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10277:
-
Description:
[~bdelacretaz], while working on SLING-10274 [~kpauls] noticed that repo-in
Angela Schreiber created SLING-10277:
Summary: Privilege aggregates cannot have namespaced name but
AC-Lines require namespaced privilege names
Key: SLING-10277
URL: https://issues.apache.org/jira/browse/SLING
anchela commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608593275
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,5
anchela commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608590392
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,5
karlpauls commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/416/
for details.
No further emails will be sent until the status of the build is changed.
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven9784f60a/m
karlpauls commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,
karlpauls commented on a change in pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#discussion_r608557364
##
File path:
src/test/resources/org/apache/sling/feature/cpconverter/handlers/META-INF/vault/privileges.xml
##
@@ -17,
sonarcloud[bot] commented on pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69#issuecomment-814823622
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&
[
https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316221#comment-17316221
]
Robert Munteanu commented on SLING-10276:
-
Good point, thanks.
> javadoc: add s
[
https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10276:
Fix Version/s: (was: Resource Resolver 1.7.4)
API 2.23.4
> javadoc:
karlpauls opened a new pull request #69:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316202#comment-17316202
]
Joerg Hoh commented on SLING-10276:
---
Shouldn't the fix version a release of the Sling
anchela commented on pull request #68:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/68#issuecomment-814732569
@karlpauls , merge as discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/SLING-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-10268.
--
Fix Version/s: Content-Package to Feature Model Converter 1.0.26
Resolution: Fix
anchela merged pull request #68:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
Joerg Hoh created SLING-10276:
-
Summary: javadoc: add statement about modifications outside of
Sling resource API
Key: SLING-10276
URL: https://issues.apache.org/jira/browse/SLING-10276
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770
]
Stefan Bischof edited comment on SLING-10229 at 4/7/21, 8:07 AM:
-
[
https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-10276:
Fix Version/s: Resource Resolver 1.7.4
> javadoc: add statement about modifications outsid
[
https://issues.apache.org/jira/browse/SLING-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316093#comment-17316093
]
Robert Munteanu commented on SLING-10276:
-
Tentatively adding fix version so thi
joerghoh merged pull request #43:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queri
[
https://issues.apache.org/jira/browse/SLING-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316092#comment-17316092
]
Joerg Hoh commented on SLING-10269:
---
[~rombert]: Yes, this chance existed already befo
[
https://issues.apache.org/jira/browse/SLING-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316070#comment-17316070
]
Robert Munteanu commented on SLING-10269:
-
[~joerghoh] - IIUC you're saying that
52 matches
Mail list logo