Re: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-12 Thread Henry Saginor
+1 (non-binding) > On Apr 12, 2021, at 3:52 PM, Andreas Schaefer > wrote: > > +1 (non-binding) > > - Andy > >> On Apr 9, 2021, at 9:12 AM, Cris Rockwell wrote: >> >> We solved 4 issues in sling-org-apache-sling-junit-core 1.1.2 >>

Re: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-12 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Apr 9, 2021, at 9:12 AM, Cris Rockwell wrote: > > We solved 4 issues in sling-org-apache-sling-junit-core 1.1.2 > https://issues.apache.org/jira/projects/SLING/versions/12349294 > > > Staging

Re: [VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-12 Thread Henry Saginor
+1 > On Apr 12, 2021, at 1:22 PM, Stefan Seifert > wrote: > > Hi, > > Resource Resolver 1.7.4 (3 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12349581 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2428/ > > You can use

RE: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-12 Thread Stefan Seifert
the dependencies defined for the project are inconsistent - as reported by maven: [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.sling:org.apache.sling.serviceusermapper:jar -> version 1.2.0 vs 1.4.6 @ line 357, column 21 [WARNING]

RE: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-12 Thread Stefan Seifert
+1

Re: [git] New git repository - org-apache-sling-auth-saml2

2021-04-12 Thread Cris Rockwell
Hi Robert The whiteboard PR is merged. Let me know if you have other questions about creating the repository. Thanks Cris > On Apr 8, 2021, at 12:14 PM, Cris Rockwell wrote: > > Hi, > > Currently org-apache-sling-auth-saml2 build runs about 65 seconds on my local > workstation, > and

RE: [VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-12 Thread Stefan Seifert
+1

[VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-12 Thread Stefan Seifert
Hi, Resource Resolver 1.7.4 (3 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12349581 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2428/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-10296) ResourceResolver: Update to Parent 41

2021-04-12 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-10296. Resolution: Fixed

[jira] [Created] (SLING-10296) ResourceResolver: Update to Parent 41

2021-04-12 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-10296: -- Summary: ResourceResolver: Update to Parent 41 Key: SLING-10296 URL: https://issues.apache.org/jira/browse/SLING-10296 Project: Sling Issue Type:

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5#issuecomment-817993597 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-get=5=false=BUG)

[jira] [Updated] (SLING-10295) Unclosed inpustreams with DefaultGetServlet

2021-04-12 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10295: -- Description: The DefaultGetServlet has codepaths with unclosed inputstreams. See

[jira] [Assigned] (SLING-10295) Unclosed inpustreams with DefaultGetServlet

2021-04-12 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-10295: - Assignee: Joerg Hoh > Unclosed inpustreams with DefaultGetServlet >

[jira] [Updated] (SLING-10295) Unclosed inpustreams with DefaultGetServlet

2021-04-12 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10295: -- Fix Version/s: Servlets Get 2.1.42 > Unclosed inpustreams with DefaultGetServlet >

[GitHub] [sling-org-apache-sling-servlets-get] joerghoh opened a new pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-12 Thread GitBox
joerghoh opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5 Switch to try-with-resource and fix a few cases where an InputStream was not properly closed. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (SLING-10295) Unclosed inpustreams with DefaultGetServlet

2021-04-12 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-10295: - Summary: Unclosed inpustreams with DefaultGetServlet Key: SLING-10295 URL: https://issues.apache.org/jira/browse/SLING-10295 Project: Sling Issue Type: Bug

[jira] [Assigned] (SLING-10243) Extract Sling-Initial-Content from bundles and put into dedicated packages

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10243: --- Assignee: Konrad Windszus > Extract Sling-Initial-Content from bundles and put

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #72: SLING-10278 allow configurations below "install" and bundles below

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #72: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-817970182 SonarCloud Quality Gate failed.

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319584#comment-17319584 ] Konrad Windszus commented on SLING-10278: - OK, I changed the PR at

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #72: SLING-10278 allow configurations below "install" and bundles below

2021-04-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #72: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-817705914 Kudos, SonarCloud Quality Gate passed!

Re: Release of Servlets Resolver and Scripting bundles

2021-04-12 Thread Radu Cotescu
Hi Julian, The reason for pushing back on this is that ResourceType [1] is more of a utility class, rather than an API one. It’s a final class, used to: Generate require and provide capabilities with the help of the scriptingbundle-maven-plugin Set up the servlets for each provided capability

Re: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-12 Thread Robert Munteanu
On Mon, 2021-04-12 at 17:26 +0200, Stefan Egli wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: Issue with form based authentication

2021-04-12 Thread Carsten Ziegeler
I already answered in the same direction over a week ago on one of the first messages: Hi, I might be wrong, but I think the problem is that as soon as you configure the forms based auth handler, you don't have a handler for other paths like /system/console. Your logs show this statement

Re: Issue with form based authentication

2021-04-12 Thread Cris Rockwell
Hi Juerg Regarding the first error, if the following occurred 1. you signed into Sling using the login page (/system/sling/login.html) 2. you changed the `path` property for org.apache.sling.auth.form.FormAuthenticationHandler from '/' to ‘/content/a/b' Then, perhaps auth access and errors

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319514#comment-17319514 ] Carsten Ziegeler commented on SLING-10278: -- A filevault validator definitely makes sense -

Re: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-12 Thread Carsten Ziegeler
+1 Carsten Am 12.04.2021 um 17:26 schrieb Stefan Egli: Hi, We solved 3 issues in this release which includes cancelled 4.2.14: * 1 issue in 4.2.16 :  https://issues.apache.org/jira/projects/SLING/versions/12349657 * 2 issues in cancelled 4.2.14:  

[VOTE] Release Apache Sling Event Support 4.2.16

2021-04-12 Thread Stefan Egli
Hi, We solved 3 issues in this release which includes cancelled 4.2.14: * 1 issue in 4.2.16 : https://issues.apache.org/jira/projects/SLING/versions/12349657 * 2 issues in cancelled 4.2.14: https://issues.apache.org/jira/projects/SLING/versions/12344827 Staging repository:

[jira] [Updated] (SLING-9905) Provide option to include sling instance id nodes in cleanup

2021-04-12 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9905: --- Fix Version/s: (was: Event 4.2.16) Event 4.2.18 > Provide option to include

[jira] [Updated] (SLING-8295) Enable CodeCoverage extraction form pax exam ITs in sling.event

2021-04-12 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-8295: --- Fix Version/s: (was: Event 4.2.16) Event 4.2.18 > Enable CodeCoverage

Re: Release of Servlets Resolver and Scripting bundles

2021-04-12 Thread Julian Sedding
Hi * I agree with Olli that moving ResourceType later will not happen, because it causes too much disruption. I also agree that it is generally useful and not inherently linked to scripting. Why can't we just move it now, before we make our lives harder? If o.a.s.scripting.spi should not depend

[jira] [Resolved] (SLING-10120) Upgrade event to parent 41 [was: Upgrade event to parent 40]

2021-04-12 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-10120. - Resolution: Fixed * while originally aiming for parent 40 it became parent 41 in the end *

[GitHub] [sling-org-apache-sling-event] stefan-egli merged pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli merged pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] removed a comment on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817831030 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817861955 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[jira] [Updated] (SLING-10120) Upgrade event to parent 41 [was: Upgrade event to parent 40]

2021-04-12 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10120: Summary: Upgrade event to parent 41 [was: Upgrade event to parent 40] (was: Upgrade event to

Issue with form based authentication

2021-04-12 Thread JCR
Hello, I post this issue here because I have not got any answer on the user's list. The thread comprises of two messages, whereas the second details the error from error.log. I use Sling 11 and Java 11. Thanks, Juerg Meier *** On 12.03.21 12:30, JCR

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817831030 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] removed a comment on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817814652 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-817823231 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include=19=false=BUG)

[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-04-12 Thread GitBox
santiagozky commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-817822320 Sorry for the delay @rombert. I was too busy and this feltout of priority for me. I've added the built-in generators inthe configuration label

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] removed a comment on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817784989 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817814652 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817813459 thx, fixed more indentation mistakes now, so she'll be alright mate -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817806477 we're getting there ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-12 Thread Daniel Klco
+1 On Fri, Apr 9, 2021 at 12:13 PM Cris Rockwell wrote: > We solved 4 issues in sling-org-apache-sling-junit-core 1.1.2 > https://issues.apache.org/jira/projects/SLING/versions/12349294 < > https://issues.apache.org/jira/projects/SLING/versions/12349294> > > Staging repository: >

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611621698 ## File path: bnd.bnd ## @@ -0,0 +1,29 @@ +-noextraheader:true Review comment: +1, done now -- This is an automated

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611617386 ## File path: pom.xml ## @@ -374,22 +353,55 @@ org.apache.sling.event.api 1.0.0 + +

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
kwin commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611614032 ## File path: bnd.bnd ## @@ -0,0 +1,29 @@ +-noextraheader:true Review comment: no need to overwrite the default config:

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
kwin commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611612985 ## File path: pom.xml ## @@ -374,22 +353,55 @@ org.apache.sling.event.api 1.0.0 + + +

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817791222 @kwin I hope all comments are addressed, please double-check -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611606149 ## File path: pom.xml ## @@ -57,39 +57,98 @@ -org.apache.felix -

[jira] [Created] (SLING-10294) Committer CLI - Return Codes

2021-04-12 Thread Dan Klco (Jira)
Dan Klco created SLING-10294: Summary: Committer CLI - Return Codes Key: SLING-10294 URL: https://issues.apache.org/jira/browse/SLING-10294 Project: Sling Issue Type: Improvement

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-817784989 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] removed a comment on pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#issuecomment-816794564 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=10=false=BUG)

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611575708 ## File path: pom.xml ## @@ -57,39 +57,98 @@ -org.apache.felix -

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611574291 ## File path: pom.xml ## @@ -57,39 +57,98 @@ -org.apache.felix -

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
stefan-egli commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611574675 ## File path: pom.xml ## @@ -51,56 +51,12 @@ ${bundle.build.dir}/${project.build.finalName}.jar 37000

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #10: SLING-10120 : switch to parent 40

2021-04-12 Thread GitBox
kwin commented on a change in pull request #10: URL: https://github.com/apache/sling-org-apache-sling-event/pull/10#discussion_r611570482 ## File path: pom.xml ## @@ -51,56 +51,12 @@ ${bundle.build.dir}/${project.build.finalName}.jar 37000 37999 +

Re: Stage Release Apache Sling JUnit Core 1.1.2 and voting

2021-04-12 Thread Cris Rockwell
Hey Robert Yes. Radu solved my credentials issue. I was able to stage the release. Thanks checking up on this. Cris On Mon, Apr 12, 2021, 6:33 AM Robert Munteanu wrote: > Hi Cris, > > On Fri, 2021-04-09 at 10:04 -0400, Cris Rockwell wrote: > > $mvn release:prepare > > ... > > > > [INFO] Working

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319401#comment-17319401 ] Konrad Windszus commented on SLING-10278: - Right, indeed. What do you think of providing a

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin edited a comment on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817738628 > but to write the content package no matter what seems unnecessary. I still fail to see use cases, where the transformed content

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin edited a comment on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817738628 > but to write the content package no matter what seems unnecessary. I still fail to see use cases, where the transformed content

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817738628 > but to write the content package no matter what seems unnecessary. I still fail to see use cases, where the transformed content package is not

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319395#comment-17319395 ] Carsten Ziegeler commented on SLING-10278: -- But how does the analyser know where bundles or

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319392#comment-17319392 ] Konrad Windszus commented on SLING-10278: - Failing after the conversion is good enough to

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817736465 @kwin, right, sorry - anyways, I think it makes sense to make the drop content selectable but to write the content package no matter what seems

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319391#comment-17319391 ] Carsten Ziegeler commented on SLING-10278: -- In general, yes, but that would require to run

[jira] [Resolved] (SLING-10279) Unify naming: cp2fm or cp2sf

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10279. - Resolution: Fixed Fixed in

[jira] [Comment Edited] (SLING-10279) Unify naming: cp2fm or cp2sf

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319387#comment-17319387 ] Konrad Windszus edited comment on SLING-10279 at 4/12/21, 11:29 AM:

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin merged pull request #71: rename cp2sf to cp2fm

2021-04-12 Thread GitBox
kwin merged pull request #71: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319372#comment-17319372 ] Carsten Ziegeler commented on SLING-10278: -- Enforcing is right now done by silently ignoring :)

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319380#comment-17319380 ] Konrad Windszus commented on SLING-10278: - IMHO enforcing best practices should be done in a

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319368#comment-17319368 ] Konrad Windszus commented on SLING-10278: - I am open for enforcing best practices, but enforcing

[jira] [Commented] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319364#comment-17319364 ] Carsten Ziegeler commented on SLING-10278: -- It would be good if this is configurable - while

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin edited a comment on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817707012 @karlpauls I asked in

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817707012 @karlpauls I asked in

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #72: SLING-10278 allow configurations below "install" and bundles below

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #72: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72#issuecomment-817705914 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817705532 @kwin - I'm not sure we should do this change without providing for an option to not write out the artifact. Could we maybe have that cli

Re: Stage Release Apache Sling JUnit Core 1.1.2 and voting

2021-04-12 Thread Robert Munteanu
Hi Cris, On Fri, 2021-04-09 at 10:04 -0400, Cris Rockwell wrote: > $mvn release:prepare > ... > > [INFO] Working directory: > /Users/cmrockwe/Documents/a3workspace/sling-org-apache-sling-junit- > core > Username for 'https://gitbox.apache.org': cris > Password for

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #71: rename cp2sf to cp2fm

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #71: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/71#issuecomment-817694662 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #72: SLING-10278 allow configurations below "install" and bundles below

2021-04-12 Thread GitBox
kwin opened a new pull request #72: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/72 "config" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
sonarcloud[bot] commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-817685935 SonarCloud Quality Gate failed.

[jira] [Assigned] (SLING-10278) Treat install and config folders the same

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10278: --- Assignee: Konrad Windszus > Treat install and config folders the same >

[jira] [Assigned] (SLING-10279) Unify naming: cp2fm or cp2sf

2021-04-12 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10279: --- Assignee: Konrad Windszus > Unify naming: cp2fm or cp2sf >

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #71: rename cp2sf to cp2fm

2021-04-12 Thread GitBox
kwin opened a new pull request #71: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-12 Thread GitBox
kwin opened a new pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70 expose "dropContent" as CLI option improve readme -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[CANCELLED][VOTE] Release Apache Sling Scripting SPI 1.0.0

2021-04-12 Thread Radu Cotescu
Hi, > On 10 Apr 2021, at 13:43, Oliver Lietz wrote: > > On Thursday, 8 April 2021 20:09:30 CEST Radu Cotescu wrote: >> Hi, >> >> We solved 2 issues in this release: >> https://issues.apache.org/jira/browse/SLING/fixforversion/12349958 >> >> Staging repository: >>

[jira] [Updated] (SLING-9673) Expose authentication handler class name in "slingauth" web console

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-9673: Fix Version/s: (was: Auth Core 1.5.2) > Expose authentication handler class name in

[jira] [Resolved] (SLING-10293) Sudo cookie - set httpOnly and secure

2021-04-12 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10293. -- Resolution: Fixed Always set httpOnly and set secure if the current request is

[jira] [Created] (SLING-10293) Sudo cookie - set httpOnly and secure

2021-04-12 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-10293: Summary: Sudo cookie - set httpOnly and secure Key: SLING-10293 URL: https://issues.apache.org/jira/browse/SLING-10293 Project: Sling Issue Type: