[GitHub] [sling-org-apache-sling-feature] kwin commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

kwin commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646289119 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /** * Shu

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

cziegeler commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646272303 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /**

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on pull request #26: SLING-10458 use NIO files

cziegeler commented on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#issuecomment-855577209 Lgtm, thanks. @karlpauls WDYT - is this still working with url handling for artifacts? -- This is an automated message from the Apache Git Service. To re

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] removed a comment on pull request #26: SLING-10458 use NIO files

sonarcloud[bot] removed a comment on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#issuecomment-855415148 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=26&resolved

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #26: SLING-10458 use NIO files

sonarcloud[bot] commented on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#issuecomment-855446750 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=26&resolved=false&t

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358204#comment-17358204 ] Konrad Windszus commented on SLING-10451: - Fixed in  https://github.com/apache/s

[jira] [Assigned] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-10451: --- Assignee: Konrad Windszus > ArtifactManagerConfig leaves empty "slingfeature" folde

[GitHub] [sling-org-apache-sling-feature] kwin merged pull request #24: SLING-10451 cleanup cache directory

kwin merged pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] removed a comment on pull request #24: SLING-10451 cleanup cache directory

sonarcloud[bot] removed a comment on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/24#issuecomment-854518693 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=24&resolved

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #24: SLING-10451 cleanup cache directory

sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/24#issuecomment-855416979 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=24&resolved=false&t

[GitHub] [sling-org-apache-sling-feature] kwin commented on pull request #24: SLING-10451 cleanup cache directory

kwin commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/24#issuecomment-855416799 Fixed in https://github.com/apache/sling-org-apache-sling-feature/pull/24/commits/7f45b1fde219f10ce2237e106d9eb99d6aa4bc7c as proposed in https://issues.apach

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] removed a comment on pull request #26: SLING-10458 use NIO files

sonarcloud[bot] removed a comment on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#issuecomment-854613597 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=26&resolved

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #26: SLING-10458 use NIO files

sonarcloud[bot] commented on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#issuecomment-855415148 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=26&resolved=false&t

[GitHub] [sling-org-apache-sling-feature] kwin commented on a change in pull request #26: SLING-10458 use NIO files

kwin commented on a change in pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#discussion_r646146722 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/ArtifactHandler.java ## @@ -46,11 +47,24 @@ public ArtifactHandler(fin

[GitHub] [sling-org-apache-sling-feature] kwin commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

kwin commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646146539 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /** * Shu

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358112#comment-17358112 ] Carsten Ziegeler commented on SLING-10451: -- We would just remove creating the c

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358104#comment-17358104 ] Konrad Windszus commented on SLING-10451: - Is it ok to break backwards compatibi

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

cziegeler commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646119553 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /**

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358098#comment-17358098 ] Carsten Ziegeler commented on SLING-10451: -- Not 100% sure what the best approac

[GitHub] [sling-org-apache-sling-feature] kwin commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

kwin commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646117326 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /** * Shu

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358096#comment-17358096 ] Konrad Windszus commented on SLING-10451: - Should the cache directory be cleaned

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8

+1 Carsten Am 02.06.2021 um 12:13 schrieb dav...@apache.org: Hi all, I'd like to call the release on the Feature Model API Regions Runtime Fragment version 1.1.8 We solved the following issues: https://issues.apache.org/jira/projects/SLING/versions/12348592 Staging repository: https://reposi

Re: [VOTE] Release Apache Sling Engine 2.7.6, JCR Base 3.1.8, and Content-Package to Feature Model Converter 1.1.4

+1 Carsten Am 02.06.2021 um 16:29 schrieb Karl Pauls: I would like to call a vote on the following releases, Apache Sling Engine 2.7.6 We solved 2 issue: https://issues.apache.org/jira/projects/SLING/versions/12349731 Apache Sling JCR Base 3.1.8, We solved 2 issue: https://issues.apache.org

Re: [VOTE] Release Apache Sling Discovery Commons 1.0.24, Apache Sling Discovery Base 2.0.10, Apache Sling Discovery Oak 1.2.34

+1 Carsten Am 03.06.2021 um 17:30 schrieb Stefan Egli: Hi, We solved 7 (unique) issues in these 3 releases: https://issues.apache.org/jira/browse/SLING/fixforversion/12340518 https://issues.apache.org/jira/browse/SLING/fixforversion/12342706 https://issues.apache.org/jira/browse/SLING/fixforve

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on a change in pull request #26: SLING-10458 use NIO files

cziegeler commented on a change in pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/26#discussion_r646115621 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/ArtifactHandler.java ## @@ -46,11 +47,24 @@ public ArtifactHandle

[jira] [Commented] (SLING-10451) ArtifactManagerConfig leaves empty "slingfeature" folders in the java tmp directory

[ https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358088#comment-17358088 ] Carsten Ziegeler commented on SLING-10451: -- While I agree with the description

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on pull request #24: SLING-10451 cleanup cache directory

cziegeler commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/24#issuecomment-855380173 As mentioned in the issue, I don't think that the cache directory should always be removed -- This is an automated message from the Apache Git Service. T

[GitHub] [sling-org-apache-sling-feature] cziegeler commented on a change in pull request #25: SLING-10457 make ArtifactProvider implement Closeable

cziegeler commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646114728 ## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ## @@ -43,8 +44,20 @@ /**