rorye closed pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Dan Klco created SLING-10649:
Summary: Impersonate User in Sling Testing Client
Key: SLING-10649
URL: https://issues.apache.org/jira/browse/SLING-10649
Project: Sling
Issue Type: Improvement
Thanks Carsten.
We still need one more binding vote for this one. If anyone else has the
time, please review and provide a vote.
Regards,
Eric
On Wed, Jul 21, 2021 at 5:10 AM Carsten Ziegeler
wrote:
> +1
>
> (for the record I didn't review the changes as there were too many)
>
> Regards
> Car
[
https://issues.apache.org/jira/browse/SLING-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10610.
---
Closing with the 2.4.6 release
> Support the @ValueFrom suffix for the :name and :nameHint parameters
>
[
https://issues.apache.org/jira/browse/SLING-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10626.
---
Closing with the 2.4.6 release
> Update to Sling Bundle Parent 43
>
>
[
https://issues.apache.org/jira/browse/SLING-10609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10609.
---
Closing with the 2.4.6 release
> Export the org.apache.sling.servlets.post.exceptions package
> ---
enapps-enorman edited a comment on pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/19#issuecomment-884416219
> I think we need to define a nicer standard way of generating JSON in
Sling, as we're doing that in many places.
The JsonGener
enapps-enorman commented on pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/19#issuecomment-884416219
> I think we need to define a nicer standard way of generating JSON in
Sling, as we're doing that in many places.
The JsonGenerator fr
+1
On Tue, Jul 20, 2021 at 4:25 AM Carsten Ziegeler
wrote:
> Hi,
>
> We solved 4 issues in this release:
>
> https://issues.apache.org/jira/browse/SLING-10447?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Resource%20Resolver%201.7.10%22
>
> Staging repository:
> https://repository.apac
Hi,
The vote has passed with the following result :
+1 (binding): Eric Norman, Carsten Ziegeler, Konrad Windszus
+1 (non binding): none
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r674134187
##
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##
@@ -0,0
kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r674134187
##
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##
@@ -0,0
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384972#comment-17384972
]
Stefan Bischof commented on SLING-10229:
Since there is just one build for each
kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r674116005
##
File path: pom.xml
##
@@ -54,13 +54,21 @@
8
+COMPAT,JRE,SPI
Review comment:
Would you mind
kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r674114826
##
File path:
src/test/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtensionTest.java
##
@@ -99,
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384900#comment-17384900
]
Bertrand Delacretaz commented on SLING-10229:
-
IIUC the goal of this is to b
bdelacretaz commented on pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/19#issuecomment-884188472
> ...Compose json by hand instead of adding a new dependency to manage it...
I think we need to define a nicer standard way of generating
bdelacretaz commented on a change in pull request #19:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/19#discussion_r673964854
##
File path:
src/main/java/org/apache/sling/servlets/resolver/internal/console/WebConsolePlugin.java
##
@@ -57,6 +43,2
+1
Konrad
> On 16. Jul 2021, at 21:29, Eric Norman wrote:
>
> Hi,
>
> We solved 3 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350309
>
> Changes:
> https://github.com/apache/sling-org-apache-sling-servlets-post/compare/org.apache.sling.servlets.post-2
[
https://issues.apache.org/jira/browse/SLING-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384860#comment-17384860
]
Radu Cotescu edited comment on SLING-10619 at 7/21/21, 12:18 PM:
-
[
https://issues.apache.org/jira/browse/SLING-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384860#comment-17384860
]
Radu Cotescu commented on SLING-10619:
--
This would be the final design IMO for the
+1
(for the record I didn't review the changes as there were too many)
Regards
Carsten
Am 20.07.2021 um 17:56 schrieb Eric Norman:
We still need two more binding votes for this one. Please review and
provide a vote if you have the time.
Regards,
Eric
On Fri, Jul 16, 2021 at 12:29 PM Eric No
+1
(for the record I didn't review the changes as there were too many)
Regards
Carsten
Am 20.07.2021 um 17:56 schrieb Eric Norman:
We still need two more binding votes for this one. Please review and
provide a vote if you have the time.
Regards,
Eric
On Sat, Jul 17, 2021 at 5:02 PM Eric Nor
Any other votes?
On Thu, Jul 15, 2021, 12:46 AM Daniel Klco wrote:
> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12350214
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2498/
>
> You can use
sonarcloud[bot] commented on pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#issuecomment-884125527
Kudos, SonarCloud Quality Gate passed!  and jdk im
Buuhuu commented on pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#issuecomment-883950628
I had to ignore some tests as they cause ambiguous results depending on the
jdk version (prior jdk8 behaves differently then jdk11) and jdk implement
76 matches
Mail list logo
