[jira] [Updated] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Artem Smotrakov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Smotrakov updated SLING-10700: Description: (agreed to open a Jira issue after discussing this on secur...@apache.org)  

[jira] [Updated] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10700: - Fix Version/s: Discovery Base 2.0.12 > Improve TopologyRequestValidator code > -

[jira] [Updated] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10700: - Affects Version/s: Discovery Base 2.0.10 > Improve TopologyRequestValidator code > -

[jira] [Updated] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-10700: - Component/s: Discovery > Improve TopologyRequestValidator code > ---

[VOTE] Release Apache Sling Scripting HTL Compiler version 1.2.14-1.4.0, Scripting HTL Runtime version 1.2.6-1.4.0

2021-08-03 Thread Eric Norman
Hi, We solved 1 issues in the Scripting HTL Compiler 1.2.14-1.4.0 release: https://issues.apache.org/jira/browse/SLING/fixforversion/12350467 Changes: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/compare/org.apache.sling.scripting.sightly.compiler-1.2.12-1.4.0...org

[jira] [Commented] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Artem Smotrakov (Jira)
[ https://issues.apache.org/jira/browse/SLING-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392450#comment-17392450 ] Artem Smotrakov commented on SLING-10700: - The following pull request address th

[GitHub] [sling-org-apache-sling-discovery-base] artem-smotrakov opened a new pull request #5: SLING-10700: Improve TopologyRequestValidator code

2021-08-03 Thread GitBox
artem-smotrakov opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5 This addresses https://issues.apache.org/jira/browse/SLING-10700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (SLING-10700) Improve TopologyRequestValidator code

2021-08-03 Thread Artem Smotrakov (Jira)
Artem Smotrakov created SLING-10700: --- Summary: Improve TopologyRequestValidator code Key: SLING-10700 URL: https://issues.apache.org/jira/browse/SLING-10700 Project: Sling Issue Type: Impro

[jira] [Assigned] (SLING-10699) Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-10699: Assignee: Angela Schreiber > Incomplete path conversion in VaultPackageAssembler.

[jira] [Assigned] (SLING-10694) CPConverter drops mode from filters

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-10694: Assignee: Angela Schreiber > CPConverter drops mode from filters > --

[jira] [Assigned] (SLING-10692) VaultPackageAssembler.mergeFilters drops propertyFilterSets

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-10692: Assignee: Angela Schreiber > VaultPackageAssembler.mergeFilters drops propertyFil

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela edited a comment on pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-03 Thread GitBox
anchela edited a comment on pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-891836226 @karlpauls , i would appreciate if you had time to review the proposed fixes. in particular the calculation of the repository-paths i

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-03 Thread GitBox
anchela commented on pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-891836226 @karlpauls , i would appreciate if you had time to review the proposed fixes. in particular the calculation of the repository-paths in Vaul

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98#issuecomment-891834147 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/check

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request #98: SLING-10692 : VaultPackageAssembler.mergeFilters drops propertyFilterSets [...]

2021-08-03 Thread GitBox
anchela opened a new pull request #98: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/98 SLING-10694 : CPConverter drops mode from filters SLING-10699 : Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths -- This is an automated messa

[jira] [Updated] (SLING-10692) VaultPackageAssembler.mergeFilters drops propertyFilterSets

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10692: - Fix Version/s: Feature Model Converter 1.0.16 > VaultPackageAssembler.mergeFilters drops

[jira] [Updated] (SLING-10699) Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10699: - Fix Version/s: Content-Package to Feature Model Converter 1.1.8 > Incomplete path conver

[jira] [Updated] (SLING-10692) VaultPackageAssembler.mergeFilters drops propertyFilterSets

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10692: - Fix Version/s: (was: Feature Model Converter 1.0.16) Content-Packa

[jira] [Updated] (SLING-10699) Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10699: - Affects Version/s: Content-Package to Feature Model Converter 1.1.6 > Incomplete path co

[jira] [Updated] (SLING-10694) CPConverter drops mode from filters

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10694: - Affects Version/s: Content-Package to Feature Model Converter 1.1.6 > CPConverter drops

[jira] [Updated] (SLING-10692) VaultPackageAssembler.mergeFilters drops propertyFilterSets

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10692: - Affects Version/s: Content-Package to Feature Model Converter 1.1.6 > VaultPackageAssemb

[jira] [Updated] (SLING-10694) CPConverter drops mode from filters

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10694: - Fix Version/s: Content-Package to Feature Model Converter 1.1.8 > CPConverter drops mode

[jira] [Updated] (SLING-10694) CPConverter drops mode from filters

2021-08-03 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10694: - Component/s: Content-Package to Feature Model Converter > CPConverter drops mode from fi

[jira] [Created] (SLING-10699) Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths

2021-08-03 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10699: Summary: Incomplete path conversion in VaultPackageAssembler.toRepositoryPaths Key: SLING-10699 URL: https://issues.apache.org/jira/browse/SLING-10699 Project

[GitHub] [sling-scriptingbundle-maven-plugin] raducotescu edited a comment on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
raducotescu edited a comment on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891701174 I think we can enable the stricter parser. The changes are not that big and, to my knowledge, except for the testing examples, nobody uses yet th

[GitHub] [sling-scriptingbundle-maven-plugin] raducotescu edited a comment on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
raducotescu edited a comment on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891701174 I think we can enable the stricter parser. The changes are not that big and, to my knowledge, except for the testing examples, nobody uses the ve

[GitHub] [sling-scriptingbundle-maven-plugin] raducotescu commented on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
raducotescu commented on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891701174 I think we can enable the stricter parser. The changes are not that big and to my knowledge, except for the testing examples, nobody uses yet the versio

[GitHub] [sling-scriptingbundle-maven-plugin] kwin edited a comment on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
kwin edited a comment on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891693924 I am fine with using another directive/attribute. The main question is if the stricter parsing is ok (so that the position of the attribute/directive d

[GitHub] [sling-scriptingbundle-maven-plugin] kwin commented on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
kwin commented on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891693924 I am fine with using another directive/attribute. The main question is if the stricter parsing is ok (so that the position of the attribute/version does not m

[GitHub] [sling-scriptingbundle-maven-plugin] karlpauls commented on pull request #3: SLING-10689 optionally don't generate require-capabilities header for

2021-08-03 Thread GitBox
karlpauls commented on pull request #3: URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/3#issuecomment-891691474 @kwin, wouldn't it be better to just allow extends to be resolution=optional? So, we would still parse it as a header but just add all attributes and dir

[GitHub] [sling-org-apache-sling-scripting-core] bdelacretaz commented on a change in pull request #8: SLING-10584 log an info message if adding bindings takes more than 1 msec

2021-08-03 Thread GitBox
bdelacretaz commented on a change in pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#discussion_r681561784 ## File path: src/main/java/org/apache/sling/scripting/core/impl/bundled/ScriptContextProvider.java ## @@ -105,7 +110,16 @@

[GitHub] [sling-org-apache-sling-scripting-core] bdelacretaz commented on a change in pull request #8: SLING-10584 log an info message if adding bindings takes more than 1 msec

2021-08-03 Thread GitBox
bdelacretaz commented on a change in pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#discussion_r681561449 ## File path: src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java ## @@ -732,7 +735,16 @@ Bindings ve

[jira] [Commented] (SLING-10689) Extends file must not always generate a Requires-Capability header

2021-08-03 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392170#comment-17392170 ] Radu Cotescu commented on SLING-10689: -- bq. to support more parameters than just ve

Re: [VOTE] Release Apache Sling Feature Analyser 1.3.30

2021-08-03 Thread davidb
+1 David On Tue, 3 Aug 2021 at 08:42, Karl Pauls wrote: > +1 > > regards, > > Karl > > On Tuesday, August 3, 2021, Carsten Ziegeler wrote: > > > +1 > > > > Carsten > > > > Am 03.08.2021 um 08:16 schrieb Carsten Ziegeler: > > > >> Hi, > >> > >> We solved 1 issue in this release: > >> https://is

Re: [VOTE] Release Apache Sling Feature Analyser 1.3.30

2021-08-03 Thread Karl Pauls
+1 regards, Karl On Tuesday, August 3, 2021, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 03.08.2021 um 08:16 schrieb Carsten Ziegeler: > >> Hi, >> >> We solved 1 issue in this release: >> https://issues.apache.org/jira/browse/SLING-10695 >> >> Staging repository: >> https://repository.apac

Re: [VOTE] Release Apache Sling Feature Analyser 1.3.30

2021-08-03 Thread Carsten Ziegeler
+1 Carsten Am 03.08.2021 um 08:16 schrieb Carsten Ziegeler: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING-10695 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2509/ You can use this UNIX script to download the releas