[GitHub] [sling-org-apache-sling-feature-analyser] kwin commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
kwin commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941982304 I don't know how you run the analyzer internally, but as I said the maven-plugin supports validating content package artifacts (without having access t

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941973180 @kwin The current version of filevault-package-maven-plugin fully supports this. Unfortunately we have no influence on if / when our customers upg

[jira] [Updated] (SLING-10868) Search pattern in getSlingLocation method only works if id is the last attribute

2021-10-12 Thread Michael Kitanovski (Jira)
[ https://issues.apache.org/jira/browse/SLING-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Kitanovski updated SLING-10868: --- Description: The method getSlingLocation in class SlingHttpResponse uses a search pa

[jira] [Updated] (SLING-10868) Search pattern in getSlingLocation method only works if id is the last attribute

2021-10-12 Thread Michael Kitanovski (Jira)
[ https://issues.apache.org/jira/browse/SLING-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Kitanovski updated SLING-10868: --- Attachment: response_content.txt > Search pattern in getSlingLocation method only wo

[jira] [Resolved] (SLING-10869) ability to declare (multiline) bindings in pipe scripts

2021-10-12 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10869. - Fix Version/s: Pipes 4.3.0 Assignee: Nicolas Peltier Resolution: Fixed >

[jira] [Updated] (SLING-10869) ability to declare (multiline) bindings in pipe scripts

2021-10-12 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10869: Issue Type: Improvement (was: Task) > ability to declare (multiline) bindings in pipe scr

[jira] [Created] (SLING-10869) ability to declare (multiline) bindings in pipe scripts

2021-10-12 Thread Nicolas Peltier (Jira)
Nicolas Peltier created SLING-10869: --- Summary: ability to declare (multiline) bindings in pipe scripts Key: SLING-10869 URL: https://issues.apache.org/jira/browse/SLING-10869 Project: Sling

[jira] [Created] (SLING-10868) Search pattern in getSlingLocation method only works if id is the last attribute

2021-10-12 Thread Michael Kitanovski (Jira)
Michael Kitanovski created SLING-10868: -- Summary: Search pattern in getSlingLocation method only works if id is the last attribute Key: SLING-10868 URL: https://issues.apache.org/jira/browse/SLING-10868

[jira] [Commented] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2021-10-12 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427880#comment-17427880 ] Eric Norman commented on SLING-10740: - >From what I can tell, the jcr session save()

[jira] [Commented] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2021-10-12 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427843#comment-17427843 ] Bertrand Delacretaz commented on SLING-10740: - {quote}...we might need to re

[jira] [Assigned] (SLING-10740) Repoinit create path statement fails for node types with a mandatory property

2021-10-12 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman reassigned SLING-10740: --- Assignee: Eric Norman > Repoinit create path statement fails for node types with a mandator

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #31: SLING-10867 - The launcher should fail fast when it can't create parent directories for the applicatio

2021-10-12 Thread GitBox
sonarcloud[bot] commented on pull request #31: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/31#issuecomment-941140482 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Q

[jira] [Commented] (SLING-10867) The launcher should fail fast when it can't create parent directories for the application feature file

2021-10-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427774#comment-17427774 ] Robert Munteanu commented on SLING-10867: - https://github.com/apache/sling-org-a

[jira] [Created] (SLING-10867) The launcher should fail fast when it can't create parent directories for the application feature file

2021-10-12 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-10867: --- Summary: The launcher should fail fast when it can't create parent directories for the application feature file Key: SLING-10867 URL: https://issues.apache.org/jira/browse/S

[jira] [Resolved] (SLING-10770) JcrNamespaceRegistry.registerCnd throws NPE

2021-10-12 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-10770. -- Resolution: Fixed [~Sc0rpic0m], thanks a lot for providing a patch! good stuff. > Jcr

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
anchela commented on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941107473 thanks @niekraaijmakers for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
anchela merged pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
sonarcloud[bot] commented on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941099977 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/che

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941065577 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/ch

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
sonarcloud[bot] commented on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941065577 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qua

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
anchela commented on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-941040191 @niekraaijmakers , applied the patch to my local checkout to see what causes the test failure and spotted 2 more minor things, i would suggest y

[GitHub] [sling-org-apache-sling-feature-analyser] kwin commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
kwin commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941034651 Let us not duplicate things. https://jackrabbit.apache.org/filevault/validation.html#Standard_Validators does that already and you can easily run the a

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941026702 @rombert I will review the sonar results. There actually already is a check on the level of filevault package plugin. Unfortunately not all custom

[GitHub] [sling-org-apache-sling-feature-analyser] rombert commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
rombert commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941024923 Thanks for the PR @cschneider ! I think that @kwin would know if we have a simpler way of running checks using the FileVault APIs. Otherwise this is

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941021444 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityG

[jira] [Updated] (SLING-10866) Analyser for xml files in content packages

2021-10-12 Thread Christian Schneider (Jira)
[ https://issues.apache.org/jira/browse/SLING-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-10866: Description: Analyser that checks that xml files in content packages are well form

[jira] [Created] (SLING-10866) Analyser for xml files in content packages

2021-10-12 Thread Christian Schneider (Jira)
Christian Schneider created SLING-10866: --- Summary: Analyser for xml files in content packages Key: SLING-10866 URL: https://issues.apache.org/jira/browse/SLING-10866 Project: Sling Issu

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #115: test PR

2021-10-12 Thread GitBox
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/115#issuecomment-940995685 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/che

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
anchela commented on pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-940957800 @niekraaijmakers , just noticed that there was a test failing (but not the one you created afaik): ``` [ERROR] Tests run: 4, Failures

Re: [VOTE] Release Apache Sling Commons Log 5.1.14

2021-10-12 Thread Sagar Miglani
+1 Sagar From: Robert Munteanu Sent: Monday, October 11, 2021 8:40 PM To: Sling Developers List Subject: [VOTE] Release Apache Sling Commons Log 5.1.14 Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12348407 S

[jira] [Assigned] (SLING-10605) Add a custom login page to the generated project

2021-10-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-10605: --- Assignee: (was: Robert Munteanu) > Add a custom login page to the generated pro

[jira] [Created] (SLING-10865) Improve resource resolution mappings in the project archetype

2021-10-12 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-10865: --- Summary: Improve resource resolution mappings in the project archetype Key: SLING-10865 URL: https://issues.apache.org/jira/browse/SLING-10865 Project: Sling

Re: Maven Archetypes

2021-10-12 Thread Robert Munteanu
Hi Andy, As a FYI, the basic feature model work is done at https://github.com/apache/sling-project-archetype/pull/5 I did not merge it because it would then require us to release Sling Starter 12 to release any version of the project archetype. If we are fine with that, I can merge it. Other

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #114: SLING-10770 - add node type support for sling initial content

2021-10-12 Thread GitBox
anchela commented on a change in pull request #114: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#discussion_r726834096 ## File path: src/main/java/org/apache/sling/feature/cpconverter/vltpkg/JcrNamespaceRegistry.java ## @@ -16,89 +16,92 @

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-12 Thread Robert Munteanu
Hi, On Mon, 2021-10-11 at 16:18 +0200, Jörg Hoh wrote: > Hi, > > I envision to have a WeakHashMap, which can be reached > via a > new API call "getTemporaryStorage()" (I am very open for a better > name), > which we could implement as default method right in the interface. Is the basic need to o

[jira] [Commented] (SLING-10864) Update Sling CMS Quickstart Docs

2021-10-12 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427495#comment-17427495 ] Robert Munteanu commented on SLING-10864: - Should we maybe point them to the sli