sonarcloud[bot] commented on pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/50#issuecomment-951615049
Kudos, SonarCloud Quality Gate passed! 
--
This is an automated me
kwin commented on a change in pull request #33:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/33#discussion_r735688127
##
File path:
src/main/java/org/apache/sling/feature/analyser/task/impl/CheckContentPackages.java
##
@@ -0,0 +1,159 @@
+/*
+ *
sonarcloud[bot] commented on pull request #33:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/33#issuecomment-950988493
Kudos, SonarCloud Quality Gate passed! 
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_291, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-291/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-72-generic"
Agreed, such an approach is definitely easier to use compared to all the
other options.
I think supporting Closeable is a nice feature which adds some
additional value.
If we just go with that single method addition, I'm ok with adding this
to the api. Returning a mutable map is way better t
Radu Cotescu created SLING-10883:
Summary: Update the GraphQL implementation to use the Builder API
for internal requests
Key: SLING-10883
URL: https://issues.apache.org/jira/browse/SLING-10883
Projec
sonarcloud[bot] commented on pull request #33:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/33#issuecomment-950773590
Kudos, SonarCloud Quality Gate passed!  and the cache integrated in there.
Technically it could work, but it would require me to write a
AdapterFactory plus a matching "target" class, to which I can adapt to.
That's a lot of development overhead compared to a simple
resourceResolver.getPropertyMap().put("k
sonarcloud[bot] commented on pull request #33:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/33#issuecomment-950689921
SonarCloud Quality Gate failed. 