joerghoh merged pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
karlpauls merged pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-commons-compiler/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-commons-compiler/pull/3#issuecomment-1040066836
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #51:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/51#issuecomment-1039345363
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/50#issuecomment-1037540409
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1036255289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
enapps-enorman merged pull request #50:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/50#issuecomment-1039504635
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
joerghoh commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039226066
@stefanseifert thanks for the pointer.
From my point of view it does not make sense to continue there. I would
rather opt switch
sonarcloud[bot] commented on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1040193924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stefanseifert commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039240515
yes - but this is a rather bigger step, we do not have a good example for
this (already discussed this ab bit with @kwin in the past
sagarmiglani commented on pull request #34:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1039951823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kwin commented on pull request #34:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1039961865
As @cziegeler confirmed that there will be no dangling service references I
am fine with the approach taken in this PR.
--
This is an automated message
rombert merged pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-10625:
--
Description:
When a repoinit visitor catches an exception it wraps this exception into a
[
https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-10625.
---
Resolution: Fixed
> Repoinit Visitors should not throw RuntimeExceptions
>
[
https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492739#comment-17492739
]
Joerg Hoh commented on SLING-10625:
---
PR merged
> Repoinit Visitors should not throw RuntimeExceptions
joerghoh merged pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492597#comment-17492597
]
Robert Munteanu commented on SLING-10831:
-
[~olli]- all things being equal, I'd prefer that we
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492596#comment-17492596
]
Oliver Lietz commented on SLING-10831:
--
[~royteeuwen], The cleanup in Commons Threads is IMHO only
sonarcloud[bot] removed a comment on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1040193924
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] commented on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1040198936
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1036255289
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] commented on pull request #21:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21#issuecomment-1040193924
SonarCloud Quality Gate failed. ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492554#comment-17492554
]
Robert Munteanu commented on SLING-10831:
-
I think that for now we are safe with {{--add-opens}}
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492529#comment-17492529
]
Roy Teeuwen commented on SLING-10831:
-
Indeed, I can definitely vouch for that ThreadLocal's in
[
https://issues.apache.org/jira/browse/SLING-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-11144.
Resolution: Fixed
> Compiler does not create classfiles if compilation of unrelated compilation
karlpauls merged pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-commons-compiler/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492522#comment-17492522
]
Robert Munteanu commented on SLING-10831:
-
The problem was in application code. I don't think we
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492521#comment-17492521
]
Oliver Lietz commented on SLING-10831:
--
The JPMS should prevent exactly what we are doing in the
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492501#comment-17492501
]
Robert Munteanu commented on SLING-10831:
-
[~olli] - I think we should fix it, but I am not sure
[
https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492494#comment-17492494
]
Oliver Lietz commented on SLING-10831:
--
[~rombert], Any plans to fix? Are we fine with just failing
sonarcloud[bot] commented on pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-commons-compiler/pull/3#issuecomment-1040066836
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
Karl Pauls created SLING-11144:
--
Summary: Compiler does not create classfiles if compilation of
unrelated compilation unit fails
Key: SLING-11144
URL: https://issues.apache.org/jira/browse/SLING-11144
+1
regards,
Karl
On Tue, Feb 15, 2022 at 9:59 AM ang...@apache.org wrote:
>
> [x] +1 Approve the release
>
> kind regards
> angela
>
> On 15.02.22 08:58, ang...@apache.org wrote:
> > Hi,
> >
> > We solved 3 issues in this release:
> >
[x] +1 Approve the release
kind regards
angela
On 15.02.22 08:58, ang...@apache.org wrote:
Hi,
We solved 3 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351306
There are no outstanding issues.
Staging repository:
+1
David
On Tue, 15 Feb 2022 at 08:45, Carsten Ziegeler wrote:
> +1
>
> Carsten
>
> Am 15.02.2022 um 08:58 schrieb ang...@apache.org:
> > Hi,
> >
> > We solved 3 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12351306
> >
> > There are no outstanding issues.
+1
Carsten
Am 15.02.2022 um 08:58 schrieb ang...@apache.org:
Hi,
We solved 3 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351306
There are no outstanding issues.
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2601
On Tue, 2022-02-15 at 08:58 +0100, ang...@apache.org wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
sagarmiglani commented on pull request #34:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/34#issuecomment-1039994464
Thank you @kwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
40 matches
Mail list logo
