[
https://issues.apache.org/jira/browse/SLING-11053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495856#comment-17495856
]
Ankit Agarwal commented on SLING-11053:
---
[~joerghoh] What is the expected Date of the release of
sonarcloud[bot] commented on pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/53#issuecomment-1047250661
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495787#comment-17495787
]
Robert Munteanu commented on SLING-11140:
-
[~enorman] - that caught me by surprise as well, and
rombert opened a new pull request #53:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/53
Use the latest version of the sling feature launcher that works with no
changes.
We'll have to adapt for newer versions.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SLING-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495786#comment-17495786
]
Eric Norman commented on SLING-11140:
-
[~rombert] Sorry about that. I guess not of the tests were
[
https://issues.apache.org/jira/browse/SLING-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495786#comment-17495786
]
Eric Norman edited comment on SLING-11140 at 2/21/22, 9:29 PM:
---
[~rombert]
[
https://issues.apache.org/jira/browse/SLING-11150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret closed SLING-11150.
--
> Return package id in the DistributionResponse for a deterministic way of
> identifying status
Hi,
The vote has passed with the following result :
+1 (binding): Carsten Ziegeler, Robert Munteanu, Timothee Maret
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
+1
Le lun. 21 févr. 2022 à 10:06, Robert Munteanu a
écrit :
> On Fri, 2022-02-18 at 14:31 +0100, Timothee Maret wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/928/
for details.
No further emails will be sent until the status of the build is changed.
[
https://issues.apache.org/jira/browse/SLING-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495569#comment-17495569
]
Robert Munteanu commented on SLING-11140:
-
I reverted the update to the latest feature launcher
rombert merged pull request #52:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on pull request #52:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/52#issuecomment-1046971000
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
rombert commented on a change in pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/50#discussion_r811203225
##
File path: pom.xml
##
@@ -162,7 +162,7 @@
package
-
rombert commented on a change in pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/50#discussion_r811202221
##
File path: pom.xml
##
@@ -162,7 +162,7 @@
package
-
rombert opened a new pull request #52:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/52
Revert the feature launcher update since it immediately errors out:
Error: Unable to initialize main class
org.apache.sling.feature.launcher.impl.Main
Caused by:
FO] BUILD FAILURE
[INFO]
[INFO] Total time: 03:36 min
[INFO] Finished at: 2022-02-21T11:28:02Z
[INFO] ----
[INFO] [jenkins-event-spy] Generated
/home/jenkins/workspace/e-sling-launchpad-testing_master@
rombert commented on pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/50#issuecomment-1046762441
@humbledev123 - thanks for your comments. I still think we need a clear test
case or a reliable way of reproducing the problem in the Sling
rombert commented on a change in pull request #50:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/50#discussion_r811021901
##
File path:
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java
##
@@ -355,6 +358,31
[
https://issues.apache.org/jira/browse/SLING-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495460#comment-17495460
]
Robert Munteanu commented on SLING-11147:
-
[~olli] - for better of for worse, the Sling Starter
On Mon, 2022-02-14 at 11:58 -0800, Eric Norman wrote:
> >
> > why is it better to have distinct projects per feature instead of a
> > single
> > Starter project?
>
>
> In my opinion, it would be better for a variety of reasons, such as;
(snip)
Yup, all good points. I think there are some
[
https://issues.apache.org/jira/browse/SLING-11155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-11155.
Resolution: Fixed
> Bundled scripts should be registered by path for the main script when
>
karlpauls merged pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sonarcloud[bot] removed a comment on pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4#issuecomment-1046685816
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4#issuecomment-1046725342
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4#issuecomment-1046685816
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
karlpauls merged pull request #27:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
raducotescu commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4#discussion_r810945847
##
File path:
it/src/test/java/org/apache/sling/scripting/bundle/tracker/it/ScriptMatchIT.java
##
@@ -133,6
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/27#issuecomment-1046663838
SonarCloud Quality Gate failed. ![Quality Gate
karlpauls commented on pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4#issuecomment-1046660417
This one will fail until
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/27 is
merged
--
This is an
karlpauls opened a new pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/4
…erride the default GET servlet for proxies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Karl Pauls created SLING-11155:
--
Summary: Bundled scripts should be registered by path for the main
script when overriding
Key: SLING-11155
URL: https://issues.apache.org/jira/browse/SLING-11155
On Fri, 2022-02-18 at 14:31 +0100, Timothee Maret wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11135.
-
Resolution: Fixed
Works great, thanks [~bellingard]!
> Onboard
34 matches
Mail list logo
