[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503909#comment-17503909
]
Eric Norman commented on SLING-11189:
-
FYI: I created [PR
#13|https://github.com/ap
sonarcloud[bot] commented on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063495469
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks
sonarcloud[bot] removed a comment on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063486883
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v
sonarcloud[bot] commented on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13#issuecomment-1063486883
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks
enapps-enorman opened a new pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13
A declared requireImportProvider directive or configured
defaultRequireImportProviders list so the author can ensure that the
files are processed as intended
+1
Regards
Timothee
Le mer. 9 mars 2022 à 14:51, Stefan Egli a écrit :
> Hi,
>
>
> We solved 2 issues completely and 1 issue partially in both of these
> release:
> https://issues.apache.org/jira/projects/SLING/versions/12350269
> https://issues.apache.org/jira/projects/SLING/versions/12350270
raducotescu merged pull request #14:
URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
raducotescu commented on a change in pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/14#discussion_r822891215
##
File path:
src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java
##
@@ -742,13 +746,20 @@ Bindings
kwin commented on pull request #56:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/56#issuecomment-1063154079
If I don't hear any objections I would merge tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
stefanseifert commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822798054
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sli
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822796241
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.co
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822784062
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.co
sonarcloud[bot] commented on pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#issuecomment-1063051381
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822784062
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.co
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503662#comment-17503662
]
Julian Sedding commented on SLING-11189:
[~sseifert] in case you had tried my su
[
https://issues.apache.org/jira/browse/SLING-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503659#comment-17503659
]
Julian Sedding commented on SLING-11168:
I created [PR
#59|https://github.com/a
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822777481
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.co
kwin commented on a change in pull request #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r822777481
##
File path: src/main/features/base.json
##
@@ -358,6 +358,10 @@
"user.mapping":[
"org.apache.sling.jcr.co
jsedding opened a new pull request #59:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/59
- set minimum cardinality for contentloader readers to 4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502951#comment-17502951
]
Julian Sedding edited comment on SLING-11189 at 3/9/22, 3:17 PM:
-
enapps-enorman commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063020726
> The PR as is fixes the issue (with the hardcoded list). I meant a use case
for requiring other content readers!
Perhaps, but this P
kwin commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063017110
The PR as is fixes the issue (with the hardcoded list). I meant a use case
for requiring other content readers!
--
This is an automated message fro
enapps-enorman commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063013204
> Let us only make it configurable (i.e. more complex) when someone requests
it. Currently I also fail to see a use case.
The bug thi
stefanseifert edited a comment on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200
this would probably have been a better design decision initially, but for
backward compatibility we have to handle all the existing bu
[
https://issues.apache.org/jira/browse/SLING-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502951#comment-17502951
]
Julian Sedding edited comment on SLING-11189 at 3/9/22, 3:01 PM:
-
kwin commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063011209
Let us only make it configurable (i.e. more complex) when someone requests
it. Currently I also fail to see a use case.
--
This is an automated mes
enapps-enorman commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1063010894
Sorry, I accidentally edited your comment. I'll undo that. I guess what I
was hinting at was that the implied behavior when no requireImpo
stefanseifert edited a comment on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200
I guess what I was hinting at was that the implied behavior when no
requireImportProvider directive was provided could be backward com
stefanseifert commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-106200
this would probably have been a better design decision initially, but for
backward compatibility we have to handle all the existing bundles t
[
https://issues.apache.org/jira/browse/SLING-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-10921.
Resolution: Fixed
> Converter creates dependencies for extracted content that are wrong when the
enapps-enorman commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062982927
Perhaps what is really needed here is the inverse of the
ignoreImportProvider directive. Perhaps a new declared (or implied when
missing?)
stefanseifert commented on pull request #12:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/12#issuecomment-1062978854
making it configurable would have the benefit that it also supports custom
content readers, they could be added to the check via configuratio
sonarcloud[bot] commented on pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/4#issuecomment-1062967546
Kudos, SonarCloud Quality Gate passed! 