[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #35: SLING-11364 more precise exceptions

sonarcloud[bot] commented on PR #35: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/35#issuecomment-1145638259 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/f

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1145133899 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #72: SLING-11372: resource resolver: cleanup code related to aliases

sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/72#issuecomment-1145092345 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #35: SLING-11364 more precise exceptions

sonarcloud[bot] commented on PR #35: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/35#issuecomment-1145085430 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/f

[GitHub] [sling-org-apache-sling-testing-clients] joerghoh opened a new pull request, #35: SLING-11364 more precise exceptions

joerghoh opened a new pull request, #35: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/35 use more specialized exceptions than the generic ``ClientException``. With this it should be possible that the TestDriver can give more accurate indications about the type

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #72: SLING-11372: resource resolver: cleanup code related to aliases

sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/72#issuecomment-1145015198 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/

[jira] [Commented] (SLING-11372) resource resolver: cleanup code related to aliases

[ https://issues.apache.org/jira/browse/SLING-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545521#comment-17545521 ] Julian Reschke commented on SLING-11372: https://github.com/apache/sling-org-apa

[GitHub] [sling-org-apache-sling-testing-clients] joerghoh closed pull request #34: SLING-11364 use specialized exceptions

joerghoh closed pull request #34: SLING-11364 use specialized exceptions URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (SLING-11372) resource resolver: cleanup code related to aliases

Julian Reschke created SLING-11372: -- Summary: resource resolver: cleanup code related to aliases Key: SLING-11372 URL: https://issues.apache.org/jira/browse/SLING-11372 Project: Sling Issue

[jira] [Created] (SLING-11371) Wrong 503-unavailable status code in Distribution API responses

José Correia created SLING-11371: Summary: Wrong 503-unavailable status code in Distribution API responses Key: SLING-11371 URL: https://issues.apache.org/jira/browse/SLING-11371 Project: Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887976156 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

Re: Custom Maven Enforcer Rule hosted at Sling

Sounds good to me. You could go with the other one as well, I was just curious :-) Thanks, Robert On Thu, 2022-06-02 at 14:05 +0200, Konrad Windszus wrote: > I see, then “sling-maven-enforcer-rules” and "maven-enforcer-rules” > make more sense. > WDYT? > Konrad > > > On 2. Jun 2022, at 13:58, Ro

Re: Custom Maven Enforcer Rule hosted at Sling

I see, then “sling-maven-enforcer-rules” and "maven-enforcer-rules” make more sense. WDYT? Konrad > On 2. Jun 2022, at 13:58, Robert Munteanu wrote: > > On Thu, 2022-06-02 at 09:56 +, Konrad Windszus wrote: >> Coming back to this topic after a long time I propose to use the >> repository na

Re: Custom Maven Enforcer Rule hosted at Sling

On Thu, 2022-06-02 at 09:56 +, Konrad Windszus wrote: > Coming back to this topic after a long time I propose to use the > repository name "sling-org-apache-sling-maven-enforcer-rules" for > this and give it artifact id "org.apache.sling.maven.enforcer.rules". > > If I don't hear any objection

[GitHub] [sling-org-apache-sling-resource-inventory] rombert commented on a diff in pull request #1: SLING-11370: Sling update to 47

rombert commented on code in PR #1: URL: https://github.com/apache/sling-org-apache-sling-resource-inventory/pull/1#discussion_r887868976 ## bnd.bnd: ## @@ -0,0 +1 @@ +Private-Package: org.apache.sling.resource.inventory.impl Review Comment: This might not be needed, can yo

[jira] [Commented] (SLING-11370) Update parent bundle (47) to sling-resource-inventory

[ https://issues.apache.org/jira/browse/SLING-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545436#comment-17545436 ] Ashok Pelluru commented on SLING-11370: --- [https://github.com/apache/sling-org-apac

[jira] [Created] (SLING-11370) Update parent bundle (47) to sling-resource-inventory

Ashok Pelluru created SLING-11370: - Summary: Update parent bundle (47) to sling-resource-inventory Key: SLING-11370 URL: https://issues.apache.org/jira/browse/SLING-11370 Project: Sling Issue

[jira] [Resolved] (SLING-11368) Update parent bundle (47) to sling-mom

[ https://issues.apache.org/jira/browse/SLING-11368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11368. - Assignee: Robert Munteanu Resolution: Fixed PR applied, thanks [~ashokmc...@gmail.

[GitHub] [sling-org-apache-sling-mom] rombert merged pull request #2: SLING-11368: Upgrade to sling 47

rombert merged PR #2: URL: https://github.com/apache/sling-org-apache-sling-mom/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@s

[GitHub] [sling-org-apache-sling-mom] rombert commented on a diff in pull request #2: SLING-11368: Upgrade to sling 47

rombert commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-mom/pull/2#discussion_r887857033 ## src/main/java/org/apache/sling/mom/package-info.java: ## @@ -20,5 +20,7 @@ /** */ -@org.osgi.annotation.versioning.Version("1.0.0") +@Version("1.0.

[GitHub] [sling-org-apache-sling-mom] ashokmca07 commented on a diff in pull request #2: SLING-11368: Upgrade to sling 47

ashokmca07 commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-mom/pull/2#discussion_r887853002 ## src/main/java/org/apache/sling/mom/package-info.java: ## @@ -20,5 +20,7 @@ /** */ -@org.osgi.annotation.versioning.Version("1.0.0") +@Version("1

[GitHub] [sling-org-apache-sling-mom] rombert commented on a diff in pull request #2: SLING-11368: Upgrade to sling 47

rombert commented on code in PR #2: URL: https://github.com/apache/sling-org-apache-sling-mom/pull/2#discussion_r887839810 ## src/main/java/org/apache/sling/mom/package-info.java: ## @@ -20,5 +20,7 @@ /** */ -@org.osgi.annotation.versioning.Version("1.0.0") +@Version("1.0.

[jira] [Updated] (SLING-11369) Provide Maven Enforcer rule which checks that transitive provided dependencies are contained in the runtime Maven classpath

[ https://issues.apache.org/jira/browse/SLING-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11369: Description: All dependencies with provided scope are not transitively inherited. While th

[jira] [Updated] (SLING-11369) Provide Maven Enforcer rule which checks that transitive provided dependencies are contained in the runtime Maven classpath

[ https://issues.apache.org/jira/browse/SLING-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11369: Summary: Provide Maven Enforcer rule which checks that transitive provided dependencies ar

[jira] [Created] (SLING-11369) Provide Maven Enforcer which checks that transitive provided dependencies are contained in the runtime Maven classpath

Konrad Windszus created SLING-11369: --- Summary: Provide Maven Enforcer which checks that transitive provided dependencies are contained in the runtime Maven classpath Key: SLING-11369 URL: https://issues.apache.o

Re: Custom Maven Enforcer Rule hosted at Sling

Coming back to this topic after a long time I propose to use the repository name "sling-org-apache-sling-maven-enforcer-rules" for this and give it artifact id "org.apache.sling.maven.enforcer.rules". If I don't hear any objections I would create the repo at the end of the week. Konrad On 2021/

[jira] [Commented] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable

[ https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545355#comment-17545355 ] Angela Schreiber commented on SLING-11367: -- [~cziegeler], i don't think my fix

[jira] [Commented] (SLING-11368) Update parent bundle (47) to sling-mom

[ https://issues.apache.org/jira/browse/SLING-11368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545353#comment-17545353 ] Ashok Pelluru commented on SLING-11368: --- [https://github.com/apache/sling-org-apac

[jira] [Created] (SLING-11368) Update parent bundle (47) to sling-mom

Ashok Pelluru created SLING-11368: - Summary: Update parent bundle (47) to sling-mom Key: SLING-11368 URL: https://issues.apache.org/jira/browse/SLING-11368 Project: Sling Issue Type: Sub-task

[jira] [Commented] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable

[ https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545338#comment-17545338 ] Carsten Ziegeler commented on SLING-11367: -- This might be a matter of taste and

Improve JSON serialization and response data types

Hello! While working on the Distribution API I noticed some code smells that I would like to discuss and see if we have a solution already implemented in any Sling repository: - *Java/JSON serialization* Currently, we are implementing our own serializer in the form of a generic utils class:

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887647886 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887647886 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887647886 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887647886 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] tmaret commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

tmaret commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887645261 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(SlingHttpSe

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887636626 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887636626 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling

[GitHub] [sling-org-apache-sling-distribution-core] jose-correia commented on a diff in pull request #59: SLING-11366: Provide more exception error context on the JSON API responses

jose-correia commented on code in PR #59: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/59#discussion_r887636626 ## src/main/java/org/apache/sling/distribution/servlet/DistributionAgentServlet.java: ## @@ -71,7 +73,7 @@ protected void doPost(Sling