Re: Switch to Java 11

2022-06-15 Thread Eric Norman
> > I think it is time now to do the shift. > WDYT? +1, though java 11 only has active support until Sep 2023, so we may need to begin thinking about the path toward java 17 Regards, -Eric On Wed, Jun 15, 2022 at 8:10 AM Konrad Windszus wrote: > Hi, > AFAIK all our Sling bundles still target

Re: Switch to Java 11

2022-06-15 Thread Jörg Hoh
+1 Am Mi., 15. Juni 2022 um 17:10 Uhr schrieb Konrad Windszus : > Hi, > AFAIK all our Sling bundles still target Java 8. I think for major feature > updates we could increase this to Java 11 to leverage the newly introduced > features

[GitHub] [sling-site] joerghoh merged pull request #93: mention the necessity to unschedule scheduled jobs

2022-06-15 Thread GitBox
joerghoh merged PR #93: URL: https://github.com/apache/sling-site/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-maven-enforcer-rules] kwin merged pull request #1: Feature/test parallel builds

2022-06-15 Thread GitBox
kwin merged PR #1: URL: https://github.com/apache/sling-maven-enforcer-rules/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Switch to Java 11

2022-06-15 Thread Konrad Windszus
Hi, AFAIK all our Sling bundles still target Java 8. I think for major feature updates we could increase this to Java 11 to leverage the newly introduced features (https://www.geeksforgeeks.org/java-11-features-and-comparison/,

Enhancements in Jenkins Build

2022-06-15 Thread Konrad Windszus
Hi, In the context of https://issues.apache.org/jira/browse/SLING-9948 I adjusted the Jenkins Library which is used for all our builds. Now we can have multiple Maven builds on different JDKs executed in parallel. You can see an example execution in

[jira] [Resolved] (SLING-9948) Jenkins: Parallelize steps of pipeline

2022-06-15 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9948. Resolution: Fixed > Jenkins: Parallelize steps of pipeline >

[jira] [Commented] (SLING-9948) Jenkins: Parallelize steps of pipeline

2022-06-15 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554641#comment-17554641 ] Konrad Windszus commented on SLING-9948: Fixed in

[GitHub] [sling-tooling-jenkins] kwin merged pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
kwin merged PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-tooling-jenkins] kwin commented on a diff in pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
kwin commented on code in PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8#discussion_r898079014 ## vars/slingOsgiBundleBuild.groovy: ## @@ -122,21 +161,117 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def isReference if (

[GitHub] [sling-tooling-jenkins] rombert commented on a diff in pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
rombert commented on code in PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8#discussion_r897974002 ## vars/slingOsgiBundleBuild.groovy: ## @@ -122,21 +161,117 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def isReference if (

[GitHub] [sling-tooling-jenkins] kwin commented on a diff in pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
kwin commented on code in PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8#discussion_r897968227 ## vars/slingOsgiBundleBuild.groovy: ## @@ -122,21 +161,117 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def isReference if (

[GitHub] [sling-tooling-jenkins] rombert commented on a diff in pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
rombert commented on code in PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8#discussion_r897966096 ## vars/slingOsgiBundleBuild.groovy: ## @@ -122,21 +161,117 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def isReference if (

[jira] [Updated] (SLING-11396) Jenkins: Allow to configure build OS

2022-06-15 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11396: Description: As ASF provides Jenkins nodes for different operating systems

[jira] [Created] (SLING-11396) Jenkins: Allow to configure build OS

2022-06-15 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11396: --- Summary: Jenkins: Allow to configure build OS Key: SLING-11396 URL: https://issues.apache.org/jira/browse/SLING-11396 Project: Sling Issue Type:

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #303 is BROKEN

2022-06-15 Thread Apache Jenkins Server
-- [INFO] Total time: 05:51 min [INFO] Finished at: 2022-06-15T11:37:22Z [INFO] ---- [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/_org-apache-sling-starter_master@tmp/withMaven9b8f933c/maven-spy-20220615-113130-7605

[GitHub] [sling-tooling-jenkins] kwin commented on a diff in pull request #8: Feature/parallel builds

2022-06-15 Thread GitBox
kwin commented on code in PR #8: URL: https://github.com/apache/sling-tooling-jenkins/pull/8#discussion_r897808804 ## vars/slingOsgiBundleBuild.groovy: ## @@ -122,21 +161,117 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def isReference if (

Re: Sling's RequestDispatcher tries to flush a closed buffer (Was: Re: SlingRequestDispatcher and nested forwards)

2022-06-15 Thread Carsten Ziegeler
The internet is full of discussions whether a servlet should or must not call close() and there are more opinions than options ... I think, a servlet should not close as this can cause upstream problems, for example in a filter. And as mentioned I ran into issues with using johnzon in a

Re: Sling's RequestDispatcher tries to flush a closed buffer (Was: Re: SlingRequestDispatcher and nested forwards)

2022-06-15 Thread Radu Cotescu
This behaviour has been added via https://issues.apache.org/jira/browse/SLING-2724 , but I think that what happens with flush* is too drastic. > On 15 Jun 2022, at 10:53, Radu Cotescu wrote: > > Sure there is. However, in our case the

Re: Sling's RequestDispatcher tries to flush a closed buffer (Was: Re: SlingRequestDispatcher and nested forwards)

2022-06-15 Thread Radu Cotescu
Hi Carsten, > On 14 Jun 2022, at 17:14, Carsten Ziegeler wrote: > > Hi Radu, > > there is a difference between flush and close. If some downstream code is > flushing then the dispatcher can still call flushBuffer. Sure there is. However, in our case the dispatcher’s [1] and writer’s flush

[jira] [Assigned] (SLING-9948) Jenkins: Parallelize steps of pipeline

2022-06-15 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-9948: -- Assignee: Konrad Windszus > Jenkins: Parallelize steps of pipeline >