Re: [VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.38 and Sling Discovery Base 2.0.14

2022-08-02 Thread Jörg Hoh
+1 Stefan Egli schrieb am Di. 2. Aug. 2022 um 13:55: > Hi, > > Friendly bump : this vote would need another binding +1 > > Thanks! > Cheers, > Stefan > > On 27.07.22 19:20, Eric Norman wrote: > > +1 > > > > On Thu, Jul 21, 2022 at 7:46 AM Stefan Egli > wrote: > > > >> Hi, > >> > >> We solved 2

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

2022-08-02 Thread GitBox
nonanalou commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r935671960 ## src/main/java/org/apache/sling/xss/impl/AntiSamyHtmlSanitizer.java: ## @@ -0,0 +1,95 @@

[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #28: SLING-7231 Move to owasp sanitizer library

2022-08-02 Thread GitBox
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1202684828 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Updated] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11506: Description: In SLING-4340 the merging of resource types has been changed so that it

[jira] [Updated] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11506: Description: In SLING-4340 the merging of resource types has been changed so that it

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574203#comment-17574203 ] Michal Cukierman edited comment on SLING-11504 at 8/2/22 12:42 PM: --- To

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574203#comment-17574203 ] Michal Cukierman edited comment on SLING-11504 at 8/2/22 12:42 PM: --- To

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574203#comment-17574203 ] Michal Cukierman commented on SLING-11504: -- To wrap up: BundleResource always have

Re: [VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.38 and Sling Discovery Base 2.0.14

2022-08-02 Thread Stefan Egli
Hi, Friendly bump : this vote would need another binding +1 Thanks! Cheers, Stefan On 27.07.22 19:20, Eric Norman wrote: +1 On Thu, Jul 21, 2022 at 7:46 AM Stefan Egli wrote: Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12351434

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #367 is FIXED

2022-08-02 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/367/ for details. No further emails will be sent until the status of the build is changed.

[jira] [Updated] (SLING-11094) Sitemap: Move all dependencies to provided scope

2022-08-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph updated SLING-11094: - Component/s: Extensions > Sitemap: Move all dependencies to provided scope >

[jira] [Updated] (SLING-11094) Sitemap: Move all dependencies to provided scope

2022-08-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph updated SLING-11094: - Labels: good-first-issue sitemaps (was: sitemaps) > Sitemap: Move all dependencies to provided

[jira] [Updated] (SLING-11451) SitemapScheduler does not schedule sitemap generation for excludePaths with empty entry

2022-08-02 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-11451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph updated SLING-11451: - Labels: good-first-issue sitemaps (was: sitemaps) > SitemapScheduler does not schedule sitemap

[jira] [Updated] (SLING-11507) Field injection should not inject static fields

2022-08-02 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11507: -- Description: Currently this injection works: {noformat} @SlingObject private static

[jira] [Created] (SLING-11507) Field injection should not inject static fields

2022-08-02 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-11507: - Summary: Field injection should not inject static fields Key: SLING-11507 URL: https://issues.apache.org/jira/browse/SLING-11507 Project: Sling Issue Type: Task

[jira] [Comment Edited] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574128#comment-17574128 ] Carsten Ziegeler edited comment on SLING-11506 at 8/2/22 8:58 AM: -- I

[jira] [Commented] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574128#comment-17574128 ] Carsten Ziegeler commented on SLING-11506: -- I think I read the code initially wrong. The

[jira] [Updated] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11506: Description: In SLING-4340 the merging of resource types has been changed so that it

[jira] [Updated] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11506: Description: In SLING-4340 the merging of resource types has been changed so that it

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574125#comment-17574125 ] Konrad Windszus commented on SLING-11504: - [~cziegeler] Thanks, wasn't aware of this. I created

[jira] [Created] (SLING-11506) Streamline and document resource (super) type merging

2022-08-02 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11506: --- Summary: Streamline and document resource (super) type merging Key: SLING-11506 URL: https://issues.apache.org/jira/browse/SLING-11506 Project: Sling

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574104#comment-17574104 ] Carsten Ziegeler commented on SLING-11504: -- [~kwin] Unfortunately the resource merge does make

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574100#comment-17574100 ] Michal Cukierman edited comment on SLING-11504 at 8/2/22 8:17 AM: --  

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574101#comment-17574101 ] Konrad Windszus commented on SLING-11504: - Regarding bq. What behavior do we see as default?

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574100#comment-17574100 ] Michal Cukierman commented on SLING-11504: -- {quote}Long story short, if that solves the issue,

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574096#comment-17574096 ] Konrad Windszus edited comment on SLING-11504 at 8/2/22 8:12 AM: - bq.

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574096#comment-17574096 ] Konrad Windszus commented on SLING-11504: - bq. But, we should still look at the resourcemerger

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574093#comment-17574093 ] Michal Cukierman edited comment on SLING-11504 at 8/2/22 8:09 AM: --

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574094#comment-17574094 ] Carsten Ziegeler commented on SLING-11504: -- [~michalcukierman] As you say, the only contract we

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574093#comment-17574093 ] Michal Cukierman commented on SLING-11504: -- {quote}I agree, what about making this an opt-in

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574085#comment-17574085 ] Michal Cukierman commented on SLING-11504: -- [~cziegeler] * This change is an improvement,

[jira] [Commented] (SLING-10844) ResourceMapper.getMapping() returns null for empty path

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574084#comment-17574084 ] Carsten Ziegeler commented on SLING-10844: -- I think we should try to sort this one out in one

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574083#comment-17574083 ] Konrad Windszus edited comment on SLING-11504 at 8/2/22 7:38 AM: - bq. It

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574083#comment-17574083 ] Konrad Windszus commented on SLING-11504: - bq. It is also a change in behaviour, and there might

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574074#comment-17574074 ] Carsten Ziegeler commented on SLING-11504: -- I think the proposed change is maybe fixing exactly

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574074#comment-17574074 ] Carsten Ziegeler edited comment on SLING-11504 at 8/2/22 6:51 AM: -- I

[jira] [Comment Edited] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574073#comment-17574073 ] Konrad Windszus edited comment on SLING-11504 at 8/2/22 6:43 AM: - bq.

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574073#comment-17574073 ] Konrad Windszus commented on SLING-11504: - > Please note, that whether the value map should

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574067#comment-17574067 ] Carsten Ziegeler commented on SLING-11504: -- Please note, that whether the value map should