[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #25: SLING-11571 repoinit: allow add or remove mixin types

sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/25#issuecomment-1241550448 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGate

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #25: SLING-11571 repoinit: allow add or remove mixin types

sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/25#issuecomment-1241534065 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/f

[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #25: SLING-11571 repoinit: allow add or remove mixin types

sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/25#issuecomment-1241517323 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/f

[jira] [Commented] (SLING-11571) repoinit: allow add or remove mixin types

[ https://issues.apache.org/jira/browse/SLING-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602126#comment-17602126 ] Eric Norman commented on SLING-11571: - repoinit-parser - Pull Request #25 contains t

[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman opened a new pull request, #25: SLING-11571 repoinit: allow add or remove mixin types

enapps-enorman opened a new pull request, #25: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/25 The use case here is for a node that is created by a base feature. Other (optional) features could add a mixin to the existing node later if they are also included i

[jira] [Created] (SLING-11571) repoinit: allow add or remove mixin types

Eric Norman created SLING-11571: --- Summary: repoinit: allow add or remove mixin types Key: SLING-11571 URL: https://issues.apache.org/jira/browse/SLING-11571 Project: Sling Issue Type: New Featu

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1241122489 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1241118777 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fai

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1241118246 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fai

[jira] [Commented] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601861#comment-17601861 ] Carsten Ziegeler commented on SLING-11569: -- makes sense, ok > Response created

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601848#comment-17601848 ] Julian Reschke commented on SLING-11439: I now tried {noformat} SELECT [sling:v

[jira] [Commented] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601844#comment-17601844 ] Stefan Seifert commented on SLING-11569: in this ticket i would only take care o

[jira] [Resolved] (SLING-11570) Adjust integration tests to not fail due to incompatible change in Jetty's status message handling

[ https://issues.apache.org/jira/browse/SLING-11570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11570. -- Resolution: Done > Adjust integration tests to not fail due to incompatible change in Jetty's

[jira] [Created] (SLING-11570) Adjust integration tests to not fail due to incompatible change in Jetty's status message handling

Oliver Lietz created SLING-11570: Summary: Adjust integration tests to not fail due to incompatible change in Jetty's status message handling Key: SLING-11570 URL: https://issues.apache.org/jira/browse/SLING-11570

Incompatible change in Jetty 9.4.21/Felix Http Jetty 4.0.16 regarding status messages

Hi, When upgrading Commons Crypto to latest Testing PaxExam snapshot some ITs failed where the status messages of HTTP responses are checked. There is an incompatible change in Jetty 9.4.21 (Felix Http Jetty 4.0.16): When using HttpServletResponse#sendError(int sc, String msg) the msg parameter

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601815#comment-17601815 ] Julian Reschke commented on SLING-11439: [~thomasm] re https://issues.apache.or

[jira] [Comment Edited] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601783#comment-17601783 ] Carsten Ziegeler edited comment on SLING-11569 at 9/8/22 12:16 PM: ---

[jira] [Commented] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601783#comment-17601783 ] Carsten Ziegeler commented on SLING-11569: -- [~sseifert] That should be ok; I ha

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #25: SLING-11569 do not enforce SlingHttpServletResponse to be an actual SlingHttpServletResponseImpl instance

sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/25#issuecomment-1240610426 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/pas

[jira] [Commented] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601777#comment-17601777 ] Stefan Seifert commented on SLING-11569: here is my proposal to fix the issue: h

[GitHub] [sling-org-apache-sling-engine] stefanseifert opened a new pull request, #25: SLING-11569 do not enforce SlingHttpServletResponse to be an actual SlingHttpServletResponseImpl instance

stefanseifert opened a new pull request, #25: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/25 related integration test PRs: * https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/5 * https://github.com/apache/sling-org-apache-sling-launchp

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on pull request #36: SLING-11567 add null checks

joerghoh commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#issuecomment-1240601383 Want to wait for feedback from @anchela as she has done these changes. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #9: SLING-11569 Test case to validate including output from other servlets via RequestDispatcher

sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/9#issuecomment-1240595135 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityG

[GitHub] [sling-org-apache-sling-launchpad-test-services] sonarcloud[bot] commented on pull request #5: SLING-11569 test servlets to use RequestDispatcher to include content from other servlets

sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/5#issuecomment-1240593482 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateB

[jira] [Commented] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

[ https://issues.apache.org/jira/browse/SLING-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601770#comment-17601770 ] Stefan Seifert commented on SLING-11569: i've provided two PRs with an integrati

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] stefanseifert opened a new pull request, #9: SLING-11569 Test case to validate including output from other servlets via RequestDispatcher

stefanseifert opened a new pull request, #9: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/9 test case for https://issues.apache.org/jira/browse/SLING-11569 depends on https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pu

[GitHub] [sling-org-apache-sling-launchpad-test-services] stefanseifert opened a new pull request, #5: SLING-11569 test servlets to use RequestDispatcher to include content from other servlets

stefanseifert opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-launchpad-test-services/pull/5 test case for https://issues.apache.org/jira/browse/SLING-11569 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (SLING-11569) Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include

Stefan Seifert created SLING-11569: -- Summary: Response created with Builders.newResponseBuilder() does not work with RequestDispatcher.include Key: SLING-11569 URL: https://issues.apache.org/jira/browse/SLING-115

[jira] [Commented] (SLING-11560) Vault error when importing a node with the same name and UUID as a pre-existing non-sibling node

[ https://issues.apache.org/jira/browse/SLING-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601759#comment-17601759 ] Konrad Windszus commented on SLING-11560: - You are using the low-level API Impor

[GitHub] [sling-org-apache-sling-scripting-thymeleaf] sonarcloud[bot] commented on pull request #2: Bump commons-io from 2.5 to 2.7

sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-scripting-thymeleaf/pull/2#issuecomment-1240554436 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa

[GitHub] [sling-org-apache-sling-scripting-thymeleaf] dependabot[bot] opened a new pull request, #2: Bump commons-io from 2.5 to 2.7

dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-scripting-thymeleaf/pull/2 Bumps commons-io from 2.5 to 2.7. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=c

[jira] [Commented] (SLING-11560) Vault error when importing a node with the same name and UUID as a pre-existing non-sibling node

[ https://issues.apache.org/jira/browse/SLING-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601747#comment-17601747 ] Timothee Maret commented on SLING-11560: [~reschke] [~kwin] Sling Content Distri

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

nonanalou commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r965750559 ## src/main/java/org/apache/sling/xss/impl/style/BatikCssCleaner.java: ## @@ -0,0 +1,82 @@ +/*~

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

nonanalou commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r965741414 ## src/main/java/org/apache/sling/xss/impl/style/BatikCssCleaner.java: ## @@ -0,0 +1,82 @@ +/*~

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #36: SLING-11567 add null checks

sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#issuecomment-1240384458 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fail

[GitHub] [sling-org-apache-sling-xss] kwin commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

kwin commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r965645934 ## src/main/java/org/apache/sling/xss/impl/style/BatikCssCleaner.java: ## @@ -0,0 +1,82 @@ +/*~~

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on a diff in pull request #36: SLING-11567 add null checks

joerghoh commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r965643121 ## src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java: ## @@ -85,12 +85,19 @@ protected String checkKey(final String key) {

[GitHub] [sling-org-apache-sling-xss] kwin commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

kwin commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r965642970 ## src/main/java/org/apache/sling/xss/impl/style/BatikCssCleaner.java: ## @@ -0,0 +1,82 @@ +/*~~

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on a diff in pull request #36: SLING-11567 add null checks

kwin commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r965639487 ## src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java: ## @@ -85,12 +85,19 @@ protected String checkKey(final String key) {

[GitHub] [sling-org-apache-sling-xss] nonanalou commented on a diff in pull request #28: SLING-7231 Move to owasp sanitizer library

nonanalou commented on code in PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r965637546 ## src/main/java/org/apache/sling/xss/impl/style/BatikCssCleaner.java: ## @@ -0,0 +1,82 @@ +/*~

[GitHub] [sling-org-apache-sling-jcr-resource] sonarcloud[bot] commented on pull request #36: SLING-11567 add null checks

sonarcloud[bot] commented on PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#issuecomment-1240369758 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fail

[GitHub] [sling-org-apache-sling-jcr-resource] joerghoh commented on a diff in pull request #36: SLING-11567 add null checks

joerghoh commented on code in PR #36: URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/36#discussion_r965630677 ## src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java: ## @@ -85,12 +85,19 @@ protected String checkKey(final String key) {