[GitHub] [sling-org-apache-sling-testing-clients] joerghoh commented on pull request #38: SLING-11609: Provide doGetWithRetry methods in Sling Testing Clients

2022-10-06 Thread GitBox
joerghoh commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270592706 @enapps-enorman It's fine for me if we move the example you have given above into the readme. It's just that I don't want to loose that snippet here in the gi

[GitHub] [sling-org-apache-sling-testing-clients] enapps-enorman commented on pull request #38: SLING-11609: Provide doGetWithRetry methods in Sling Testing Clients

2022-10-06 Thread GitBox
enapps-enorman commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270482796 > I wouldn't mind if we keep this functionality, even if it is just a thin wrapper around `Awaitility`. @joerghoh I won't stand in the way of that

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-10-06 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1270465220 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-auth-xing-oauth] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-10-06 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1270407008 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fai

[GitHub] [sling-org-apache-sling-auth-xing-login] sonarcloud[bot] commented on pull request #2: Upgrade to sling 48

2022-10-06 Thread GitBox
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1270405967 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/fai

[GitHub] [sling-org-apache-sling-testing-clients] joerghoh commented on pull request #38: SLING-11609: Provide doGetWithRetry methods in Sling Testing Clients

2022-10-06 Thread GitBox
joerghoh commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270348482 I wouldn't mind if we keep this functionality, even if it is just a thin wrapper around ```Awaitility```. -- This is an automated message from the Apache Gi

[GitHub] [sling-org-apache-sling-testing-clients] nscendoni commented on pull request #38: SLING-11609: Provide doGetWithRetry methods in Sling Testing Clients

2022-10-06 Thread GitBox
nscendoni commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270290792 @enapps-enorman Yes, I can use Awaitility without modifying sling-testing-clients and the code is compact and clean. You can either close this pull reques