[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1295670321 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1295665018 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #38: Add missing test case for AnnotationConflictsTest

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1295645022 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg

[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295542361 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge

[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295434280 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge

[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295409026 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge

[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295390488 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge

[GitHub] [sling-org-apache-sling-commons-mime] sonarcloud[bot] commented on pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#issuecomment-1295379553 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge

[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
agangam commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390405 ## src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java: ## @@ -152,6 +165,29 @@ public void testProvider2() throws

[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
agangam commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008390217 ## src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java: ## @@ -152,6 +165,29 @@ public void testProvider2() throws

[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
agangam commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389902 ## src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java: ## @@ -152,6 +165,29 @@ public void testProvider2() throws

[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
agangam commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008389741 ## src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java: ## @@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest

[GitHub] [sling-org-apache-sling-commons-mime] agangam commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
agangam commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008388948 ## src/main/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImpl.java: ## @@ -166,9 +166,17 @@ public void registerMimeType(String mim

Re: Discuss policy for updating dependencies

2022-10-28 Thread Oliver Lietz
On Friday, 28 October 2022 18:36:07 CEST Jörg Hoh wrote: > I want to add another aspect to this discussion. > > In many of out integration tests we use the versions of additional bundles > to deploy into the IT from the pom. That means that in all of these ITs we > deliberately test against old(er

[GitHub] [sling-ide-tooling] kwin commented on pull request #14: SLING-11590 Make compatible with m2e 2.x

2022-10-28 Thread GitBox
kwin commented on PR #14: URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1295268565 @rombert Can you try locally. For me the tests locally always succeed with ``` Maven home: /opt/homebrew/Cellar/maven/3.8.6/libexec Java version: 17.0.4, vendor: Eclipse Adopti

Re: Discuss policy for updating dependencies

2022-10-28 Thread Jörg Hoh
I want to add another aspect to this discussion. In many of out integration tests we use the versions of additional bundles to deploy into the IT from the pom. That means that in all of these ITs we deliberately test against old(er) versions of our bundles (except the test subject, of course); tha

[GitHub] [sling-org-apache-sling-commons-mime] rombert commented on a diff in pull request #5: SLING-11651 - support for multiple mime types for eps

2022-10-28 Thread GitBox
rombert commented on code in PR #5: URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/5#discussion_r1008227094 ## src/test/java/org/apache/sling/commons/mime/internal/MimeTypeServiceImplTest.java: ## @@ -43,6 +44,18 @@ public class MimeTypeServiceImplTest

[jira] [Resolved] (SLING-11527) JMX Exporter: should not create Mbeans again for exported MBeans

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11527. --- Resolution: Abandoned Checking the Codahale API it does not seem to be possible not export specific

[jira] [Closed] (SLING-11527) JMX Exporter: should not create Mbeans again for exported MBeans

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11527. - > JMX Exporter: should not create Mbeans again for exported MBeans > ---

Re: [VOTE] Release Apache Sling XSS Protection API 2.3.2

2022-10-28 Thread Angela Schreiber
hi robert [x] +1 Approve the release kind regards angela From: Robert Munteanu Sent: Wednesday, October 26, 2022 15:27 To: Sling Developers List Subject: [VOTE] Release Apache Sling XSS Protection API 2.3.2 Hi, We solved 2 issues in this release: https://iss

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread Angela Schreiber
hi Carsten [x] +1 Approve the release kind regards and thanks a lot angela From: Carsten Ziegeler Sent: Friday, October 28, 2022 10:10 To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22 EXTERNAL: Use

[jira] [Updated] (SLING-10071) update distribution core to use bundle-parent 40

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10071: -- Fix Version/s: Content Distribution Core 0.5.2 > update distribution core to use bundle-parent 40 > --

[jira] [Resolved] (SLING-10071) update distribution core to use bundle-parent 40

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-10071. --- Resolution: Fixed has been merged without updating this ticket :-) > update distribution core to us

[GitHub] [sling-ide-tooling] rombert commented on pull request #14: SLING-11590 Make compatible with m2e 2.x

2022-10-28 Thread GitBox
rombert commented on PR #14: URL: https://github.com/apache/sling-ide-tooling/pull/14#issuecomment-1295134410 @kwin - one test might be related to your work ```org.apache.sling.ide.eclipse.m2e.internal.LegacyMavenBundleProjectTest.testLegacyMavenBundleProjectHasErrorMarker Time ela

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

2022-10-28 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625766#comment-17625766 ] Robert Munteanu commented on SLING-11507: - What is the tooling entry point that

[jira] [Resolved] (SLING-11399) Disable stacktrace when logging PersistenceExceptions

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-11399. --- Resolution: Fixed > Disable stacktrace when logging PersistenceExceptions >

[jira] [Updated] (SLING-11399) Disable stacktrace when logging PersistenceExceptions

2022-10-28 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11399: -- Fix Version/s: Servlets POST 2.5.2 > Disable stacktrace when logging PersistenceExceptions > -

[GitHub] [sling-org-apache-sling-servlets-post] joerghoh merged pull request #19: SLING-11399 add option to disable printing the stacktraces of the Per…

2022-10-28 Thread GitBox
joerghoh merged PR #19: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

Re: [VOTE] Release Apache Sling XSS Protection API 2.3.2

2022-10-28 Thread Jörg Hoh
+1 Am Mi., 26. Okt. 2022 um 15:27 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352357 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2687/

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread Jörg Hoh
+1 Am Fr., 28. Okt. 2022 um 10:11 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 1 issues > https://issues.apache.org/jira/browse/SLING-11653 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2689/ > > You can use this UNIX sc

Re: [VOTE] Release Apache Sling XSS Protection API 2.3.2

2022-10-28 Thread Radu Cotescu
+1 > On 26 Oct 2022, at 15:27, Robert Munteanu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread Carsten Ziegeler
+1 Carsten Am 28.10.2022 um 10:10 schrieb Carsten Ziegeler: Hi, We solved 1 issues https://issues.apache.org/jira/browse/SLING-11653 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2689/ You can use this UNIX script to download the release and verify

Re: [VOTE] Release Apache Sling Oak-Based Discovery Service 1.2.42

2022-10-28 Thread Robert Munteanu
On Thu, 2022-10-27 at 17:44 +0200, Stefan Egli wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread Robert Munteanu
On Fri, 2022-10-28 at 10:10 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread davidb
+1 David On Fri, 28 Oct 2022 at 10:10, Carsten Ziegeler wrote: > Hi, > > We solved 1 issues > https://issues.apache.org/jira/browse/SLING-11653 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2689/ > > You can use this UNIX script to download the re

Re: Failed to release org.apache.sling.feature.cpconverter

2022-10-28 Thread Konrad Windszus
Hi Angela, In order to help you and resolve the issues you need to share the errors you are facing together with the Java version and OS you are using. Preferably as a JIRA issue. In general I think it makes sense to already build javadoc during CI builds to detect those issues earlier. Thanks,

[jira] [Updated] (SLING-11616) Build and test with Windows

2022-10-28 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11616: - Fix Version/s: Content-Package to Feature Model Converter 1.1.24 (

[VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

2022-10-28 Thread Carsten Ziegeler
Hi, We solved 1 issues https://issues.apache.org/jira/browse/SLING-11653 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2689/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-t

Re: Failed to release org.apache.sling.feature.cpconverter

2022-10-28 Thread Carsten Ziegeler
Hi Angela, sure, I'll give it a try with the release. Now, at least when javadocs are concerned, people using ubuntu will not notice any javadoc errors or warnings by default. That's why usually I and some others here can release without noticing the problem. However, something is wrong with

[jira] [Updated] (SLING-11507) Field injection should not inject static fields

2022-10-28 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-11507: - Fix Version/s: Sling Models Implementation 1.5 > Field injection should not inject stati

Failed to release org.apache.sling.feature.cpconverter

2022-10-28 Thread Angela Schreiber
Hi Yesterday I aimed to release org.apache.sling.feature.cpconverter 1.1.22. However, the release process failed during mvn release:preform due to javadoc errors. Surprisingly, it reported errors for classes I most definitely have released before. Could that be due to the latest parent.pom 49