Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

> > How about we go there when such a use case comes up in reality? > > Regards > Carsten > I apologise for trying to be proactive. It seems my opinions don't matter here as the Adobe voices have overwhelmed the discussion. Have a good day. -Eric On Mon, Dec 19, 2022 at 4:16 AM Carsten

[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API

[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649415#comment-17649415 ] Robert Munteanu commented on SLING-11718: - Thanks [~cziegeler]! > Migrate to Jakarta JSON API >

[jira] [Created] (SLING-11740) DefaultErrorHandler should not catch Error

Carsten Ziegeler created SLING-11740: Summary: DefaultErrorHandler should not catch Error Key: SLING-11740 URL: https://issues.apache.org/jira/browse/SLING-11740 Project: Sling Issue

Re: [VOTE] Release Apache Sling App CMS version 1.1.4

Thanks Stefan, I'll correct these. It shouldn't affect the built application, however. My +1 On Sat, Dec 17, 2022 at 9:50 AM Stefan Seifert wrote: > +1 > > please note: the repository contains paths that are invalid on windows: > > error: invalid path >

[GitHub] [sling-org-apache-sling-feature-cpconverter] niekraaijmakers commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…

niekraaijmakers commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1357776732 @niekraaijmakers can't say much about the first patch of code but the second one (retrieving /.content.xml ) is surely better. -- This is an

[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API

[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649339#comment-17649339 ] Carsten Ziegeler commented on SLING-11718: -- Thanks [~rombert] - this seems to be a "transitive"

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…

rombert commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1357708421 @abhishekgarg18 - the build failure is unrelated, seems the previous commit has introduced a regression. While we clear that our, @DominikSuess /

[jira] [Commented] (SLING-11718) Migrate to Jakarta JSON API

[ https://issues.apache.org/jira/browse/SLING-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649335#comment-17649335 ] Robert Munteanu commented on SLING-11718: - [~cziegeler] - the cpconverter build started failing

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

> On 19. Dec 2022, at 14:45, Bertrand Delacretaz wrote: > > So my preference goes to "set nodes ...", but if the majority prefers > "ensure nodes" that also works. Sounds better to me as well. Konrad

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

Hi, Konrad Windszus wrote: > ...So I will for now only update > https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27 > > with > > Instruction "ensure node" (for creating or updating node(s) with

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

I think it is fine to leave out "update node" for now (but you have to keep it in mind for naming the other new instruction to allow for such semantics later on). So I will for now only update https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

How about we go there when such a use case comes up in reality? Regards Carsten Am 19.12.2022 um 13:09 schrieb Konrad Windszus: Please read the full mailing list thread. This were the use cases brought up by Eric "I can envision a highly modular distribution in which two modules (from

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

Please read the full mailing list thread. This were the use cases brought up by Eric "I can envision a highly modular distribution in which two modules (from different owners) may accidentally have paths that collide. So I can see how a repoinit that would fail fast in that scenario could be

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

Hi, I agree with deprecating "create path" and implementing new instructions. But I'm not sure why you would need two new instructions: Konrad Windszus wrote: ... > a) ensure node (for creating or updating node(s) with primary and mixin type) > b) update node (for just updating existing

[jira] [Updated] (SLING-11739) Index definition extraction from content packages is missing binary files data

[ https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Garg updated SLING-11739: -- Description: Currently, binaries are stored in indexDefinitions at [1] and these binaries

[jira] [Commented] (SLING-11739) Index definition extraction from content packages is missing binary files data

[ https://issues.apache.org/jira/browse/SLING-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649265#comment-17649265 ] Abhishek Garg commented on SLING-11739: --- PR to fix that

[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 opened a new pull request, #152: SLING-11739 Index definition extraction from content packages is miss…

abhishekgarg18 opened a new pull request, #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152 …ing binary files data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (SLING-11739) Index definition extraction from content packages is missing binary files data

Abhishek Garg created SLING-11739: - Summary: Index definition extraction from content packages is missing binary files data Key: SLING-11739 URL: https://issues.apache.org/jira/browse/SLING-11739

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

Sounds good to me, so that would leave us with two new statements: a) ensure node (for creating or updating node(s) with primary and mixin type) b) update node (for just updating existing node(s) with primary and mixin type). I will update my PR at

Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility

How about "ensure node"? It's shorter than "updateOrCreate node", which to me seems likely the most common case. Regards Julian PS: my preference is also with deprecating "create path" in favour of a new clearly defined instruction. On Mon, Dec 19, 2022 at 7:21 AM Konrad Windszus wrote: > >

[jira] [Resolved] (SLING-11738) Add option to prevent request override

[ https://issues.apache.org/jira/browse/SLING-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11738. -- Resolution: Fixed

[jira] [Created] (SLING-11738) Add option to prevent request override

Carsten Ziegeler created SLING-11738: Summary: Add option to prevent request override Key: SLING-11738 URL: https://issues.apache.org/jira/browse/SLING-11738 Project: Sling Issue Type:

Re: New repository for SLING-11729 (RepoInit FileVault Validator)

Done now in https://gitbox.apache.org/repos/asf/sling-org-apache-sling-repoinit-filevault-validator.git . > On 15. Dec 2022, at 10:41, Konrad Windszus wrote: > > Hi, > I proposed a FileVault