sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1518450609
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-1518450420
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1518443982
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu
Robert Munteanu created SLING-11844:
---
Summary: Index definitions must not be extracted from empty nodes
Key: SLING-11844
URL: https://issues.apache.org/jira/browse/SLING-11844
Project: Sling
klcodanr commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173932076
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final long et
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173922933
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final long et
andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173911475
##
src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java:
##
@@ -181,6 +181,11 @@ public void log(String message, Object... args
andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173913659
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final lo
andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173912187
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final lo
andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173911475
##
src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java:
##
@@ -181,6 +181,11 @@ public void log(String message, Object... args
andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173911475
##
src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java:
##
@@ -181,6 +181,11 @@ public void log(String message, Object... args
klcodanr commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173908716
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final long et
sonarcloud[bot] commented on PR #166:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/166#issuecomment-1517860928
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quali
[
https://issues.apache.org/jira/browse/SLING-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11840:
---
Assignee: Robert Munteanu
> Drop Java 8 support for the Sling Starter
> ---
[
https://issues.apache.org/jira/browse/SLING-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11714.
-
Resolution: Fixed
All done, thanks [~tomaszmichalak]!
> Multi-arch support for Docker i
rombert merged PR #151:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
rombert commented on PR #151:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/151#issuecomment-1517821763
Sounds good, let's not spend too much time on something that will probably
stay frozen.
--
This is an automated message from the Apache Git Service.
To respond to
tomaszmichalak commented on PR #151:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/151#issuecomment-1517806671
I have a discussion with @malaskowski about this. Having some environment
variables and adding if statements in bash can be less readable. GH Actions
also do
rombert closed pull request #158: [Shelved] Sling 11777 2 - improve
segmentprocessing
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/SLING-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714990#comment-17714990
]
Robert Munteanu commented on SLING-11837:
-
Draft PR at
https://github.com/apach
rombert opened a new pull request, #166:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/166
Avoid setting the 'str:' prefix unless necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/SLING-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11837:
Description:
The logic used to generate the "str:" prefix for string values comes from her
[
https://issues.apache.org/jira/browse/SLING-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11837:
---
Assignee: Robert Munteanu
> Align index definition generation logic with the one fr
[
https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-11843:
---
Assignee: Konrad Windszus
> Change Default JDK/OS for Jenkins Builds to JDK11/17 on
[
https://issues.apache.org/jira/browse/SLING-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-11841.
-
Resolution: Fixed
Fixed in
https://github.com/apache/sling-parent/commit/7aae61f6e9ee18
kwin merged PR #33:
URL: https://github.com/apache/sling-parent/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
sonarcloud[bot] commented on PR #33:
URL: https://github.com/apache/sling-parent/pull/33#issuecomment-1517654182
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qua
kwin commented on code in PR #33:
URL: https://github.com/apache/sling-parent/pull/33#discussion_r1173632916
##
sling-parent/pom.xml:
##
@@ -56,7 +56,7 @@
- 9: Java 9
- 10..19: Java 10-19
-->
-8
+11
Review Comment:
This
stefanseifert commented on code in PR #33:
URL: https://github.com/apache/sling-parent/pull/33#discussion_r1173627956
##
sling-parent/pom.xml:
##
@@ -56,7 +56,7 @@
- 9: Java 9
- 10..19: Java 10-19
-->
-8
+11
Review Comment:
I created some follow up tickets for that
https://issues.apache.org/jira/browse/SLING-11843
https://issues.apache.org/jira/browse/SLING-11842
https://issues.apache.org/jira/browse/SLING-11841
Please comment directly on those.
Thanks,
Konrad
> On 21. Apr 2023, at 12:02, Stefan Seifert
> wrot
Konrad Windszus created SLING-11843:
---
Summary: Change Default JDK/OS for Jenkins Builds
Key: SLING-11843
URL: https://issues.apache.org/jira/browse/SLING-11843
Project: Sling
Issue Type: Im
[
https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11843:
Summary: Change Default JDK/OS for Jenkins Builds to JDK11/17 on
Unix/Windows (was: Chang
[
https://issues.apache.org/jira/browse/SLING-11842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11842:
Summary: Drop Java 8 support from Parent (was: Drop Java 8 support)
> Drop Java 8 support
sonarcloud[bot] commented on PR #33:
URL: https://github.com/apache/sling-parent/pull/33#issuecomment-1517610511
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qua
Konrad Windszus created SLING-11842:
---
Summary: Drop Java 8 support
Key: SLING-11842
URL: https://issues.apache.org/jira/browse/SLING-11842
Project: Sling
Issue Type: Improvement
C
Konrad Windszus created SLING-11841:
---
Summary: Target Java 11 by default
Key: SLING-11841
URL: https://issues.apache.org/jira/browse/SLING-11841
Project: Sling
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SLING-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714926#comment-17714926
]
Konrad Windszus commented on SLING-11840:
-
Compare also with
https://lists.apac
There was a similar discussion already at
https://lists.apache.org/thread/6p86tqpldjj83zw3288ooht869yt99dr and back then
we already kind of reached consensus that it is time to require Java 11 also
for bundles nowadays.
Konrad
> On 21. Apr 2023, at 12:02, Stefan Seifert
> wrote:
>
> makes
makes sense, go ahead!
we should consider dropping java 8 for new sling module releases in general,
updating to java 11 in our sling-parent. java 8 is EOL for quite a long time,
we can start using new language features, and drop java 8 builds in Jenkins.
stefan
> -Original Message-
> F
[
https://issues.apache.org/jira/browse/SLING-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11840:
Description:
We are discussiong adding a new dependency for the Jakarta JSON support (
Ec
[
https://issues.apache.org/jira/browse/SLING-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-11840:
Description:
We are discussiong adding a new dependency for the Jakarta JSON support (
Ec
Hi,
Changing subject to make sure we get enough attention. With Oak 1.50
requiring Java 11 it does not look like we can hold on to Java 8 for
much longer.
I filed https://issues.apache.org/jira/browse/SLING-11840 to track
this.
If anyone sees a reason to keep supporting Java 8, please say so.
N
Robert Munteanu created SLING-11840:
---
Summary: Drop Java 8 support for the Sling Starter
Key: SLING-11840
URL: https://issues.apache.org/jira/browse/SLING-11840
Project: Sling
Issue Type: I
[
https://issues.apache.org/jira/browse/SLING-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11771.
-
Resolution: Fixed
PR applied, thanks [~royteeuwen]!
> Upgrade Sling Starter to Groovy 4
[
https://issues.apache.org/jira/browse/SLING-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11771:
---
Assignee: Roy Teeuwen
> Upgrade Sling Starter to Groovy 4.x
> -
rombert commented on PR #83:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/83#issuecomment-1517554231
Thanks @royteeuwen !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rombert merged PR #83:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubsc
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173518197
##
src/main/java/org/apache/sling/event/impl/jobs/tasks/CleanUpTask.java:
##
@@ -181,6 +181,11 @@ public void log(String message, Object... args) {
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173517103
##
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##
@@ -84,6 +84,22 @@ public void updateProgress(final long et
rombert commented on code in PR #165:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1173510075
##
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java:
##
@@ -145,6 +146,9 @@ pu
tomaszmichalak opened a new pull request, #151:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/151
@rombert Docker image release on tag push (`${project.version}` e.g `13` and
`latest`).
--
This is an automated message from the Apache Git Service.
To respond to the mes
51 matches
Mail list logo