[jira] [Created] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-05 Thread Sagar Miglani (Jira)
Sagar Miglani created SLING-11861: - Summary: ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url Key: SLING-11861 URL: https://issues.apache.org/jira/browse/SLING-11861

[jira] [Commented] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-05 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719701#comment-17719701 ] Roy Teeuwen commented on SLING-11856: - [~cziegeler]  could you have a look at this?

[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani opened a new pull request, #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
sagarmiglani opened a new pull request, #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96 …en a vanity paths is pathless url -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-05 Thread Sagar Miglani (Jira)
[ https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719702#comment-17719702 ] Sagar Miglani commented on SLING-11861: --- Potential changes: [https://github.com/a

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#issuecomment-1535835990 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGat

[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-05 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719715#comment-17719715 ] Julian Reschke commented on SLING-11861: Not convinced. This is a change in beh

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
reschke commented on code in PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185786325 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java: ## @@ -397,8 +397,8 @@ public void mapResource

[jira] [Commented] (SLING-11861) ResourceMapper.getAllMappings returns empty mapping "" when a vanity paths is pathless url

2023-05-05 Thread Sagar Miglani (Jira)
[ https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719734#comment-17719734 ] Sagar Miglani commented on SLING-11861: --- [~reschke] I believe it is a missed edge

[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
sagarmiglani commented on code in PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185836833 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java: ## @@ -397,8 +397,8 @@ public void mapRes

RE: Prevent certain compile dependencies (was: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10)

2023-05-05 Thread Stefan Seifert
yes, for this one and the OSGi annotations it would make sense. they are even in an unit test environment no candidates for compile scope. stefan > -Original Message- > From: Konrad Windszus > Sent: Thursday, May 4, 2023 4:08 PM > To: dev@sling.apache.org > Subject: Re: [VOTE] Release A

RE: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10

2023-05-05 Thread Stefan Seifert
yes, i would rather propose to do a new release to solve a), otherwise this issues stays around for quite a while. stefan > -Original Message- > From: Daniel Klco > Sent: Thursday, May 4, 2023 3:59 PM > To: dev@sling.apache.org > Subject: Re: [VOTE] Release Apache Sling Event API versio

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
reschke commented on code in PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185843290 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java: ## @@ -397,8 +397,8 @@ public void mapResource

RE: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2

2023-05-05 Thread Stefan Seifert
+1 stefan

[GitHub] [sling-org-apache-sling-resourceresolver] sagarmiglani commented on a diff in pull request #96: SLING-11861 - ResourceMapper.getAllMappings returns empty mapping wh…

2023-05-05 Thread via GitHub
sagarmiglani commented on code in PR #96: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185850447 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java: ## @@ -397,8 +397,8 @@ public void mapRes

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2

2023-05-05 Thread Konrad Windszus
+1 (although having https://issues.apache.org/jira/browse/SLING-11750 integrated would have been nice, but for sure no blocker of this release) Konrad > On 4. May 2023, at 18:59, Robert Munteanu wrote: > > Hi, > > We solved 7 issues in this release: > https://issues.apache.org/jira/browse/SLIN

[jira] [Created] (SLING-11862) Prevent usage of annotation dependencies with compile scope

2023-05-05 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11862: --- Summary: Prevent usage of annotation dependencies with compile scope Key: SLING-11862 URL: https://issues.apache.org/jira/browse/SLING-11862 Project: Sling

[GitHub] [sling-parent] stefanseifert commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope

2023-05-05 Thread via GitHub
stefanseifert commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536140579 i get the same build error locally as reported by jenkins: "No rules are configured. Use the skip flag if you want to disable execution." -- This is an automated message from the

[GitHub] [sling-parent] kwin commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope

2023-05-05 Thread via GitHub
kwin commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536177234 > i get the same build error locally as reported by jenkins: "No rules are configured. Use the skip flag if you want to disable execution." Sorry, my bad. Is fixed now. -- This is

[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #34: SLING-11862 Prevent usage of annotation dependencies with compile scope

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #34: URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536184918 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[jira] [Updated] (SLING-11482) Redundant checks for null

2023-05-05 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Labels: regression (was: ) > Redundant checks for null > - > >

[jira] [Commented] (SLING-11482) Redundant checks for null

2023-05-05 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719861#comment-17719861 ] Angela Schreiber commented on SLING-11482: -- see also SLING-11567 > Redundant c

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1536591545 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quali

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1536591283 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quali

[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-11860: Summary: OsgiServiceUtil may invoke the wrong method (was: OsgiServiceUtil#activateDeactivate may

[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-11860: Description: Impacts both the activate/deactivate methods and the bind/unbind methods The scenari

[jira] [Updated] (SLING-11860) OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-11860: Description: Impacts both the activate/deactivate methods and the bind/unbind methods The scenari

[GitHub] [sling-org-apache-sling-testing-osgi-mock] enapps-enorman opened a new pull request, #26: SLING-11860 OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread via GitHub
enapps-enorman opened a new pull request, #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26 Impacts both the activate/deactivate methods and the bind/unbind methods. The scenario where this happens is when the parent class has an activate/deactivate/

[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536609570 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa

[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536619176 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa

[GitHub] [sling-org-apache-sling-testing-osgi-mock] sonarcloud[bot] commented on pull request #26: SLING-11860 OsgiServiceUtil may invoke the wrong method

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536622575 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1536940263 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu

[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #4: Bump activemq-client from 5.13.2 to 5.15.9

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/4#issuecomment-1536949568 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1

[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #1: Convert XML config to Java-Config

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-1536949635 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47

2023-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1536949697 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1