Sagar Miglani created SLING-11861:
-
Summary: ResourceMapper.getAllMappings returns empty mapping ""
when a vanity paths is pathless url
Key: SLING-11861
URL: https://issues.apache.org/jira/browse/SLING-11861
[
https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719701#comment-17719701
]
Roy Teeuwen commented on SLING-11856:
-
[~cziegeler] could you have a look at this?
sagarmiglani opened a new pull request, #96:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96
…en a vanity paths is pathless url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719702#comment-17719702
]
Sagar Miglani commented on SLING-11861:
---
Potential changes:
[https://github.com/a
sonarcloud[bot] commented on PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#issuecomment-1535835990
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGat
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719715#comment-17719715
]
Julian Reschke commented on SLING-11861:
Not convinced.
This is a change in beh
reschke commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185786325
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResource
[
https://issues.apache.org/jira/browse/SLING-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719734#comment-17719734
]
Sagar Miglani commented on SLING-11861:
---
[~reschke] I believe it is a missed edge
sagarmiglani commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185836833
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapRes
yes, for this one and the OSGi annotations it would make sense. they are even
in an unit test environment no candidates for compile scope.
stefan
> -Original Message-
> From: Konrad Windszus
> Sent: Thursday, May 4, 2023 4:08 PM
> To: dev@sling.apache.org
> Subject: Re: [VOTE] Release A
yes, i would rather propose to do a new release to solve a), otherwise this
issues stays around for quite a while.
stefan
> -Original Message-
> From: Daniel Klco
> Sent: Thursday, May 4, 2023 3:59 PM
> To: dev@sling.apache.org
> Subject: Re: [VOTE] Release Apache Sling Event API versio
reschke commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185843290
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapResource
+1
stefan
sagarmiglani commented on code in PR #96:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1185850447
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##
@@ -397,8 +397,8 @@ public void mapRes
+1 (although having https://issues.apache.org/jira/browse/SLING-11750
integrated would have been nice, but for sure no blocker of this release)
Konrad
> On 4. May 2023, at 18:59, Robert Munteanu wrote:
>
> Hi,
>
> We solved 7 issues in this release:
> https://issues.apache.org/jira/browse/SLIN
Konrad Windszus created SLING-11862:
---
Summary: Prevent usage of annotation dependencies with compile
scope
Key: SLING-11862
URL: https://issues.apache.org/jira/browse/SLING-11862
Project: Sling
stefanseifert commented on PR #34:
URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536140579
i get the same build error locally as reported by jenkins: "No rules are
configured. Use the skip flag if you want to disable execution."
--
This is an automated message from the
kwin commented on PR #34:
URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536177234
> i get the same build error locally as reported by jenkins: "No rules are
configured. Use the skip flag if you want to disable execution."
Sorry, my bad. Is fixed now.
--
This is
sonarcloud[bot] commented on PR #34:
URL: https://github.com/apache/sling-parent/pull/34#issuecomment-1536184918
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Qua
[
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11482:
-
Labels: regression (was: )
> Redundant checks for null
> -
>
>
[
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719861#comment-17719861
]
Angela Schreiber commented on SLING-11482:
--
see also SLING-11567
> Redundant c
sonarcloud[bot] commented on PR #163:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1536591545
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quali
sonarcloud[bot] commented on PR #137:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1536591283
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quali
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Summary: OsgiServiceUtil may invoke the wrong method (was:
OsgiServiceUtil#activateDeactivate may
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Description:
Impacts both the activate/deactivate methods and the bind/unbind methods
The scenari
[
https://issues.apache.org/jira/browse/SLING-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-11860:
Description:
Impacts both the activate/deactivate methods and the bind/unbind methods
The scenari
enapps-enorman opened a new pull request, #26:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26
Impacts both the activate/deactivate methods and the bind/unbind methods.
The scenario where this happens is when the parent class has an
activate/deactivate/
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536609570
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536619176
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/26#issuecomment-1536622575
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGa
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1536940263
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Qu
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/4#issuecomment-1536949568
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-1536949635
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1536949697
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-1
34 matches
Mail list logo