[GitHub] [sling-org-apache-sling-models-impl] sonarcloud[bot] commented on pull request #44: SLING-11890 Fix embed of org.apache.sling.scripting.core.impl.helper.ProtectedBindings

2023-05-26 Thread via GitHub
sonarcloud[bot] commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/44#issuecomment-1564704708 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Created] (SLING-11890) Fix embed of org.apache.sling.scripting.core.impl.helper.ProtectedBindings

2023-05-26 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-11890: -- Summary: Fix embed of org.apache.sling.scripting.core.impl.helper.ProtectedBindings Key: SLING-11890 URL: https://issues.apache.org/jira/browse/SLING-11890

[GitHub] [sling-org-apache-sling-engine] kwin commented on a diff in pull request #35: Explicitly call request listeners on synthetic resources

2023-05-26 Thread via GitHub
kwin commented on code in PR #35: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/35#discussion_r1207046502 ## src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java: ## @@ -308,9 +330,37 @@ public void processRequest(final

Re: Synthethic requests and Sling Models

2023-05-26 Thread Konrad Windszus
I added a draft in https://github.com/apache/sling-org-apache-sling-engine/pull/35/files#. Feel free to have a look and take over if you deem that useful. Haven’t tested it yet… Konrad > On 26. May 2023, at 17:32, Konrad Windszus wrote: > > I think this can be implemented with the

[GitHub] [sling-org-apache-sling-engine] kwin opened a new pull request, #35: Explicitly call request listeners on synthetic resources

2023-05-26 Thread via GitHub
kwin opened a new pull request, #35: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/35 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: Synthethic requests and Sling Models

2023-05-26 Thread Konrad Windszus
I think this can be implemented with the HttpServiceRuntime.getRuntimeDRO[1] which should return all registered event listeners [2] through its ServletContextDTO (also the ServletRequestListener registered by ModelAdapterFactory). The question is though when to call the according events, as the

Synthethic requests and Sling Models

2023-05-26 Thread Jörg Hoh
Hi, In AEM we have for quite some time "fake" implementations of SlingHttpServletRequest and SlingHttpServletResponse, which are used as parameters for the SlingProcessor to render content. We came across issues when SlingModels are involved in the rendering process. We found that this approach

Re: Sling Servlets Resolver release wanted

2023-05-26 Thread Jörg Hoh
Hi Robert, I just wanted to do the same. This morning I released sling engine 2.15.0, which should satisfy this dependency. So you can start the release process for it. Jörg Am Fr., 26. Mai 2023 um 13:51 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > I'm trying to update the API

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #169: chore(deps): update dependency io.fabric8:docker-maven-plugin to v0.43.0

2023-05-26 Thread via GitHub
renovate-bot opened a new pull request, #169: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/169 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #168: chore(deps): update dependency org.apache.sling:org.apache.sling.models.impl to v1.6.2

2023-05-26 Thread via GitHub
renovate-bot opened a new pull request, #168: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/168 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

Sling Servlets Resolver release wanted

2023-05-26 Thread Robert Munteanu
Hi, I'm trying to update the API and Engine bundles in the Starter [1] but that fails because the resolver fails to, well, resolve [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.servlets.resolver:2.9.10: Bundle is importing package org.apache.sling.api.servlets;version=[2.3,2.4)

Re: June 2023 board report draft

2023-05-26 Thread Robert Munteanu
On Fri, 2023-05-26 at 09:02 +, Stefan Seifert wrote: > > Adapt.To, a conference that, amongst others, targets Apache Sling > > enthusiasts, will take place 25th-27th September 2023 at > > KulturBrauerei in > > Berlin. > > please replace "Adapt.To" with "adaptTo()". > > stefan Done, thanks

[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request, #167: Update Sling API and Engine

2023-05-26 Thread via GitHub
rombert opened a new pull request, #167: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/167 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [sling-tooling-jenkins] kwin commented on pull request #16: SLING-11843 build on JDK11/17 with Windows and Linux by default

2023-05-26 Thread via GitHub
kwin commented on PR #16: URL: https://github.com/apache/sling-tooling-jenkins/pull/16#issuecomment-1564120478 Discussion happened in https://lists.apache.org/thread/6tgoq2995vhlonrww21n73xpw6gpg4q6. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-26 Thread Konrad Windszus
Hi, Given Robert stated > If I'm the only one concerned, then we should not spend more time > talking about it and "just do it" instead :-) And no one else raised any concern I will go ahead and merge the PR connected with https://issues.apache.org/jira/browse/SLING-11843. Hopefully that

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #837 is BROKEN

2023-05-26 Thread Apache Jenkins Server
rty with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE] [WARNING] [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/_org-apache-sling-starter_master/jdk_11_latest@tmp/withMaven8297a59f/maven-spy-20230526-092550-16714390144341188628518.log [ERROR] Failed to

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #166: chore(deps): update dependency org.apache.sling:org.apache.sling.api to v2.27.2

2023-05-26 Thread via GitHub
renovate-bot opened a new pull request, #166: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/166 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #165: chore(deps): update dependency org.apache.sling:org.apache.sling.engine to v2.15.0

2023-05-26 Thread via GitHub
renovate-bot opened a new pull request, #165: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/165 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[GitHub] [sling-org-apache-sling-starter] kwin merged pull request #164: Update to Installer Configuration Factory 1.4.4

2023-05-26 Thread via GitHub
kwin merged PR #164: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: OSGi Installer Factory Configuration dependency on javax.servlet

2023-05-26 Thread Konrad Windszus
Hi Robert, Good point, tracked and fixed in the context of https://issues.apache.org/jira/browse/SLING-11889. Konrad > On 26. May 2023, at 10:50, Robert Munteanu wrote: > > Hi Konrad, > > On Fri, 2023-05-19 at 16:13 +0200, Konrad Windszus wrote: >> With

[jira] [Resolved] (SLING-11889) Make dependency on javax.servlet optional

2023-05-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-11889. - Resolution: Fixed Fixed in

[jira] [Created] (SLING-11889) Make dependency on javax.servlet optional

2023-05-26 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11889: --- Summary: Make dependency on javax.servlet optional Key: SLING-11889 URL: https://issues.apache.org/jira/browse/SLING-11889 Project: Sling Issue Type:

RE: June 2023 board report draft

2023-05-26 Thread Stefan Seifert
hello robert. thanks for putting this together! very cosmetic remark: > Adapt.To, a conference that, amongst others, targets Apache Sling > enthusiasts, will take place 25th-27th September 2023 at KulturBrauerei in > Berlin. please replace "Adapt.To" with "adaptTo()". stefan

Re: OSGi Installer Factory Configuration dependency on javax.servlet

2023-05-26 Thread Robert Munteanu
Hi Konrad, On Fri, 2023-05-19 at 16:13 +0200, Konrad Windszus wrote: > With https://issues.apache.org/jira/browse/SLING-11864 we moved one > Web Console plugin to the Installer Factory Configuration Bundle. > That now has a dependency on javax.servlet. In Sling Starter we load > that bundle with

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #836 is FIXED

2023-05-26 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/836/ for details. No further emails will be sent until the status of the build is changed.

Re: June 2023 board report draft

2023-05-26 Thread Robert Munteanu
I've replaced the 'Issues' section with the new 'Project Status', see Bertrand's email for more details. --- ## Description: Apache Sling™ is a framework for RESTful web-applications based on an extensible content tree. ## Project Status: Current project status: Ongoing, with moderate

Re: FYI, new "project state" information in Board reports

2023-05-26 Thread Robert Munteanu
On Fri, 2023-05-26 at 09:45 +0200, Bertrand Delacretaz wrote: > The https://reporter.apache.org/wizard/ has been updated to ask for > this information, which for Sling might look like: > > > ## Project Status: > > Current project status: Ongoing, with moderate activity. > > Issues for the board:

[GitHub] [sling-org-apache-sling-security] kwin commented on pull request #10: init outputTimestamp

2023-05-26 Thread via GitHub
kwin commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-security/pull/10#issuecomment-1563964902 Even if not updated, build is still reproducible (even with timestamp being 1). It is just that there is an incorrect modification date in the JARs (but usually no one

FYI, new "project state" information in Board reports

2023-05-26 Thread Bertrand Delacretaz
Hi, FYI, the Board recently updated the reporting guidelines [1] to ask projects to include a "project state" information in project reports, using a finite set of keywords such as New, Ongoing, Dormant etc. The https://reporter.apache.org/wizard/ has been updated to ask for this information,

[jira] [Closed] (SLING-11824) Deadlock during repository restart

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11824. - > Deadlock during repository restart > -- > > Key:

[jira] [Closed] (SLING-11872) Some request attributes not set when running with Felix Jetty 4.2.x

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11872. - > Some request attributes not set when running with Felix Jetty 4.2.x >

[jira] [Closed] (SLING-11851) Prevent recursive invocations of error handler

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11851. - > Prevent recursive invocations of error handler > -- > >

[jira] [Closed] (SLING-11888) remove snapshot dependency

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11888. - > remove snapshot dependency > -- > > Key: SLING-11888 >

[jira] [Closed] (SLING-11825) SlingHttpServletRequestImpl.getUserPrincipal() does not return null for anonymous requests

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11825. - > SlingHttpServletRequestImpl.getUserPrincipal() does not return null for > anonymous requests >

[jira] [Closed] (SLING-11876) Avoid creating response wrapper for every include

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11876. - > Avoid creating response wrapper for every include > - > >

[jira] [Closed] (SLING-11829) Response should be resetted before invoking error filters

2023-05-26 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11829. - > Response should be resetted before invoking error filters >

[RESULT] [VOTE] Release Apache Sling Engine 2.15.0

2023-05-26 Thread Jörg Hoh
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Stefan Seifert, Daniel Klco +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Mo., 22. Mai 2023 um 11:55 Uhr schrieb Jörg Hoh