[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on pull request #24: JsonReader to recognize UTC dates

2023-06-06 Thread via GitHub
enapps-enorman commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/24#issuecomment-1579256103 Maybe we should just remove the regex and just see if a ISO8601 parsing of the string returns non-null. For, example in JsonReader#getType `

[GitHub] [sling-org-apache-sling-servlets-get] YegorKozlov commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-06 Thread via GitHub
YegorKozlov commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1579245397 @enapps-enorman the PR can be closed. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-servlets-get] enapps-enorman commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-06 Thread via GitHub
enapps-enorman commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1579219412 @YegorKozlov Ok, in that case, do you have any objections to closing this PR without merging anything? -- This is an automated message from the Apache Gi

[GitHub] [sling-org-apache-sling-jcr-contentloader] YegorKozlov opened a new pull request, #24: JsonReader to recognize UTC dates

2023-06-06 Thread via GitHub
YegorKozlov opened a new pull request, #24: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/24 The PR is a small amendment to SLING-1130 . The jsonDate regex does not capture dates in the UTC timezone, e.g. | String |

[GitHub] [sling-org-apache-sling-servlets-get] YegorKozlov commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-06 Thread via GitHub
YegorKozlov commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1579090911 @enapps-enorman I don't think the ".json.zip" idea is worth the effort. Sling GET servlet returns binary data by property path , e.g.` /nt_file/jcr:content/jc

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-06-06 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1219599388 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [sling-org-apache-sling-jcr-base] sagarmiglani commented on a diff in pull request #11: Issues/sling 11741

2023-06-06 Thread via GitHub
sagarmiglani commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1219482581 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-06-06 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1219277825 ## src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Found

[jira] [Updated] (SLING-11901) Extend job metrics

2023-06-06 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11901: -- Description: Below is a list of additional metrics to add to sling.event on top of what SLING-8665 al