[GitHub] [sling-org-apache-sling-jcr-base] sonarcloud[bot] commented on pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1736258160 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-base] sonarcloud[bot] commented on pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1736216214 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Resolved] (SLING-12045) Update to Sling Bundle Parent 52

2023-09-26 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-12045. - Resolution: Fixed Merged PR at:

[jira] [Created] (SLING-12046) Update org.apache.sling.jcr.base to parent pom 52

2023-09-26 Thread Julian Sedding (Jira)
Julian Sedding created SLING-12046: -- Summary: Update org.apache.sling.jcr.base to parent pom 52 Key: SLING-12046 URL: https://issues.apache.org/jira/browse/SLING-12046 Project: Sling Issue

[jira] [Updated] (SLING-12046) Update org.apache.sling.jcr.base to parent pom 52

2023-09-26 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-12046: --- Description: Update org.apache.sling.jcr.base to parent pom 52 in order to allow the module

[jira] [Resolved] (SLING-12044) Update to Sling Bundle Parent 52

2023-09-26 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-12044. - Resolution: Fixed Merged PR at:

[GitHub] [sling-org-apache-sling-jcr-oak-server] enapps-enorman merged pull request #9: SLING-12045 Update to Sling Bundle Parent 52

2023-09-26 Thread via GitHub
enapps-enorman merged PR #9: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-jcr-maintenance] enapps-enorman merged pull request #5: SLING-12044 Update to Sling Bundle Parent 52

2023-09-26 Thread via GitHub
enapps-enorman merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-jcr-oak-server] sonarcloud[bot] commented on pull request #9: SLING-12045 Update to Sling Bundle Parent 52

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/9#issuecomment-1736193191 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-jcr-oak-server] enapps-enorman opened a new pull request, #9: SLING-12045 Update to Sling Bundle Parent 52

2023-09-26 Thread via GitHub
enapps-enorman opened a new pull request, #9: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/9 Update to latest bundle parent version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (SLING-12045) Update to Sling Bundle Parent 52

2023-09-26 Thread Eric Norman (Jira)
Eric Norman created SLING-12045: --- Summary: Update to Sling Bundle Parent 52 Key: SLING-12045 URL: https://issues.apache.org/jira/browse/SLING-12045 Project: Sling Issue Type: Improvement

[jira] [Resolved] (SLING-12035) bump oak dependency for compatibility with oak version 1.56.0

2023-09-26 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-12035. - Resolution: Fixed Merged PR at:  

[GitHub] [sling-org-apache-sling-jcr-oak-server] enapps-enorman merged pull request #8: SLING-12035 bump oak dependency for compatibility with version 1.56.0

2023-09-26 Thread via GitHub
enapps-enorman merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-jcr-maintenance] sonarcloud[bot] commented on pull request #5: SLING-12044 Update to Sling Bundle Parent 52

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/5#issuecomment-1736136725 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Created] (SLING-12044) Update to Sling Bundle Parent 52

2023-09-26 Thread Eric Norman (Jira)
Eric Norman created SLING-12044: --- Summary: Update to Sling Bundle Parent 52 Key: SLING-12044 URL: https://issues.apache.org/jira/browse/SLING-12044 Project: Sling Issue Type: Improvement

[jira] [Resolved] (SLING-12034) bump oak dependency for compatibility with oak version 1.56.0

2023-09-26 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-12034. - Resolution: Fixed Merged PR at:  

[GitHub] [sling-org-apache-sling-jcr-maintenance] enapps-enorman merged pull request #3: SLING-12034 bump oak dependency for compatibility with version 1.56.0

2023-09-26 Thread via GitHub
enapps-enorman merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-jcr-maintenance] enapps-enorman commented on pull request #4: SLING-12035: Using a permissive version range for org.apache.jackrabbit.oak.commons.jmx to enable update

2023-09-26 Thread via GitHub
enapps-enorman commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-maintenance/pull/4#issuecomment-1736053256 @rombert @klcodanr Thanks for re-considering my original PR. RE: On the topic of reviews - I generally don't require a review. Especially when I

[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
jsedding commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337496228 ## src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
jsedding commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337495390 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -133,24 +124,47 @@ public boolean

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1040 is FIXED

2023-09-26 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1040/ for details. No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
jsedding commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337238395 ## src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
jsedding commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337236451 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -47,34 +45,28 @@ * use the loginAdministrative method. */

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337173815 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -47,34 +45,28 @@ * use the loginAdministrative method.

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337172793 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -133,24 +124,47 @@ public boolean

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337171961 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -83,23 +75,22 @@ public class LoginAdminAllowList {

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
cziegeler commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337169650 ## src/main/java/org/apache/sling/jcr/base/internal/LegacyFragment.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741

2023-09-26 Thread via GitHub
jsedding commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1334302571 ## src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java: ## @@ -47,34 +45,28 @@ * use the loginAdministrative method. */

[GitHub] [sling-org-apache-sling-graphql-core] rombert commented on a diff in pull request #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-26 Thread via GitHub
rombert commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#discussion_r1337111236 ## pom.xml: ## @@ -249,7 +249,7 @@ org.apache.sling org.apache.sling.testing.paxexam - 3.1.0 + 4.0.0 Review

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a diff in pull request #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-26 Thread via GitHub
raducotescu commented on code in PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#discussion_r1337106376 ## pom.xml: ## @@ -249,7 +249,7 @@ org.apache.sling org.apache.sling.testing.paxexam - 3.1.0 + 4.0.0 Review

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17

2023-09-26 Thread via GitHub
raducotescu commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1735383384 @schaefa, the code fails on Java 11 in the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1039 is BROKEN

2023-09-26 Thread Apache Jenkins Server
e: 09:37 min [INFO] Finished at: 2023-09-26T11:28:05Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_21_latest@tmp/withMaven135a29c5/maven-spy-20

[jira] [Created] (SLING-12043) Incorrect virtual include path when passing resource to data-sly-resource

2023-09-26 Thread Ben Oeyen (Jira)
Ben Oeyen created SLING-12043: - Summary: Incorrect virtual include path when passing resource to data-sly-resource Key: SLING-12043 URL: https://issues.apache.org/jira/browse/SLING-12043 Project: Sling

[GitHub] [sling-org-apache-sling-testing-osgi-mock] rombert commented on pull request #31: SLING-12038 add support for reified OSGi config annotations as test parameters

2023-09-26 Thread via GitHub
rombert commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1735017082 @adamcin - oh, this is a big one :-) Maybe I can convince @stefanseifert to take a look -- This is an automated message from the Apache Git Service. To

[RESULT][VOTE] Release Apache Sling org.apache.sling.distribution.journal.messages 0.5.4, org.apache.sling.distribution.journal 0.2.0

2023-09-26 Thread Christian Schneider
Resending with fixed subject above -- Hi, The vote has passed with the following result: +1 (binding): Christian Schneider, Timothé Maret, Jörg Hoh +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards,

Re: [VOTE] Release Apache Sling Commons Prometheus Metrics Exporter 0.1.0

2023-09-26 Thread Christian Schneider
+1 Christian Am Di., 26. Sept. 2023 um 03:43 Uhr schrieb Daniel Klco : > +1 > > On Sun, Sep 24, 2023 at 2:13 PM Robert Munteanu > wrote: > > > Hi, > > > > We solved 1 issue in this release: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353664=Text > > > >

[jira] [Commented] (SLING-12042) Slings Models Export Servlet: Never return 200 status in case of exceptions

2023-09-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769044#comment-17769044 ] Konrad Windszus commented on SLING-12042: - At first glance I couldn't find any suspicious code

[jira] [Commented] (SLING-11590) AbstractBundleProjectConfigurator no longer compatible with m2e 2.x

2023-09-26 Thread mainagioia (Jira)
[ https://issues.apache.org/jira/browse/SLING-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769039#comment-17769039 ] mainagioia commented on SLING-11590: Successfully tested with Eclipse 2023-09-R and latest nightly