[PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.14.2 [sling-site]

2023-10-25 Thread via GitHub
renovate-bot opened a new pull request, #141: URL: https://github.com/apache/sling-site/pull/141 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

Re: [PR] trivial - re-enable windows builds [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/45#issuecomment-1780121273 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[PR] Bump the npm_and_yarn at /it security update group in /it with 1 update [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
dependabot[bot] opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/46 Bumps the npm_and_yarn at /it security update group in /it with 1 update: [cypress](https://github.com/cypress-io/cypress). Release notes Sourced from

Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
dependabot[bot] closed pull request #42: Bump the npm_and_yarn at /it security update group in /it with 2 updates URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
dependabot[bot] commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42#issuecomment-1780100952 Looks like these dependencies are updatable in another way, so this is no longer needed. -- This is an automated message from the Apache Git Service. To

[PR] trivial - re-enable windows builds [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr opened a new pull request, #45: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/45 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump the npm_and_yarn at /it security update group in /it with 2 updates [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/42#issuecomment-1780099106 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr merged PR #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore(deps): update dependency jakarta.json:jakarta.json-api to v2.1.3 [sling-org-apache-sling-starter]

2023-10-25 Thread via GitHub
rombert merged PR #262: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr merged PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44#issuecomment-1779755396 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779745924 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779740686 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[PR] trivial: re-enabling Java 17 build [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr opened a new pull request, #44: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/44 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SLING-11069 - Sync Latest Change from Starter [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/43#issuecomment-1779717342 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
dependabot[bot] closed pull request #33: Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
dependabot[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33#issuecomment-1779709344 Looks like org.apache.sling:org.apache.sling.i18n is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git

Re: [PR] Bump socket.io-parser from 3.4.2 to 3.4.3 in /it [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/37#issuecomment-1779709987 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.apache.sling.i18n from 2.5.18 to 2.6.2 [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/33#issuecomment-1779708818 https://github.com/dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] SLING-11069 - Sync Latest Change from Starter [sling-org-apache-sling-app-cms]

2023-10-25 Thread via GitHub
klcodanr opened a new pull request, #43: URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/43 diff --git a/feature/src/main/features/base-repoinit.txt b/feature/src/main/features/base-repoinit.txt index 3ad1228..99b3cd7 100644 ---

[jira] [Commented] (SLING-12120) Align Feature Structure with Starter

2023-10-25 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779541#comment-17779541 ] Dan Klco commented on SLING-12120: -- That's a really good question [~rombert]. For the moment, I was

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1097 is FIXED

2023-10-25 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1097/ for details. No further emails will be sent until the status of the build is changed.

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1096 is BROKEN

2023-10-25 Thread Apache Jenkins Server
:28:24Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master/jdk_21_latest@tmp/withMavendf62c442/maven-spy-20231025-122140-54411053008877888360406.log [Pipeline] } [withMaven] Jenkins FindBugs Plugin not found,

Re: [PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
sonarcloud[bot] commented on PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#issuecomment-1779141506 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
anchela commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1779107332 @jsedding , the options were initially introduced into the parser to add the same option-nightmare that we are having in filevault. fortunately, this was never

Re: [PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
anchela commented on code in PR #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46#discussion_r1371602673 ## src/test/java/org/apache/sling/jcr/repoinit/CreateGroupWithExternalIdTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache

[PR] SLING-12122 - Add unit-test creating group with rep:externalId property [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
jsedding opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (SLING-12122) Add unit-test creating group with rep:externalId property

2023-10-25 Thread Julian Sedding (Jira)
Julian Sedding created SLING-12122: -- Summary: Add unit-test creating group with rep:externalId property Key: SLING-12122 URL: https://issues.apache.org/jira/browse/SLING-12122 Project: Sling

Re: [PR] chore(deps): update dependency org.eclipse.parsson:parsson to v1.1.5 [sling-org-apache-sling-starter]

2023-10-25 Thread via GitHub
rombert merged PR #263: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SLING-12120) Align Feature Structure with Starter

2023-10-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779396#comment-17779396 ] Robert Munteanu commented on SLING-12120: - [~dklco] - I'm curious to hear if you have any ideas

Re: [PR] chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.14.1 [sling-site]

2023-10-25 Thread via GitHub
rombert merged PR #140: URL: https://github.com/apache/sling-site/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12107 - JCR Repoinit executes operations out of order [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
kwin commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/44#issuecomment-1778690993 I don't think this change does any harm and better fulfils the [principle of least surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment).

Re: [PR] SLING-12107 - JCR Repoinit executes operations out of order [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
jsedding commented on PR #44: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/44#issuecomment-1778682001 **Update:** Yesterday evening I wrote a unit test around the repoinit snippet below, making sure the repository is initialized with the validator for

Re: [PR] SLING-12115 - Repoinit should leave importBehaviour for ACL creation to JCR [sling-org-apache-sling-jcr-repoinit]

2023-10-25 Thread via GitHub
jsedding commented on PR #45: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#issuecomment-1778664454 I like @kwin's suggestion to use options. Especially if that does not require a parser change. Would that work for you @anchela? @anchela yes, I am aware