Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2131554764 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2131550683 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2131547814 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131368553 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614785674 ## pom.xml: ## @@ -41,27 +41,133 @@ Apache Sling Scripting HTL Compiler - -The Apache Sling Scripting HTL

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
csaboka commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131315388 Well, now I get the blame for all the code duplication and missing coverage on the code I "touched". I hope that isn't a blocker for merging this.

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131313550 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614722374 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
csaboka commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614720582 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
kwin commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#discussion_r1614687706 ## pom.xml: ## @@ -25,7 +25,7 @@ org.apache.sling sling-bundle-parent -44 +52 Review

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131264743 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png

[VOTE] Release Apache Sling Repoinit JCR 1.1.48

2024-05-25 Thread Julian Sedding
Hi, We solved 3 issues in the Apache Sling Repoinit JCR 1.1.48 release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353873=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2862/ You can use this UNIX script to download

[jira] [Resolved] (SLING-12323) [RepoInit] Avoid java.nio.file.Path for parsing repository paths

2024-05-25 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-12323. Fix Version/s: Repoinit JCR 1.1.48 Resolution: Fixed > [RepoInit] Avoid