Re: [PR] SLING-12359 - Extend records support [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/51#issuecomment-218103 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Pa

[jira] [Commented] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859666#comment-17859666 ] Stefan Seifert commented on SLING-12360: excluding [https://github.com/apache/s

[jira] [Updated] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-12360: --- Fix Version/s: (was: Models Validation Impl 1.1.2) > Models: Update to Parent 60, Java 1

[PR] SLING-12360 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-bnd-models]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #1: URL: https://github.com/apache/sling-org-apache-sling-bnd-models/pull/1 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] SLING-12360 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-models-caconfig]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-models-caconfig/pull/2 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] SLING-12360 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-models-jacksonexporter]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #13: URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/13 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] SLING-12360 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #52: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/52 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-06-24 Thread via GitHub
rishabhdaim commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1650963825 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@ pu

[PR] SLING-12361 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-caconfig-bnd-plugin]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-bnd-plugin/pull/1 and apply spotless formatting and update to bnd 6.0.0 as minimum version to compile against -- This is an automated message from the Apache Git Service. To respo

[PR] SLING-12361 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-caconfig-impl]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #10: URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/10 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] SLING-12361 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-caconfig-spi]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #2: URL: https://github.com/apache/sling-org-apache-sling-caconfig-spi/pull/2 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Added API for context aware config resource injection. [sling-org-apache-sling-caconfig-api]

2024-06-24 Thread via GitHub
stefanseifert closed pull request #1: Added API for context aware config resource injection. URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] SLING-12361 Update to Parent 60, Java 11 Minimum Version [sling-org-apache-sling-caconfig-api]

2024-06-24 Thread via GitHub
stefanseifert opened a new pull request, #3: URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/3 and apply spotless formatting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859651#comment-17859651 ] Stefan Seifert commented on SLING-12360: models api already updated to parent 60

[jira] [Updated] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-12360: --- Fix Version/s: (was: Models API 1.5.2) > Models: Update to Parent 60, Java 11 Minimum Ve

[jira] [Updated] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-12360: --- Fix Version/s: Sling Models bnd Plugin 1.0.2 > Models: Update to Parent 60, Java 11 Minimum

[jira] [Created] (SLING-12361) caconfig: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-12361: -- Summary: caconfig: Update to Parent 60, Java 11 Minimum Version Key: SLING-12361 URL: https://issues.apache.org/jira/browse/SLING-12361 Project: Sling Is

[jira] [Created] (SLING-12360) Models: Update to Parent 60, Java 11 Minimum Version

2024-06-24 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-12360: -- Summary: Models: Update to Parent 60, Java 11 Minimum Version Key: SLING-12360 URL: https://issues.apache.org/jira/browse/SLING-12360 Project: Sling Issu

Re: [PR] SLING-12359 - Extend records support [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
stefanseifert commented on code in PR #51: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/51#discussion_r1650759424 ## src/main/java/org/apache/sling/models/impl/AssignableFrom.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Assigned] (SLING-12359) Extend records support

2024-06-24 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-12359: -- Assignee: Stefan Seifert Priority: Major (was: Blocker) > Extend records support

Re: [PR] Bump org.springframework:spring-context from 5.2.9.RELEASE to 5.2.22.RELEASE [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
stefanseifert merged PR #49: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: d

Re: [PR] Bump org.springframework:spring-context from 5.2.9.RELEASE to 5.2.22.RELEASE [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
stefanseifert commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/49#issuecomment-2186074385 this is only a testing dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] SLING-12359 - Extend records support [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
ciechanowiec commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/51#issuecomment-2186006044 @rombert , thank you for your comment. According to your suggestion, I've created a Jira ticket for this improvement and updated this merge request to

[jira] [Updated] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herman Ciechanowiec updated SLING-12359: Description: Java 14 introduced support for record classes, and Apache Sling 12 by

[jira] [Updated] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herman Ciechanowiec updated SLING-12359: Description: Java 14 introduced support for record classes, and Apache Sling 12 by

[jira] [Commented] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859623#comment-17859623 ] Herman Ciechanowiec commented on SLING-12359: - Implementation of the improve

[jira] [Updated] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herman Ciechanowiec updated SLING-12359: Description: Java 14 introduced support for record classes, and Apache Sling 12 by

[jira] [Updated] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
[ https://issues.apache.org/jira/browse/SLING-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herman Ciechanowiec updated SLING-12359: Description: Java 14 introduced support for record classes, and Apache Sling 12 by

[jira] [Created] (SLING-12359) Extend records support

2024-06-24 Thread Herman Ciechanowiec (Jira)
Herman Ciechanowiec created SLING-12359: --- Summary: Extend records support Key: SLING-12359 URL: https://issues.apache.org/jira/browse/SLING-12359 Project: Sling Issue Type: Improvement

Re: [PR] [MISC] Extend records support [sling-org-apache-sling-models-impl]

2024-06-24 Thread via GitHub
rombert commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/51#issuecomment-2185906257 Thanks for the PR @ciechanowiec , happy to see further support added for records; in my own limited testing I did not run into this problem. My ask would be that y

Re: [PR] chore(deps): update dependency com.fasterxml.woodstox:woodstox-core to v6.7.0 [sling-org-apache-sling-starter]

2024-06-24 Thread via GitHub
rombert merged PR #340: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

RE: [VOTE] Release Apache Sling Feature Model Analyser 2.0.8

2024-06-24 Thread Stefan Seifert
+1 stefan

RE: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.4

2024-06-24 Thread Stefan Seifert
+1 concerning the release notes: it's difficult to match the tickets to the commit logs, as they are referencing SLING-12353 which is not assigned to this release, whereas there is no trace of SLING-12305 or SLING-12356 in the change logs of release 1.8.4. stefan

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-06-24 Thread via GitHub
jsedding commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1650485640 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@ publi

[jira] [Commented] (SLING-9143) RangePoller is not closed when the cache is closed

2024-06-24 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859588#comment-17859588 ] Timothee Maret commented on SLING-9143: --- No. I have moved to the next release. > R

[jira] [Updated] (SLING-9143) RangePoller is not closed when the cache is closed

2024-06-24 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9143: -- Fix Version/s: Content Distribution Journal Core 0.5.2 (was: Content Dist

[jira] [Assigned] (SLING-9143) RangePoller is not closed when the cache is closed

2024-06-24 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-9143: - Assignee: (was: Timothee Maret) > RangePoller is not closed when the cache is closed

[jira] [Resolved] (SLING-9078) Keep skipped offsets in memory

2024-06-24 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-9078. --- Resolution: Later > Keep skipped offsets in memory > -- > >

[jira] [Commented] (SLING-9078) Keep skipped offsets in memory

2024-06-24 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859587#comment-17859587 ] Timothee Maret commented on SLING-9078: --- This improvement is relevant if the mechan