sonarcloud[bot] commented on PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/9#issuecomment-128543
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin commented on code in PR #98:
URL: https://github.com/apache/sling-site/pull/98#discussion_r1003187901
##
src/main/jbake/content/documentation/bundles/scripting/scripting-htl.md:
##
@@ -84,6 +84,12 @@ The Sling HTL Scripting engine fully complies with the [HTML
Template
kwin merged PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin merged PR #20:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1288669823
SonarCloud Quality Gate failed. [![Quality Gate
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1003046153
##
src/main/java/org/apache/sling/xss/impl/xml/AntiSamyRules.java:
##
@@ -125,3 +126,10 @@ public Map getCommonPatternByName() {
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1288222011
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/2#issuecomment-1288194966
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/2#issuecomment-1288190214
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/2
While registering bundle resources the BundleContext may be null in some
circumstances.
Check for null BundleContext before using it and report a more
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/2#issuecomment-1287987212
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
yuansc opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/2
…ting Java 11+ bytecode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1287893086
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1287892997
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1287892960
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1287893001
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1287558756
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1287536875
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin commented on PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/20#issuecomment-1286608565
@raducotescu I will merge beginning of next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1285928906
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1285869232
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1285869076
SonarCloud Quality Gate failed. [![Quality Gate
rombert commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000827100
##
src/main/java/org/apache/sling/xss/impl/xml/AntiSamyRules.java:
##
@@ -125,3 +126,10 @@ public Map getCommonPatternByName() {
ashokmca07 commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1285710670
> @ashokmca07 : this issue (SLING-11619) popped up recently and I started to
look into it. As you were involved in the parent 47 upgrade I thought perhaps
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1285560726
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1285466183
SonarCloud Quality Gate failed. [![Quality Gate
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559957
##
src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyWithTestConfigTest.java:
##
@@ -0,0 +1,146 @@
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559727
##
src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyWithTestConfigTest.java:
##
@@ -0,0 +1,146 @@
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000559047
##
src/main/java/org/apache/sling/xss/impl/AntiSamyPolicyAdapter.java:
##
@@ -222,43 +224,28 @@ public boolean apply(String s) {
private static
nonanalou commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000558760
##
src/main/java/org/apache/sling/xss/impl/AntiSamyPolicyAdapter.java:
##
@@ -222,43 +224,28 @@ public boolean apply(String s) {
private static
rombert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/31#issuecomment-1285108380
For the record, this was done for
https://issues.apache.org/jira/browse/SLING-11630
--
This is an automated message from the Apache Git Service.
To respond to the
karlpauls merged PR #31:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert commented on code in PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r999362695
##
src/test/java/org/apache/sling/xss/impl/AntiSamyPolicyWithTestConfigTest.java:
##
@@ -0,0 +1,146 @@
rombert commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1283913227
> > @kwin - is this failure related to your recent changes?
sonarcloud[bot] commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1283894539
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/31#issuecomment-1283890757
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
karlpauls opened a new pull request, #31:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/31
…jvm issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kwin commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1283877213
> @kwin - is this failure related to your recent changes?
rombert commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1283704781
@nonanalou - while we figure out the CI issues, can you please reference a
Jira issue in:
- the PR summary
- commit message
?
`SLING- - Fix problem X`
rombert commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/30#issuecomment-1283703470
@kwin - is this failure related to your recent changes?
nonanalou opened a new pull request, #30:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30
* Correct the policy adapter so that the conditions are added with an "or"
instead of an "and".
--
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on PR #91:
URL: https://github.com/apache/sling-whiteboard/pull/91#issuecomment-1283514196
Kudos, SonarCloud Quality Gate passed! [ from 2.13.3
to 2.13.4.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits;>compare view
dependabot[bot] opened a new pull request, #90:
URL: https://github.com/apache/sling-whiteboard/pull/90
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.13.3
to 2.13.4.1.
Commits
See full diff in https://github.com/FasterXML/jackson/commits;>compare view
sonarcloud[bot] commented on PR #40:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/40#issuecomment-1283491684
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] opened a new pull request, #40:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/40
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.13.2.1
to 2.13.4.1.
Commits
See full diff in
cziegeler closed pull request #30: update m-shade-p for Reproducible Builds
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cziegeler commented on PR #30:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/30#issuecomment-1283467156
Thanks for the PR, in the meantime we have moved the plugin version mgtm to
the parent pom
--
This is an automated message from the Apache Git Service.
To respond
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-sitemap/pull/11#issuecomment-1283410996
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-sitemap/pull/10#issuecomment-1283406469
Superseded by #11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] closed pull request #10: build(deps-dev): bump jackson-databind
from 2.12.3 to 2.12.6.1
URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] opened a new pull request, #11:
URL: https://github.com/apache/sling-org-apache-sling-sitemap/pull/11
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.3
to 2.13.4.1.
Commits
See full diff in
kwin merged PR #14:
URL: https://github.com/apache/sling-tooling-jenkins/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kwin commented on PR #147:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/147#issuecomment-1282522624
This is just the test for
https://github.com/apache/sling-tooling-jenkins/pull/14. Please review the
changes on the Jenkins Library. JDK default is still
joerghoh merged PR #29:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joerghoh merged PR #11:
URL: https://github.com/apache/sling-org-apache-sling-rewriter/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-rewriter/pull/11#issuecomment-1282333544
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/29#issuecomment-1282332428
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert merged PR #77:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/pull/3#issuecomment-1280367208
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1280079155
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1279817671
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1279817538
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1279817544
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1279817541
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1279613093
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1279596020
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1278041343
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1278038604
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1278035342
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1277638493
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1277417456
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276513023
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276459995
SonarCloud Quality Gate failed. [![Quality Gate
stefan-egli commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/11#issuecomment-1276443405
@ashokmca07 : this issue (SLING-11619) popped up recently and I started to
look into it. As you were involved in the parent 47 upgrade I thought perhaps
you
joerghoh merged PR #26:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/26#issuecomment-1276293131
SonarCloud Quality Gate failed. [![Quality Gate
joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/26#discussion_r993429966
##
src/main/java/org/apache/sling/engine/impl/filter/FilterHandle.java:
##
@@ -85,14 +85,16 @@ public long getTime() {
return time.get();
cziegeler commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/26#discussion_r993422929
##
src/main/java/org/apache/sling/engine/impl/filter/FilterHandle.java:
##
@@ -85,14 +85,16 @@ public long getTime() {
return time.get();
sonarcloud[bot] commented on PR #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1275751904
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
DominikSuess commented on PR #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1275748217
Did reduce cognitive complexity and eliminated codesmells (that were in
place before already but sonar complained) - for review best check both
sonarcloud[bot] commented on PR #18:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/18#issuecomment-1274701440
SonarCloud Quality Gate failed. [![Quality Gate
joerghoh merged PR #37:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1274188636
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
nscendoni commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1274183449
Hi @joerghoh
I reverted my changes and added a small section in the Readme about how to
retry HTTP Requests including the coded snippet provided by
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1273590805
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1272646365
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/37#issuecomment-1272495112
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1272384435
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1272384329
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1272384381
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1272384299
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1272183156
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1272163235
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
joerghoh commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270592706
@enapps-enorman It's fine for me if we move the example you have given above
into the readme. It's just that I don't want to loose that snippet here in the
enapps-enorman commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270482796
> I wouldn't mind if we keep this functionality, even if it is just a thin
wrapper around `Awaitility`.
@joerghoh I won't stand in the way of
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1270465220
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1270407008
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1270405967
SonarCloud Quality Gate failed. [