nscendoni commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/38#issuecomment-1270290792
@enapps-enorman Yes, I can use Awaitility without modifying
sling-testing-clients and the code is compact and clean.
You can either close this pull
joerghoh commented on code in PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#discussion_r986027819
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -329,7 +329,8 @@ private void execute() {
joerghoh merged PR #39:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1264752819
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1264461212
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1264461169
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1264461183
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1264461127
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1264177442
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1264160888
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1264133784
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/39#issuecomment-1264131033
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/85#issuecomment-1263302617
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1262631162
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-hc-support/pull/4#issuecomment-1262635259
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1262624372
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1262624226
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman opened a new pull request, #4:
URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/4
Mark the ScriptedHealthCheck as deprecated and provide instructions to use
the equivalent functionality from the
org.apache.felix.healthcheck.generalchecks bundle instead.
enapps-enorman merged PR #3:
URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/17#issuecomment-1262182052
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-js-provider/pull/5#issuecomment-1262165469
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-js-provider/pull/5#issuecomment-1262161732
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #21:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/21#issuecomment-1262107177
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-api/pull/2#issuecomment-1262093846
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
kwin opened a new pull request, #14:
URL: https://github.com/apache/sling-ide-tooling/pull/14
Require at least Eclipse 2022-09
Update Eclipse plugins to Java 17
Update to Tycho 2.7.5
No longer generate p2 repo for plain OSGi bundles
Update to latest dependencies/parent poms
--
sonarcloud[bot] commented on PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/39#issuecomment-1259657685
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/39#issuecomment-1259347760
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
joerghoh opened a new pull request, #39:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/39
Just replace the simpleBindings by LazyBindings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
enapps-enorman merged PR #13:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/13#issuecomment-1258408579
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #84:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1257874519
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
csaboka opened a new pull request, #84:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84
It wasn't possible to add a regular path-only mapping to /etc/map because
the sling:match property was mis-parsed as a URI.
--
This is an automated message from the
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-hc-support/pull/3#issuecomment-1257458478
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-hc-support/pull/3#issuecomment-1257433247
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman opened a new pull request, #3:
URL: https://github.com/apache/sling-org-apache-sling-hc-support/pull/3
Mark the DefaultLoginsHealthCheck as deprecated and provide instructions to
use the equivalent functionality from the auth core bundle instead.
Log a warning message
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/13#issuecomment-1257424941
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/13#issuecomment-1257410475
SonarCloud Quality Gate failed. [![Quality Gate
enapps-enorman opened a new pull request, #13:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/13
Move the DefaultLoginsHealthCheck to the auth core bundle.
Ensure that the dependencies to hc apis in the auth core bundle are optional.
--
This is an automated
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1257298046
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/38#issuecomment-1257251125
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-models-api/pull/7#issuecomment-1257249796
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
karollewandowski opened a new pull request, #38:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/38
This test if similar to
FailingSingleRequiredBySeparateAnnotationOverridingStrategyFieldModel but it
tests the opposite case: `@Optional` overrides `injectionStrategy
enapps-enorman merged PR #12:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1257051707
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1257051667
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/5#issuecomment-1257051628
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1257051619
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1257036991
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1257032690
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
joerghoh opened a new pull request, #31:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31
This is the 1st part of SLING-11558 (Remove resource -> path -> resource
conversion).
It replaces the existing ```LocationIterator``` (which is a iterator-based
kwin opened a new pull request, #99:
URL: https://github.com/apache/sling-site/pull/99
This adds support for Apple Silicon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1256821508
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
enapps-enorman merged PR #38:
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/38#issuecomment-1256780341
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1255356874
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-login/pull/2#issuecomment-1255296511
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-auth-xing-oauth/pull/2#issuecomment-1255296422
SonarCloud Quality Gate failed. [![Quality Gate
tmaret merged PR #62:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tmaret commented on PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62#issuecomment-1254959221
@malpani0311 I did review and also looked at the code history. You are
fixing a regression that was introduced in the big refactoring tracked in
SLING-8595.
rombert merged PR #83:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #83:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/83#issuecomment-1254902807
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
malpani0311 commented on PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62#issuecomment-1254879327
@tmaret Can you please review above comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tmaret merged PR #66:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-subsystems-base/pull/1#issuecomment-1253782320
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert closed pull request #14: SLING-1 - Update to AntiSamy 1.6.5
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rombert commented on PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/14#issuecomment-1253646080
No longer applies as we have moved away from AntiSamy in
https://issues.apache.org/jira/browse/SLING-7231 .
--
This is an automated message from the Apache Git Service.
rombert merged PR #28:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1253640668
I think that we should merge it and make any follow-up fixes later, it's
quite large as it is and a lot of work has been put in the initial
contributions and in the
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#issuecomment-1253512986
SonarCloud Quality Gate failed. [![Quality Gate
ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r976286727
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java:
##
@@ -160,22 +161,33
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r976281189
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java:
##
@@ -160,22 +161,33 @@
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#issuecomment-1253400716
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#issuecomment-1253253650
SonarCloud Quality Gate failed. [![Quality Gate
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/7#issuecomment-1252594377
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-deploymentpackage/pull/1#issuecomment-1252592958
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #3:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/pull/3#issuecomment-1252588184
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-installer-factory-model/pull/1#issuecomment-1252587702
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975251219
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
kwin commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975206339
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r97521
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975198202
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
malpani0311 commented on PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62#issuecomment-1252169180
@tmaret
We can divide customers on 3 types based on naming convictions change[0] .
Before commit[0],
Customer already have errors queue
malpani0311 commented on PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/62#issuecomment-1252127498
@tmaret :
Here are currently my findings :
We are recreating agents on activation through our implementation code[0]
which means error queue will
ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975044699
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public
ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975044699
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public
ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975044699
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public
kwin commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975027331
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
kwin commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975027331
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975021641
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
tmaret commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r975017294
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public void
sonarcloud[bot] commented on PR #38:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/38#issuecomment-1251964879
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-rewriter/pull/10#issuecomment-1251872416
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
sonarcloud[bot] commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1251276970
SonarCloud Quality Gate failed. [![Quality Gate
nonanalou commented on PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1251258228
Hi @kwin,
Are you okay with merging it now and making any follow-up fixes later?
Since it's a big PR and it has been in the work for quite some time.
--
This is
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#issuecomment-1250937533
SonarCloud Quality Gate failed. [![Quality Gate
ManasMaji commented on code in PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#discussion_r974162347
##
src/main/java/org/apache/sling/distribution/serialization/impl/vlt/FileVaultContentSerializer.java:
##
@@ -131,7 +133,7 @@ public
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/66#issuecomment-1250919827
SonarCloud Quality Gate failed. [