[
https://issues.apache.org/jira/browse/SLING-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6764.
-
> Guard against reflection failures when registering Sling Model clas
[
https://issues.apache.org/jira/browse/SLING-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6584.
-
> Race condition in ModelAdapterFact
[
https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6748.
-
> Move ValuePreparer to the models API pack
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6778.
-
> [Sling Models] Support Delegate Pattern for Models adapted from interfa
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6652.
-
> Allow multiple Exporter annotated models being used with the same
> resourceType b
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6658.
-
> Register models with their implType implici
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6785.
-
> Add support for scoped lifecycle of sling mod
The vote has passed with 4 votes:
+1: Konrad Windszus, Stefan Seifert, Carsten Ziegler, Justin Edelson
On Thu, Apr 27, 2017 at 9:49 AM Justin Edelson
wrote:
> Hi,
>
> We solved 7 issue in these releases
>
> https://issues.apache.org/jira/browse/SLING/fixforversion/1
My +1
On Thu, Apr 27, 2017 at 9:49 AM Justin Edelson
wrote:
> Hi,
>
> We solved 7 issue in these releases
>
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338883
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338884/
>
> Sta
Hi,
We solved 7 issue in these releases
https://issues.apache.org/jira/browse/SLING/fixforversion/12338883
https://issues.apache.org/jira/browse/SLING/fixforversion/12338884/
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1689/
You can use this UNIX script
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6785.
---
Resolution: Fixed
Implemented in r1792884
> Add support for scoped lifecycle of sl
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6785:
--
Fix Version/s: Sling Models Impl 1.3.10
Sling Models API 1.3.4
> Add supp
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-6785:
-
Assignee: Justin Edelson
> Add support for scoped lifecycle of sling mod
is has a dependency
> towards javax.json which may change in the future. If we have to do another
> change in the future in that area, this would only affect the package with
> the JSONUtil but not e.g. XSSApi.
> > On 25. Apr 2017, at 14:21, Justin Edelson
> wrote:
> >
> &
I think #2 is the best option of these and I can't see another reasonable
path forward.
Regards,
Justin
On Tue, Apr 25, 2017 at 8:09 AM Carsten Ziegeler
wrote:
> I'm moving this into a separate thread to make the discussion easier.
>
> With the current state of the xss module, we would break ev
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6785:
--
Attachment: SLING-6785.diff
Thinking about this some more and based on [~kwin]'s comme
rrect behavior)"
>
> if we think this does not justify or need a package version increment we
> can just set it back to 2.6.0
>
> stefan
>
>
> >-Original Message-
> >From: Justin Edelson [mailto:jus...@justinedelson.com]
> >Sent: Friday, April 21, 2017 4
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978982#comment-15978982
]
Justin Edelson commented on SLING-6785:
---
bq. if the user does not set &#
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978973#comment-15978973
]
Justin Edelson commented on SLING-6785:
---
bq. but this does not seem to appl
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978927#comment-15978927
]
Justin Edelson commented on SLING-6785:
---
[~jebailey] the cache is a WeakHas
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1597#comment-1597
]
Justin Edelson commented on SLING-6785:
---
[~jelger]
bq. Just to make sure, you
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6785:
--
Attachment: SLING-6785.diff
Here's a diff of how this would look implemented i
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978858#comment-15978858
]
Justin Edelson commented on SLING-6785:
---
[~jelger] the problem for me with {{s
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978821#comment-15978821
]
Justin Edelson commented on SLING-6785:
---
bq. Regarding your proposal, do
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978818#comment-15978818
]
Justin Edelson commented on SLING-6785:
---
[~jebailey] I see your concern,
I'm seeing a build warning when building the api bundle that
org.apache.sling.api.wrappers was changed from 2.6.0 to 2.6.1, but this
change was not necessary.
It looks like this was done in
http://svn.apache.org/viewvc?view=revision&revision=1775427
Is there a reason for this that I'm missing?
T
[
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978793#comment-15978793
]
Justin Edelson commented on SLING-6785:
---
Leaving aside the {{session}}
[
https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-5739.
---
Resolution: Fixed
Assignee: Justin Edelson
patch applied in r1792071
> [Sling Mod
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6778.
---
Resolution: Fixed
Fix Version/s: Sling Models Impl 1.3.10
Sling
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965081#comment-15965081
]
Justin Edelson edited comment on SLING-6778 at 4/20/17 2:5
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6778:
--
Attachment: SLING-6778.diff
updated diff
> [Sling Models] Support Delegate Pattern for Mod
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6778:
--
Description:
Consider this interface:
{code}
public interface Something
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965717#comment-15965717
]
Justin Edelson commented on SLING-6778:
---
nice catch [~royteeuwen]
> [Sling
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965081#comment-15965081
]
Justin Edelson edited comment on SLING-6778 at 4/11/17 10:5
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6778:
--
Description:
Consider this interface:
{code}
public interface Something
[
https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6778:
--
Attachment: SLING-6778.diff
proposed change implementing the vocabulary from the description
[
https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-5739:
--
Attachment: SLING-5739.diff
Given the use case in SLING-6778, I would like to revive this issue
Justin Edelson created SLING-6778:
-
Summary: [Sling Models] Support Delegate Pattern for Models
adapted from interfaces
Key: SLING-6778
URL: https://issues.apache.org/jira/browse/SLING-6778
Project
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964214#comment-15964214
]
Justin Edelson commented on SLING-6773:
---
thanks [~rombert]
> Separate Hea
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6773.
---
Resolution: Fixed
Change made in r1790879
> Separate HeathCheck API from Implementat
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959190#comment-15959190
]
Justin Edelson commented on SLING-6773:
---
I also updated the IT project to use
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6773:
--
Attachment: SLING-6773.diff
> Separate HeathCheck API from Implementat
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6773:
--
Attachment: (was: SLING-6773.diff)
> Separate HeathCheck API from Implementat
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959149#comment-15959149
]
Justin Edelson commented on SLING-6773:
---
the only problem with this is that
[
https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6773:
--
Attachment: SLING-6773.diff
proposed change
> Separate HeathCheck API from Implementat
Justin Edelson created SLING-6773:
-
Summary: Separate HeathCheck API from Implementation
Key: SLING-6773
URL: https://issues.apache.org/jira/browse/SLING-6773
Project: Sling
Issue Type
[
https://issues.apache.org/jira/browse/SLING-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6764.
---
Resolution: Fixed
fixed in r1789734
> Guard against reflection failures when register
Justin Edelson created SLING-6764:
-
Summary: Guard against reflection failures when registering Sling
Model classes
Key: SLING-6764
URL: https://issues.apache.org/jira/browse/SLING-6764
Project
[
https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6748.
---
Resolution: Fixed
moved in r1789419
> Move ValuePreparer to the models API pack
[
https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6748:
--
Fix Version/s: Sling Models Impl 1.3.10
Sling Models API 1.3.4
> M
[
https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-6748:
-
Assignee: Justin Edelson
> Move ValuePreparer to the models API pack
As part of the Commons JSON migration (kudos to all those plugging away at
this thankless task), I see that some dependencies are being created
directly to org.apache.sling.commons.johnzon, e.g.
https://github.com/apache/sling/blob/trunk/bundles/extensions/adapter/pom.xml#L89
.
IIUC, we should rea
+1
On Tue, Mar 21, 2017 at 7:14 AM Stefan Seifert
wrote:
> (sending again as last mail >3 hours ago did not make it to the list)
>
> Hi,
>
> We solved 3 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12339178
>
> Staging repository:
> https://repository.apach
the annotation
>- the collection method which returns all of the models applicable based
>on the resource type
>
> Of course, the other option is just to put a big fat warning that only one
> model class should *ever* be registered for a particular resource type.
&
f{
> public int random(){
> return 7;
> }
> }
>
> If I adapted a resource of type test/rt to the DoesStuff interface, would
> it return 3 or 7? Thus the idea of returning a collection so that any
> registered Sling Models would be processed.
>
> Regards,
> D
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6652.
---
Resolution: Fixed
Patch applied in r1787388.
Thanks for working this through!
> Al
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-6652:
-
Assignee: Justin Edelson
> Allow multiple Exporter annotated models being used with
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6658.
---
Resolution: Fixed
> Register models with their implType implici
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6652:
--
Fix Version/s: Sling Models Impl 1.3.10
> Allow multiple Exporter annotated models being u
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929981#comment-15929981
]
Justin Edelson commented on SLING-6658:
---
applied patch in r1787379. Thanks!
I
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6658:
--
Fix Version/s: Sling Models Impl 1.3.10
> Register models with their implType implici
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-6658:
-
Assignee: Justin Edelson
> Register models with their implType implici
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929905#comment-15929905
]
Justin Edelson commented on SLING-6652:
---
I'm good with adding {{implType
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929788#comment-15929788
]
Justin Edelson commented on SLING-6652:
---
I'm not sure it matt
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6652:
--
Attachment: SLING-6652.diff
The only problem with this patch is that there is still a warning
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929253#comment-15929253
]
Justin Edelson commented on SLING-6652:
---
This appears to be an XY problem.
Hi Dan,
I don't think I'm understanding how that API would work.
You have a single Resource there and a single Class (which I assume is
actually an interface for your use case). Are you saying that for one
Resource, there would be multiple Model classes implementing that same
interface mapped to t
[
https://issues.apache.org/jira/browse/SLING-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929029#comment-15929029
]
Justin Edelson commented on SLING-6655:
---
bq. The difference is that its not obv
[
https://issues.apache.org/jira/browse/SLING-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928674#comment-15928674
]
Justin Edelson commented on SLING-6655:
---
bq. Ok I see but as far as I can
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928670#comment-15928670
]
Justin Edelson commented on SLING-6652:
---
Looking at the Pull Request and rea
[
https://issues.apache.org/jira/browse/SLING-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928654#comment-15928654
]
Justin Edelson commented on SLING-6655:
---
Handlebars is the most obvious case w
[
https://issues.apache.org/jira/browse/SLING-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928646#comment-15928646
]
Justin Edelson commented on SLING-6655:
---
Also, I don't see where SLING-6
[
https://issues.apache.org/jira/browse/SLING-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928634#comment-15928634
]
Justin Edelson commented on SLING-6655:
---
These methods exist for loosely t
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928410#comment-15928410
]
Justin Edelson commented on SLING-6652:
---
Understood. I was just expressing how
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928376#comment-15928376
]
Justin Edelson commented on SLING-6652:
---
Sorry, I'm not making myself clea
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928330#comment-15928330
]
Justin Edelson commented on SLING-6652:
---
Not necessarily a different implementa
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928263#comment-15928263
]
Justin Edelson edited comment on SLING-6652 at 3/16/17 4:0
[
https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928263#comment-15928263
]
Justin Edelson commented on SLING-6652:
---
The way I had anticipated this b
[
https://issues.apache.org/jira/browse/SLING-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6567.
-
> BasicObservationReporter ignores resource changes for resource providers
> mounted at sp
[
https://issues.apache.org/jira/browse/SLING-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6590.
-
> Change events for resource providers are not send to listen
[
https://issues.apache.org/jira/browse/SLING-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6613:
--
Fix Version/s: (was: Resource Resolver 1.5.18)
Resource Resolver 1.5.20
[
https://issues.apache.org/jira/browse/SLING-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson closed SLING-6552.
-
> ResourceResolver must be independent from javax.
Hi,
The vote has passed with the following result :
+1 (binding): Justin Edelson, Stefan Seifert, Karl Pauls, Daniel Klco,
Oliver Lietz
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
On Thu, Mar 2, 2017 at 4:46 PM Justin Edelson
Hi,
This is the replacement for the cancelled 1.5.16 release.
We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12339759/
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1651/
You can use this UNIX script to downl
my +1
On Thu, Mar 2, 2017 at 4:46 PM Justin Edelson
wrote:
> Hi,
>
> This is the replacement for the cancelled 1.5.16 release.
>
> We solved 3 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12339759/
>
> Staging repository:
> ht
Sounds good. Stefan - do you want to restart the 1.5.18 vote or would you
like me to do that?
On Thu, Mar 2, 2017 at 12:52 PM Stefan Seifert
wrote:
> i cancel this vote.
>
> the reason is a new blocker found:
> https://issues.apache.org/jira/browse/SLING-6590
>
> although this blocker was alread
Hi,
I see that in the interim, a blocking issue (
https://issues.apache.org/jira/browse/SLING-6590) has been fixed. I wonder
if we should kill this release vote and start one for 1.5.18.
Thoughts?
Justin
On Wed, Mar 1, 2017 at 8:44 AM Daniel Klco wrote:
+1 - Checked signatures and build
On Tu
[
https://issues.apache.org/jira/browse/SLING-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6584.
---
Resolution: Fixed
Thanks a ton for the test
fixed in r1784960
> Race condition
[
https://issues.apache.org/jira/browse/SLING-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-6584:
-
Assignee: Justin Edelson
> Race condition in ModelAdapterFact
[
https://issues.apache.org/jira/browse/SLING-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851852#comment-15851852
]
Justin Edelson commented on SLING-6504:
---
This seems to me to be a slippery s
PrintWriter into the HtmlRenderer - not without some
> reflection hacks anyway.
>
> What am I missing here?
>
>
> On Wed, Feb 1, 2017 at 3:11 PM, Justin Edelson
> wrote:
>
> > Hi Matt,
> > Thanks for adding tests!!!
> >
> > What I would suggest is to mock the Ht
Hi Matt,
Thanks for adding tests!!!
What I would suggest is to mock the HttpServletResponse and provide a your
own StringWriter to response.getWriter().
Regards,
Justin
On Wed, Feb 1, 2017 at 4:26 PM Matt Ryan wrote:
> Hi,
>
> I'm trying to add unit tests for
> org.apache.sling.junit.impl.serv
[
https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834523#comment-15834523
]
Justin Edelson commented on SLING-6187:
---
I looked through about half of
[
https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826741#comment-15826741
]
Justin Edelson edited comment on SLING-6187 at 1/17/17 8:2
[
https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826741#comment-15826741
]
Justin Edelson commented on SLING-6187:
---
And at least for the {{@Encrypted}}
[
https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826738#comment-15826738
]
Justin Edelson commented on SLING-6187:
---
[~alexander.klimetschek] the way the p
[
https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-6187:
--
Attachment: SLING-6187c.diff
[~alexander.klimetschek] I'm attaching a new patch (
Hi,
Not an exact answer (and to be clear, I'm not endorsing any of these
companies), but I would assume that most, if not all, of the AEM partners
could handle at least the architectural review portion of your request
since Sling architecture is largely a subset of overall AEM architecture.
You ca
+1
On Tue, Jan 10, 2017 at 7:34 PM Carsten Ziegeler
wrote:
> +1
>
>
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>
[
https://issues.apache.org/jira/browse/SLING-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-6436.
---
Resolution: Fixed
implemented in r1777332
request attribute name is
201 - 300 of 3449 matches
Mail list logo
