[jira] [Updated] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-28 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6183: -- Fix Version/s: Sling Models Jackson Exporter 1.0.0 > Sling Models - Provide a mechan

[jira] [Commented] (SLING-5750) Dynamically load different component renditions

2016-10-28 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615631#comment-15615631 ] Justin Edelson commented on SLING-5750: --- [~fvisser] I think this is a different approach than what

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-27 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613159#comment-15613159 ] Justin Edelson commented on SLING-6187: --- Regarding bq. The name of the post processor is a server

[jira] [Commented] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610296#comment-15610296 ] Justin Edelson commented on SLING-6183: --- Assuming we are talking about the Jackson exporter

[jira] [Commented] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609353#comment-15609353 ] Justin Edelson commented on SLING-6183: --- I don't think this is a significant issue. Having {{List

[jira] [Commented] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-26 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608628#comment-15608628 ] Justin Edelson commented on SLING-6183: --- [~dan_mcweeney] {{Resource}} is an interface; so what

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606631#comment-15606631 ] Justin Edelson commented on SLING-6187: --- I'm not sure what you mean by "already handled&quo

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606583#comment-15606583 ] Justin Edelson commented on SLING-6187: --- [~alexander.klimetschek] There's two problems I see

[jira] [Comment Edited] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606101#comment-15606101 ] Justin Edelson edited comment on SLING-6187 at 10/25/16 6:37 PM: - [~rr

[jira] [Comment Edited] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606101#comment-15606101 ] Justin Edelson edited comment on SLING-6187 at 10/25/16 6:36 PM: - [~rr

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606101#comment-15606101 ] Justin Edelson commented on SLING-6187: --- [~rr...@adobe.com] perhaps the description isn't clear

[jira] [Updated] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6187: -- Description: I would like to add support for a new "special" request parameter

[jira] [Created] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

2016-10-25 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6187: - Summary: Provide a way for a POST request to assert a set of required SlingPostProcessors Key: SLING-6187 URL: https://issues.apache.org/jira/browse/SLING-6187

[jira] [Commented] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1566#comment-1566 ] Justin Edelson commented on SLING-6183: --- Here's a brief video walkthrough of this feature: https

[jira] [Updated] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6183: -- Description: I would like to introduce a new feature to Sling Models named Exporters

[jira] [Updated] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6183: -- Description: I would like to introduce a new feature to Sling Models named Exporters

[jira] [Updated] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6183: -- Attachment: SLING-6183.patch > Sling Models - Provide a mechanism to export model objects

[jira] [Created] (SLING-6183) Sling Models - Provide a mechanism to export model objects via servlets

2016-10-23 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6183: - Summary: Sling Models - Provide a mechanism to export model objects via servlets Key: SLING-6183 URL: https://issues.apache.org/jira/browse/SLING-6183 Project

Re: What's wrong with Sightly?

2016-09-05 Thread Justin Edelson
Simply put - because Adobe changed the language name. Since Adobe defines the specification and Sling just contains the implementation, it makes sense for the implementation to have the same name as the specification. Otherwise, we are implementing something which no longer exists. On Mon, Sep 5,

[jira] [Resolved] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-5992. --- Resolution: Fixed > Provide a way to map Sling Model classes to resource ty

[jira] [Commented] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452237#comment-15452237 ] Justin Edelson commented on SLING-5992: --- committed in r1758602 > Provide a way to map Sling Mo

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: (was: SLING-5992.patch) > Provide a way to map Sling Model classes to resou

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: (was: SLING-5992.patch) > Provide a way to map Sling Model classes to resou

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: (was: SLING-5992.patch) > Provide a way to map Sling Model classes to resou

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch In an offline conversation with [~radu.cotescu], we determined

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-24 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch Updated patch with [~kwin]'s feedback. > Provide a way to

[jira] [Commented] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-24 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435086#comment-15435086 ] Justin Edelson commented on SLING-5992: --- I see your point, but I'd prefer a different solution

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-24 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch Thanks for your feedback [~kwin]. I take your point about making

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: (was: SLING-5992.patch) > Provide a way to map Sling Model classes to resou

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: (was: SLING-5992.patch) > Provide a way to map Sling Model classes to resou

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch > Provide a way to map Sling Model classes to resource ty

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Description: For ease of script development, I would like to introduce a mechanism for mapping

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch > Provide a way to map Sling Model classes to resource ty

[jira] [Updated] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5992: -- Attachment: SLING-5992.patch proposed patch > Provide a way to map Sling Model clas

[jira] [Created] (SLING-5992) Provide a way to map Sling Model classes to resource types

2016-08-23 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5992: - Summary: Provide a way to map Sling Model classes to resource types Key: SLING-5992 URL: https://issues.apache.org/jira/browse/SLING-5992 Project: Sling

[jira] [Commented] (SLING-5980) Duplicate Script Cache Clearing Functionality

2016-08-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429795#comment-15429795 ] Justin Edelson commented on SLING-5980: --- Would a whiteboard make sense for the listener instead

Re: [VOTE] Release Apache Sling Feature Flags 1.2.0

2016-08-19 Thread Justin Edelson
+1 On Fri, Aug 19, 2016 at 12:56 PM Daniel Klco wrote: > +1 > > On Fri, Aug 19, 2016 at 12:52 PM, Stefan Seifert > wrote: > > > +1 > > > > >

Re: [Context Aware Configs] Merging?

2016-08-02 Thread Justin Edelson
On Mon, Aug 1, 2016 at 7:24 AM Robert Munteanu wrote: > On Mon, 2016-08-01 at 11:34 +0100, Ian Boston wrote: > > Hi, > > > > On 1 August 2016 at 11:02, Carsten Ziegeler > > wrote: > > > > > > > > Well, I think you're misinterpreting my comments - I

Re: [Context Aware Configs] Merging?

2016-08-02 Thread Justin Edelson
Hi, On Sun, Jul 31, 2016 at 7:07 AM Carsten Ziegeler wrote: > > Allow me to disagree. This lack of merging is actually one of the key > pain > > points I have with OSGi ConfigAdmin and I would really love to see it > > accommodated here. The problem with not merging is

Re: [Context Aware Configs] Merging?

2016-07-29 Thread Justin Edelson
Allow me to disagree. This lack of merging is actually one of the key pain points I have with OSGi ConfigAdmin and I would really love to see it accommodated here. The problem with not merging is that it results in a lot of error-prone duplication and you can easily get into a state where new

[jira] [Commented] (SLING-5801) There is no possible to inject Sling Models adaptable from SlingHttpServletRequest in Sling Model object which is adapted from SlingHttpServletRequest

2016-06-22 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344337#comment-15344337 ] Justin Edelson commented on SLING-5801: --- +1. `@Self` should do this. If it doesn't, can you submit

[jira] [Commented] (SLING-5768) Introduce rep:resourceTypes as extension to Oak permission system

2016-06-14 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329685#comment-15329685 ] Justin Edelson commented on SLING-5768: --- I'm 99% sure we should not be using rep as a namespace here

[jira] [Resolved] (SLING-5761) add Double XSS validator

2016-06-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-5761. --- Resolution: Fixed added in r1746727 > add Double XSS valida

[jira] [Created] (SLING-5761) add Double XSS validator

2016-06-03 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5761: - Summary: add Double XSS validator Key: SLING-5761 URL: https://issues.apache.org/jira/browse/SLING-5761 Project: Sling Issue Type: New Feature

[jira] [Commented] (SLING-5753) Use.init() not invoked for Java Use object which is also a Sling Model

2016-05-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308307#comment-15308307 ] Justin Edelson commented on SLING-5753: --- Aside from this being a slippery slope, my larger concern

[jira] [Commented] (SLING-5753) Use.init() not invoked for Java Use object which is also a Sling Model

2016-05-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308250#comment-15308250 ] Justin Edelson commented on SLING-5753: --- [~lsantha] where would you suggest this be documented

[jira] [Commented] (SLING-5753) Use.init() not invoked for Java Use object which is also a Sling Model

2016-05-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307901#comment-15307901 ] Justin Edelson commented on SLING-5753: --- +1 to [~kwin]'s comments. Use @PostConstruct. > Use.i

Re: [VOTE] Release Apache Sling Servlets Post 2.3.12

2016-05-28 Thread Justin Edelson
+1 On Sat, May 28, 2016 at 8:09 AM Carsten Ziegeler wrote: > +1 > > > > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300437#comment-15300437 ] Justin Edelson commented on SLING-5721: --- Also, I don't expect the list/array conversion could

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300400#comment-15300400 ] Justin Edelson commented on SLING-5721: --- [~henzlerg] the problem with PR 138 is that it is specific

[jira] [Updated] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5721: -- Attachment: SLING-5721-valueconverter-spi2.diff I've updated the patch to support arrays

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300203#comment-15300203 ] Justin Edelson commented on SLING-5721: --- [~kwin] there is a implementation of the SPI in the test

[jira] [Comment Edited] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300203#comment-15300203 ] Justin Edelson edited comment on SLING-5721 at 5/25/16 3:20 PM: [~kwin

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-25 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300168#comment-15300168 ] Justin Edelson commented on SLING-5721: --- [~henzlerg] [~kwin] any comments on this patch before I

Retaining backwards compatibility while moving an enum

2016-05-23 Thread Justin Edelson
Hi, As part of trying to implement https://issues.apache.org/jira/browse/SLING-5743, I've run into a problem where an interface in the package org.apache.sling.models.spi.injectorspecific depends upon an enum in org.apache.sling.models.annotations.injectorspecific. The enum should have been placed

[jira] [Commented] (SLING-5743) Move Standard Injectors and Injector-Specific Annotations to separate bundle

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296652#comment-15296652 ] Justin Edelson commented on SLING-5743: --- another issue - the SelfInjector refers to an internal

[jira] [Commented] (SLING-5743) Move Standard Injectors and Injector-Specific Annotations to separate bundle

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296599#comment-15296599 ] Justin Edelson commented on SLING-5743: --- It turns out this is harder than I thought because

Re: [VOTE] Release Apache Sling JSON Library 2.0.18

2016-05-23 Thread Justin Edelson
+1 On Mon, May 23, 2016 at 9:40 AM Carsten Ziegeler wrote: > +1 > > > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >

[jira] [Created] (SLING-5743) Move Standard Injectors and Injector-Specific Annotations to separate bundle

2016-05-23 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5743: - Summary: Move Standard Injectors and Injector-Specific Annotations to separate bundle Key: SLING-5743 URL: https://issues.apache.org/jira/browse/SLING-5743 Project

[jira] [Assigned] (SLING-5743) Move Standard Injectors and Injector-Specific Annotations to separate bundle

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-5743: - Assignee: Justin Edelson > Move Standard Injectors and Injector-Specific Annotati

[jira] [Updated] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5721: -- Attachment: SLING-5721-valueconverter-spi.diff here's a patch introducing a new ValueConverter

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296237#comment-15296237 ] Justin Edelson commented on SLING-5721: --- Yeah, after working this through a bit more, I don't think

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296235#comment-15296235 ] Justin Edelson commented on SLING-5739: --- To be clear, this isn't really about switching the resource

[jira] [Commented] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

2016-05-23 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296232#comment-15296232 ] Justin Edelson commented on SLING-5726: --- [~henzlerg] Here's the thing... I disagree that bq. Sling

[jira] [Updated] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5721: -- Attachment: SLING-5721.patch here's my proposed change to do this automatically, including

[jira] [Commented] (SLING-5726) Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293686#comment-15293686 ] Justin Edelson commented on SLING-5726: --- (Trying to move this conversation to JIRA now that I

Re: svn commit: r1743648 - in /sling: site/trunk/content/documentation/bundles/ trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/ trunk/bundles/extensions/mode

2016-05-20 Thread Justin Edelson
uot;via" very often in the past and to use > > "via" properly you have to know some details on the injector that I > > don't want every developer to be aware of. > > That was also the reason, why for the annotation "ValueMapValue" the > > via element was automatically set

[jira] [Commented] (SLING-5721) Extend Sling Models to allow mapping of ValueMap values to custom types

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293679#comment-15293679 ] Justin Edelson commented on SLING-5721: --- Thinking about this some more, I'm not sure we need new

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293650#comment-15293650 ] Justin Edelson commented on SLING-5739: --- bq. Generally, I think it will almost always be better

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293618#comment-15293618 ] Justin Edelson commented on SLING-5739: --- nevermind. I figured out my error. I'm not sure

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293593#comment-15293593 ] Justin Edelson commented on SLING-5739: --- This doesn't work for me. Take a look at this patch

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293462#comment-15293462 ] Justin Edelson commented on SLING-5739: --- [~kwin] This is orthogonal to `@Named`. `@Named` is about

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293460#comment-15293460 ] Justin Edelson commented on SLING-5739: --- In terms of other `@Via` providers, one more that could

[jira] [Comment Edited] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293457#comment-15293457 ] Justin Edelson edited comment on SLING-5739 at 5/20/16 2:43 PM: [~henzlerg

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293457#comment-15293457 ] Justin Edelson commented on SLING-5739: --- [~henzlerg] this is actually about injecting a property

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292010#comment-15292010 ] Justin Edelson commented on SLING-5739: --- There's one minor issue in the patch

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291574#comment-15291574 ] Justin Edelson commented on SLING-5739: --- also includes a new @Via provider, ChildResource as shown

[jira] [Commented] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291569#comment-15291569 ] Justin Edelson commented on SLING-5739: --- proposed patch: https://codereview.appspot.com/298180043

[jira] [Created] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2016-05-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5739: - Summary: [Sling Models] Allow for extensible @Via providers Key: SLING-5739 URL: https://issues.apache.org/jira/browse/SLING-5739 Project: Sling Issue

[RESULT] [VOTE] Release Apache Sling Models Impl 1.2.8

2016-05-16 Thread Justin Edelson
Hi, The vote has passed with the following result : +1 (binding): Justin Edelson, Oliver Lietz, Carsten Ziegler +1 (non binding): Julian Sedding I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. On Wed, May 11, 2016 at 5:32 AM

Re: svn commit: r1743648 - in /sling: site/trunk/content/documentation/bundles/ trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/ trunk/bundles/extensions/mode

2016-05-13 Thread Justin Edelson
lingHttpServletRequest objects > > So IMHO this commit fixes a bug in ResourcePathInjector and makes using > ValueMapInjector just more comfortable. > I would be interested to hear other opinions on that change. > Thanks, > Konrad > > > > On 13 May 2016, at 12:45, J

Re: svn commit: r1743648 - in /sling: site/trunk/content/documentation/bundles/ trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/ trunk/bundles/extensions/mode

2016-05-13 Thread Justin Edelson
-1 to this change (would comment in JIRA but I can't for some reason right now) This adds unnecessary complexity and is poor seperation of concerns. The @Via annotation can be used for this use case (and is documented as such). On Fri, May 13, 2016 at 11:35 AM wrote: > Author:

Re: [VOTE] Release Apache Sling Models Impl 1.2.8

2016-05-11 Thread Justin Edelson
anyone else care to vote? On Mon, May 9, 2016 at 7:02 PM Julian Sedding <jsedd...@gmail.com> wrote: > +1 (non binding) all signatures ok > > Regards > Julian > > On Mon, May 9, 2016 at 6:21 PM, Justin Edelson <jus...@justinedelson.com> > wrote: > > My +1

Re: [VOTE] Release Apache Sling Models Impl 1.2.8

2016-05-09 Thread Justin Edelson
My +1 On Mon, May 9, 2016 at 12:20 PM Justin Edelson <jus...@justinedelson.com> wrote: > Hi, > > We solved 4 issues in these releases: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12334705/ > > Staging repository: > https://repository.a

[VOTE] Release Apache Sling Models Impl 1.2.8

2016-05-09 Thread Justin Edelson
Hi, We solved 4 issues in these releases: https://issues.apache.org/jira/browse/SLING/fixforversion/12334705/ Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1458/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-5710) Injectable methods on super-interfaces are not injected

2016-05-09 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-5710. --- Resolution: Fixed > Injectable methods on super-interfaces are not injec

[jira] [Created] (SLING-5710) Injectable methods on super-interfaces are not injected

2016-05-03 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5710: - Summary: Injectable methods on super-interfaces are not injected Key: SLING-5710 URL: https://issues.apache.org/jira/browse/SLING-5710 Project: Sling

[jira] [Commented] (SLING-5710) Injectable methods on super-interfaces are not injected

2016-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269042#comment-15269042 ] Justin Edelson commented on SLING-5710: --- fixed in r1742144 with unit test > Injectable meth

[jira] [Commented] (SLING-5653) adaptTo tag fails when adaptTo parameter is an expression

2016-04-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232172#comment-15232172 ] Justin Edelson commented on SLING-5653: --- IIUC, this doesn't really help because resource.adaptTo

Re: [RT] Improve resource type handling

2016-03-19 Thread Justin Edelson
Hi, On Sat, Mar 19, 2016 at 6:11 AM Carsten Ziegeler <cziege...@apache.org> wrote: > Justin Edelson wrote > > > > I guess I'm not really understanding the advantage of this flat list > (which > > wouldn't be a single flat list, but multiple flat lists). What is

Re: [RT] Improve resource type handling

2016-03-19 Thread Justin Edelson
Hi, On Fri, Mar 18, 2016 at 5:03 AM Carsten Ziegeler wrote: > Oliver Lietz wrote > > On Friday 18 March 2016 08:08:55 Carsten Ziegeler wrote: > >> Hi, > > > > Hi Carsten, > > > >> in the past years we added a lot of things here and there which over > >> time resulted in

[jira] [Commented] (SLING-4937) Drop namespace mapping support

2016-02-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151473#comment-15151473 ] Justin Edelson commented on SLING-4937: --- Was the intention of this issue to remove support

MockSlingHttpServletResponse doesn't support getLocale()

2016-01-22 Thread Justin Edelson
Hi, I was looking at MockSlingHttpServletResponse ( https://github.com/apache/sling/blob/trunk/bundles/extensions/servlet-helpers/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletResponse.java) and was wondering if there was a specific reason why getLocale() isn't supported. IIUC

[RESULT] [VOTE] Release Apache Sling Rewriter 1.1.2

2015-10-27 Thread Justin Edelson
Hi, The vote has passed with the following result : +1 (binding): Justin Edelson, Stefan Seifert, Setfan Egli, Robert Munteau, and Oliver Lietz I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. On Mon, Oct 19, 2015 at 11:50 AM Justin

[VOTE] Release Apache Sling Rewriter 1.1.2

2015-10-19 Thread Justin Edelson
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/1285 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1356/ You can use this UNIX script to download the release and verify the signatures:

Re: Oak, Launchpad 8, Docker

2015-09-30 Thread Justin Edelson
+1 On Tue, Sep 29, 2015 at 10:56 PM Robert Munteanu wrote: > Hi, > > Almost one year ago we release Launchpad 7. Since we aim to release > once per year, looks like a good time to start the release talks. > > I think we discussed several times moving to Oak by default or even

[jira] [Created] (SLING-5071) Adjust filter order for I18NFilter to accomodate changes from SLING-2920

2015-09-28 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5071: - Summary: Adjust filter order for I18NFilter to accomodate changes from SLING-2920 Key: SLING-5071 URL: https://issues.apache.org/jira/browse/SLING-5071 Project

[jira] [Updated] (SLING-5072) Adjust filter order for RewriterFilter to accomodate changes from SLING-2920

2015-09-28 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5072: -- Fix Version/s: (was: i18n 2.4.6) Extensions Rewriter 1.1.2

[jira] [Created] (SLING-5072) Adjust filter order for RewriterFilter to accomodate changes from SLING-2920

2015-09-28 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-5072: - Summary: Adjust filter order for RewriterFilter to accomodate changes from SLING-2920 Key: SLING-5072 URL: https://issues.apache.org/jira/browse/SLING-5072 Project

[jira] [Commented] (SLING-3950) add JMX MBean for servlet resolver cache

2015-09-28 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933577#comment-14933577 ] Justin Edelson commented on SLING-3950: --- hmmm. when did this show up? :) Sorry for the noise

<    1   2   3   4   5   6   7   8   9   10   >