[jira] [Updated] (SLING-7015) Add Utility Method to ModelFactory to help proper model creation from child resources in a request context

2017-07-18 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-7015: -- Attachment: SLING-7015.diff Proposed change attached > Add Utility Method to ModelFactory to

[jira] [Created] (SLING-7015) Add Utility Method to ModelFactory to help proper model creation from child resources in a request context

2017-07-17 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7015: - Summary: Add Utility Method to ModelFactory to help proper model creation from child resources in a request context Key: SLING-7015 URL:

[jira] [Resolved] (SLING-7006) When an error occurs, the Sling Post responses contain change log of paths which did not change

2017-07-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7006. --- Resolution: Fixed fixed in r1801663 > When an error occurs, the Sling Post responses contain

[jira] [Created] (SLING-7006) When an error occurs, the Sling Post responses contain change log of paths which did not change

2017-07-11 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-7006: - Summary: When an error occurs, the Sling Post responses contain change log of paths which did not change Key: SLING-7006 URL: https://issues.apache.org/jira/browse/SLING-7006

[jira] [Resolved] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource interface

2017-06-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6966. --- Resolution: Fixed fixed in r1799221, with unit test > Sling Models Jackson Exporter always

[jira] [Updated] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource interface

2017-06-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6966: -- Summary: Sling Models Jackson Exporter always uses default Resource serialization for a model

[jira] [Created] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource implementation

2017-06-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6966: - Summary: Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource implementation Key: SLING-6966

[jira] [Created] (SLING-6965) Sling Models Jackson Exporter Fails with default resource serialization for a resource with a child

2017-06-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6965: - Summary: Sling Models Jackson Exporter Fails with default resource serialization for a resource with a child Key: SLING-6965 URL:

[jira] [Resolved] (SLING-6965) Sling Models Jackson Exporter Fails with default resource serialization for a resource with a child

2017-06-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6965. --- Resolution: Fixed fixed in r1799218 with updated IT > Sling Models Jackson Exporter Fails

[jira] [Commented] (SLING-6852) A question about reliability of keeping non DS tracked references

2017-05-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008088#comment-16008088 ] Justin Edelson commented on SLING-6852: --- And if there is a bug in Sling, please create an issue for

[jira] [Commented] (SLING-6852) A question about reliability of keeping non DS tracked references

2017-05-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008087#comment-16008087 ] Justin Edelson commented on SLING-6852: --- I understand the example is in Sling, but you are asking

[jira] [Resolved] (SLING-6852) A question about reliability of keeping non DS tracked references

2017-05-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6852. --- Resolution: Information Provided > A question about reliability of keeping non DS tracked

[jira] [Commented] (SLING-6852) A question about reliability of keeping non DS tracked references

2017-05-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007947#comment-16007947 ] Justin Edelson commented on SLING-6852: --- it would be best to ask generic OSGi questions on the

[jira] [Resolved] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6804. --- Resolution: Fixed fixed in r1794887 Change is basically the patch attached plus the ability

[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6804: -- Fix Version/s: Health Check API 1.0.2 Health Check Core 1.2.10 > Request to

[jira] [Commented] (SLING-6841) Sling Mocks should inject ResourceResolverFactory by default

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000793#comment-16000793 ] Justin Edelson commented on SLING-6841: --- Yeah, IMO it is unexpected to need to do this in the test

[jira] [Updated] (SLING-6841) Sling Mocks should inject ResourceResolverFactory by default

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6841: -- Fix Version/s: (was: Testing Sling Mock 2.2.8) > Sling Mocks should inject

[jira] [Commented] (SLING-6841) Sling Mocks should inject ResourceResolverFactory by default

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000771#comment-16000771 ] Justin Edelson commented on SLING-6841: --- [~sseif...@pro-vision.de] possibly I'm doing something

[jira] [Created] (SLING-6841) Sling Mocks should inject ResourceResolverFactory by default

2017-05-08 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6841: - Summary: Sling Mocks should inject ResourceResolverFactory by default Key: SLING-6841 URL: https://issues.apache.org/jira/browse/SLING-6841 Project: Sling

[jira] [Comment Edited] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000676#comment-16000676 ] Justin Edelson edited comment on SLING-6804 at 5/8/17 12:37 PM:

[jira] [Commented] (SLING-6834) Introduce a new, verbose and text-based output format that can be used for console based applications

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000675#comment-16000675 ] Justin Edelson commented on SLING-6834: --- I see as part of the change, the token delimiters were

[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-08 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000676#comment-16000676 ] Justin Edelson commented on SLING-6804: --- [~henzlerg] the problem with assuming that the tokens with

[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-05 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998419#comment-15998419 ] Justin Edelson commented on SLING-6804: --- [~henzlerg] I have several concerns with your design and

[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6804: -- Attachment: (was: SLING-6804.diff) > Request to allow the health check servlet to directly

[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6804: -- Attachment: SLING-6804.diff > Request to allow the health check servlet to directly query a

[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995091#comment-15995091 ] Justin Edelson commented on SLING-6804: --- Attached my proposed change. It supports names as a query

[jira] [Updated] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6804: -- Attachment: SLING-6804.diff > Request to allow the health check servlet to directly query a

[jira] [Commented] (SLING-6806) Health Check servlet does not show associated tags in the html or json

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994977#comment-15994977 ] Justin Edelson commented on SLING-6806: --- thanks [~henzlerg] for the feedback. I moved it to the

[jira] [Commented] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-03 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994944#comment-15994944 ] Justin Edelson commented on SLING-6804: --- IMHO, the class name is an implementation detail. We should

[jira] [Assigned] (SLING-6804) Request to allow the health check servlet to directly query a single health check by name

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6804: - Assignee: Justin Edelson > Request to allow the health check servlet to directly query a

[jira] [Comment Edited] (SLING-6805) Request for negative tag and negative name filtering from health check servlet

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993211#comment-15993211 ] Justin Edelson edited comment on SLING-6805 at 5/2/17 5:45 PM: --- [~cgoudie]

[jira] [Resolved] (SLING-6806) Health Check servlet does not show associated tags in the html or json

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6806. --- Resolution: Fixed fixed in r1793562 > Health Check servlet does not show associated tags in

[jira] [Comment Edited] (SLING-6805) Request for negative tag and negative name filtering from health check servlet

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993211#comment-15993211 ] Justin Edelson edited comment on SLING-6805 at 5/2/17 4:34 PM: --- [~cgoudie]

[jira] [Commented] (SLING-6805) Request for negative tag and negative name filtering from health check servlet

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993211#comment-15993211 ] Justin Edelson commented on SLING-6805: --- [~cgoudie] I'm trying to understand this issue. The

[jira] [Comment Edited] (SLING-6805) Request for negative tag and negative name filtering from health check servlet

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993211#comment-15993211 ] Justin Edelson edited comment on SLING-6805 at 5/2/17 4:33 PM: --- [~cgoudie]

[jira] [Assigned] (SLING-6806) Health Check servlet does not show associated tags in the html or json

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6806: - Assignee: Justin Edelson > Health Check servlet does not show associated tags in the

[jira] [Updated] (SLING-6806) Health Check servlet does not show associated tags in the html or json

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6806: -- Fix Version/s: Health Check Core 1.2.8 > Health Check servlet does not show associated tags in

[jira] [Resolved] (SLING-6803) Sling health check servlet does not respond to a query for .json or .html on it's root relative path

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6803. --- Resolution: Fixed fixed in r1793559 > Sling health check servlet does not respond to a

[jira] [Resolved] (SLING-6822) Health Check HTML Output puts "Finished At" under "Execution Time" column

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6822. --- Resolution: Fixed fixed in r1793558 > Health Check HTML Output puts "Finished At" under

[jira] [Assigned] (SLING-6803) Sling health check servlet does not respond to a query for .json or .html on it's root relative path

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6803: - Assignee: Justin Edelson > Sling health check servlet does not respond to a query for

[jira] [Updated] (SLING-6803) Sling health check servlet does not respond to a query for .json or .html on it's root relative path

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6803: -- Fix Version/s: Health Check Core 1.2.8 > Sling health check servlet does not respond to a query

[jira] [Created] (SLING-6822) Health Check HTML Output puts "Finished At" under "Execution Time" column

2017-05-02 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6822: - Summary: Health Check HTML Output puts "Finished At" under "Execution Time" column Key: SLING-6822 URL: https://issues.apache.org/jira/browse/SLING-6822 Project:

[jira] [Resolved] (SLING-6818) Sling Models Impl build tries to deploy sources jar twice

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6818. --- Resolution: Fixed fixed in r1793493 > Sling Models Impl build tries to deploy sources jar

[jira] [Assigned] (SLING-6818) Sling Models Impl build tries to deploy sources jar twice

2017-05-02 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6818: - Assignee: Justin Edelson > Sling Models Impl build tries to deploy sources jar twice >

[jira] [Created] (SLING-6818) Sling Models Impl build tries to deploy sources jar twice

2017-05-02 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6818: - Summary: Sling Models Impl build tries to deploy sources jar twice Key: SLING-6818 URL: https://issues.apache.org/jira/browse/SLING-6818 Project: Sling

[jira] [Resolved] (SLING-6815) Allow for suppression of warning about adapter classes being in private packages

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6815. --- Resolution: Fixed in 1793373, added support for the {{adapter.allowed.in.private.package}}

[jira] [Created] (SLING-6815) Allow for suppression of warning about adapter classes being in private packages

2017-05-01 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6815: - Summary: Allow for suppression of warning about adapter classes being in private packages Key: SLING-6815 URL: https://issues.apache.org/jira/browse/SLING-6815

[jira] [Closed] (SLING-6764) Guard against reflection failures when registering Sling Model classes

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6764. - > Guard against reflection failures when registering Sling Model classes >

[jira] [Closed] (SLING-6584) Race condition in ModelAdapterFactory

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6584. - > Race condition in ModelAdapterFactory > - > >

[jira] [Closed] (SLING-6748) Move ValuePreparer to the models API package

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6748. - > Move ValuePreparer to the models API package > > >

[jira] [Closed] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6778. - > [Sling Models] Support Delegate Pattern for Models adapted from interfaces >

[jira] [Closed] (SLING-6652) Allow multiple Exporter annotated models being used with the same resourceType binding

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6652. - > Allow multiple Exporter annotated models being used with the same > resourceType binding >

[jira] [Closed] (SLING-6658) Register models with their implType implicitly

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6658. - > Register models with their implType implicitly > -- > >

[jira] [Closed] (SLING-6785) Add support for scoped lifecycle of sling models

2017-05-01 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson closed SLING-6785. - > Add support for scoped lifecycle of sling models >

[jira] [Resolved] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-27 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6785. --- Resolution: Fixed Implemented in r1792884 > Add support for scoped lifecycle of sling

[jira] [Updated] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-27 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6785: -- Fix Version/s: Sling Models Impl 1.3.10 Sling Models API 1.3.4 > Add support

[jira] [Assigned] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-27 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6785: - Assignee: Justin Edelson > Add support for scoped lifecycle of sling models >

[jira] [Updated] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-24 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6785: -- Attachment: SLING-6785.diff Thinking about this some more and based on [~kwin]'s comment, I

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978982#comment-15978982 ] Justin Edelson commented on SLING-6785: --- bq. if the user does not set 'scope="adaptable"' and the

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978973#comment-15978973 ] Justin Edelson commented on SLING-6785: --- bq. but this does not seem to apply to current

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978927#comment-15978927 ] Justin Edelson commented on SLING-6785: --- [~jebailey] the cache is a WeakHashMap where the keys are

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1597#comment-1597 ] Justin Edelson commented on SLING-6785: --- [~jelger] bq. Just to make sure, you also agree that we

[jira] [Updated] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6785: -- Attachment: SLING-6785.diff Here's a diff of how this would look implemented in the

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978858#comment-15978858 ] Justin Edelson commented on SLING-6785: --- [~jelger] the problem for me with {{scope="request"}} is

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978821#comment-15978821 ] Justin Edelson commented on SLING-6785: --- bq. Regarding your proposal, do you foresee that the scope

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978818#comment-15978818 ] Justin Edelson commented on SLING-6785: --- [~jebailey] I see your concern, but wouldn't the model

[jira] [Commented] (SLING-6785) Add support for scoped lifecycle of sling models

2017-04-21 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978793#comment-15978793 ] Justin Edelson commented on SLING-6785: --- Leaving aside the {{session}} and {{application}} scopes, I

[jira] [Resolved] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2017-04-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-5739. --- Resolution: Fixed Assignee: Justin Edelson patch applied in r1792071 > [Sling Models]

[jira] [Resolved] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6778. --- Resolution: Fixed Fix Version/s: Sling Models Impl 1.3.10 Sling

[jira] [Comment Edited] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-20 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965081#comment-15965081 ] Justin Edelson edited comment on SLING-6778 at 4/20/17 2:56 PM: proposed

[jira] [Updated] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6778: -- Attachment: SLING-6778.diff updated diff > [Sling Models] Support Delegate Pattern for Models

[jira] [Updated] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6778: -- Description: Consider this interface: {code} public interface Something {

[jira] [Commented] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-12 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965717#comment-15965717 ] Justin Edelson commented on SLING-6778: --- nice catch [~royteeuwen] > [Sling Models] Support Delegate

[jira] [Comment Edited] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965081#comment-15965081 ] Justin Edelson edited comment on SLING-6778 at 4/11/17 10:57 PM: - proposed

[jira] [Updated] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6778: -- Description: Consider this interface: {code} public interface Something {

[jira] [Updated] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6778: -- Attachment: SLING-6778.diff proposed change implementing the vocabulary from the description.

[jira] [Updated] (SLING-5739) [Sling Models] Allow for extensible @Via providers

2017-04-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-5739: -- Attachment: SLING-5739.diff Given the use case in SLING-6778, I would like to revive this

[jira] [Created] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-11 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6778: - Summary: [Sling Models] Support Delegate Pattern for Models adapted from interfaces Key: SLING-6778 URL: https://issues.apache.org/jira/browse/SLING-6778 Project:

[jira] [Commented] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-11 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964214#comment-15964214 ] Justin Edelson commented on SLING-6773: --- thanks [~rombert] > Separate HeathCheck API from

[jira] [Resolved] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-10 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6773. --- Resolution: Fixed Change made in r1790879 > Separate HeathCheck API from Implementation >

[jira] [Commented] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959190#comment-15959190 ] Justin Edelson commented on SLING-6773: --- I also updated the IT project to use the latest snapshots,

[jira] [Updated] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6773: -- Attachment: SLING-6773.diff > Separate HeathCheck API from Implementation >

[jira] [Updated] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6773: -- Attachment: (was: SLING-6773.diff) > Separate HeathCheck API from Implementation >

[jira] [Commented] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959149#comment-15959149 ] Justin Edelson commented on SLING-6773: --- the only problem with this is that the baseline plugin will

[jira] [Updated] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6773: -- Attachment: SLING-6773.diff proposed change > Separate HeathCheck API from Implementation >

[jira] [Created] (SLING-6773) Separate HeathCheck API from Implementation

2017-04-06 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6773: - Summary: Separate HeathCheck API from Implementation Key: SLING-6773 URL: https://issues.apache.org/jira/browse/SLING-6773 Project: Sling Issue Type:

[jira] [Resolved] (SLING-6764) Guard against reflection failures when registering Sling Model classes

2017-03-31 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6764. --- Resolution: Fixed fixed in r1789734 > Guard against reflection failures when registering

[jira] [Created] (SLING-6764) Guard against reflection failures when registering Sling Model classes

2017-03-31 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6764: - Summary: Guard against reflection failures when registering Sling Model classes Key: SLING-6764 URL: https://issues.apache.org/jira/browse/SLING-6764 Project:

[jira] [Resolved] (SLING-6748) Move ValuePreparer to the models API package

2017-03-29 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6748. --- Resolution: Fixed moved in r1789419 > Move ValuePreparer to the models API package >

[jira] [Updated] (SLING-6748) Move ValuePreparer to the models API package

2017-03-29 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6748: -- Fix Version/s: Sling Models Impl 1.3.10 Sling Models API 1.3.4 > Move

[jira] [Assigned] (SLING-6748) Move ValuePreparer to the models API package

2017-03-29 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6748: - Assignee: Justin Edelson > Move ValuePreparer to the models API package >

[jira] [Resolved] (SLING-6652) Allow multiple Exporter annotated models being used with the same resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6652. --- Resolution: Fixed Patch applied in r1787388. Thanks for working this through! > Allow

[jira] [Assigned] (SLING-6652) Allow multiple Exporter annotated models being used with the same resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6652: - Assignee: Justin Edelson > Allow multiple Exporter annotated models being used with the

[jira] [Resolved] (SLING-6658) Register models with their implType implicitly

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-6658. --- Resolution: Fixed > Register models with their implType implicitly >

[jira] [Updated] (SLING-6652) Allow multiple Exporter annotated models being used with the same resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6652: -- Fix Version/s: Sling Models Impl 1.3.10 > Allow multiple Exporter annotated models being used

[jira] [Commented] (SLING-6658) Register models with their implType implicitly

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929981#comment-15929981 ] Justin Edelson commented on SLING-6658: --- applied patch in r1787379. Thanks! I also changed the

[jira] [Updated] (SLING-6658) Register models with their implType implicitly

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-6658: -- Fix Version/s: Sling Models Impl 1.3.10 > Register models with their implType implicitly >

[jira] [Assigned] (SLING-6658) Register models with their implType implicitly

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-6658: - Assignee: Justin Edelson > Register models with their implType implicitly >

[jira] [Commented] (SLING-6652) Allow multiple Exporter annotated models being used with the same resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929905#comment-15929905 ] Justin Edelson commented on SLING-6652: --- I'm good with adding {{implType}} to the {{adapterType}}

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929788#comment-15929788 ] Justin Edelson commented on SLING-6652: --- I'm not sure it matters which {{adapterType}} is used in

<    1   2   3   4   5   6   7   8   9   10   >