Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-23 Thread Georg Henzler
Hi all, so "SlingUri" (with now improved name) as prerequisite for the Mapping SPI has now been fixed via SLING-9745 and is on master. This alone is just a utility - no behaviour of resolve() or map() has been changed (yet). With the changes [1] [2] [3] [4] (only on branches so far) the URI mapp

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-29 Thread Carsten Ziegeler
Thanks Georg, I had a quick look at the auth.core changes. They cover the basic flow, but we also need to remove the usage of the ResourceMapper (in the service listener). Unfortunately, this requires a rewrite of most of the tests, I'll try to have a look at this in the next days. Regards C

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-29 Thread Carsten Ziegeler
I updated the branch in auth.core to what I believe it should look like. @Georg - I think it would be good if you create PRs, so we can better review and comment on the changes Regards Carsten Am 29.09.2020 um 11:44 schrieb Carsten Ziegeler: Thanks Georg, I had a quick look at the auth.core

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-30 Thread Georg Henzler
Hi Carsten, @Georg - I think it would be good if you create PRs, so we can better review and comment on the changes Thanks a lot - I'll quickly cross-test and create a PR this evening (I have an improvement for SlingUri as well, but that's independent) -Georg Regards Carsten Am 29.09.2020

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-30 Thread Georg Henzler
Hi all, so I created the PRs: https://github.com/apache/sling-org-apache-sling-api/pull/25 https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/22 https://github.com/apache/sling-org-apache-sling-engine/pull/10 https://github.com/apache/sling-org-apache-sling-auth-core/pull/6 J