Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-08 Thread Julian Sedding
Thanks Jason. I've updated to Sling parent 34 now instead of explicitly setting the minimum Java version to 8. While I would be interested in updating it to sling-bundle-parent 35, I currently don't have the spare cycles to properly test the bundle metadata after the change. Regards Julian On

Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-05 Thread Jason E Bailey
The parent POM was updated to Java a while back, my understanding is if you need to update a bundle to 8 as part of a story, there's no need for a separate story. -- Jason On Fri, Jul 5, 2019, at 10:39 AM, Julian Sedding wrote: > Hi all > > I've implemented these changes, but I had to

Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-05 Thread Julian Sedding
Hi all I've implemented these changes, but I had to increase the required java version of JCR Resource to Java 8 (given ZonedDateTime was introduced in Java 8). Is that ok? Should I create a separate ticket for the Java version increase? And should I increase the bundle version as well, since

Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-04 Thread Julian Sedding
That should have read: 've created SLING-8558 for tracking the change in ValueMapDecorator (API) and SLING-8559 for tracking the change in JcrValueMap (JCR Resource) for now. Regards Julian On Thu, Jul 4, 2019 at 12:09 PM Julian Sedding wrote: > > Thanks Robert. > > I've created SLING-8558 for

Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-04 Thread Julian Sedding
Thanks Robert. I've created SLING-8558 for tracking the change in ValueMapDecorator (API) and JcrValueMap (JCR Resource) for now. Regards Julian On Tue, Jul 2, 2019 at 12:05 PM Robert Munteanu wrote: > > On Tue, 2019-07-02 at 12:01 +0200, Julian Sedding wrote: > > Hi all > > > > I think it

Re: [DISCUSS] Support ZonedDateTime in ValueMap

2019-07-02 Thread Robert Munteanu
On Tue, 2019-07-02 at 12:01 +0200, Julian Sedding wrote: > Hi all > > I think it might make sense to support getting dates from ValueMaps > as > java.time.ZonedDateTime instances directly. I've been finding myself > converting Calendar instances after retrieving them from ValueMaps > quite a bit

[DISCUSS] Support ZonedDateTime in ValueMap

2019-07-02 Thread Julian Sedding
Hi all I think it might make sense to support getting dates from ValueMaps as java.time.ZonedDateTime instances directly. I've been finding myself converting Calendar instances after retrieving them from ValueMaps quite a bit lately. WDYT? Regards Julian