Re: [Fwd: [apache/sling-org-apache-sling-testing-clients] @trivial - The poller should wait for the delay even in case of exceptions (#4)]

2018-01-19 Thread Robert Munteanu
On Fri, 2018-01-19 at 10:29 +, Andrei Dulvac wrote: > Hi Robert. > > Agree on all points above :) > > I'll create an issue and link it. Thanks!. Robert

Re: [Fwd: [apache/sling-org-apache-sling-testing-clients] @trivial - The poller should wait for the delay even in case of exceptions (#4)]

2018-01-19 Thread Andrei Dulvac
Hi Robert. Agree on all points above :) I'll create an issue and link it. - Andrei On Thu, Jan 18, 2018 at 5:17 PM Robert Munteanu wrote: > Hi Andrei, > > Even though '@trivial', these kind of changes deserve their own Jira > issue. Please create one after the fact and link to commit to it (

[Fwd: [apache/sling-org-apache-sling-testing-clients] @trivial - The poller should wait for the delay even in case of exceptions (#4)]

2018-01-18 Thread Robert Munteanu
Hi Andrei, Even though '@trivial', these kind of changes deserve their own Jira issue. Please create one after the fact and link to commit to it ( via a Jira comment). I agree not all changes need a Jira issue, but 'trivial' issues IMO are mostly formatting and Javadoc fixes, not ones that change