[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-07-20 Thread GitBox
stefan-egli commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1190081334 @ashokmca07 , as a follow-up we discovered an issue that I'm working on now - details see https://issues.apache.org/jira/browse/SLING-11470 -- This is an

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #7: SLING-11355: sling discovery bundles: update to sling parent 48

2022-07-18 Thread GitBox
stefan-egli commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1187584073 I think both options (from @kwin and @rombert) work fine. These impl classes should not have been exported (by myself) in the first place and i would