[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #20: Moving the JS calling part into the DIV, thus it get replaced after d…

rombert commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/20#issuecomment-825472107 Code overall LGTM but it is way out of my area of expertise regarding dynamic includes . @klcodanr - maybe you can review? -- This is an

[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #20: Moving the JS calling part into the DIV, thus it get replaced after d…

rombert commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/20#issuecomment-818677827 Thanks for the PR @maximilianvoss . As this is a non-trivial fix, can you please file an issue in the Sling Jira -