[GitHub] [sling-org-apache-sling-event] pat-lego commented on pull request #31: Fix infinite recursion issue: SLING-11918

2023-07-10 Thread via GitHub
pat-lego commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-event/pull/31#issuecomment-1629019607 @stefan-egli yes please merge the PR I cannot do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [sling-org-apache-sling-event] pat-lego commented on pull request #31: Fix infinite recursion issue: SLING-11918

2023-07-05 Thread via GitHub
pat-lego commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-event/pull/31#issuecomment-1621855443 @stefan-egli included the recommendation into the branch, the build is failing due to the incompatibility of this project with Java 17 which is addressed by [SLING-1192

[GitHub] [sling-org-apache-sling-event] pat-lego commented on pull request #31: Fix infinite recursion issue: SLING-11918

2023-06-29 Thread via GitHub
pat-lego commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-event/pull/31#issuecomment-1613237257 @sagarmiglani logically you are correct but you are missing one critical piece of information. There are scenarios that cause events to already register this mbean and