[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-25 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-950657933 Closing this PR as the filevault based validation is the better solution. -- This is an automated message from the Apache Git Service. To

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-22 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-950087261 I have created a new PR that uses the filevault validation API like Konrad suggested.

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-19 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-946580031 I will try the vault validation API. I will report back when I got something to show. -- This is an automated message from the Apache Git

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-13 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941973180 @kwin The current version of filevault-package-maven-plugin fully supports this. Unfortunately we have no influence on if / when our customers

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-13 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941973180 @kwin The current version of filevault-package-maven-plugin fully supports this. Unfortunately we have no influence on if / when our customers

[GitHub] [sling-org-apache-sling-feature-analyser] cschneider commented on pull request #32: SLING-10866 - Analyzer for xml files in content packages

2021-10-12 Thread GitBox
cschneider commented on pull request #32: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/32#issuecomment-941026702 @rombert I will review the sonar results. There actually already is a check on the level of filevault package plugin. Unfortunately not all