[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on a change in pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

[GitBox]

cziegeler commented on a change in pull request #70:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#discussion_r612944561



##########
File path: 
src/main/java/org/apache/sling/feature/cpconverter/artifacts/LocalMavenRepositoryArtifactsDeployer.java
##########
@@ -99,4 +92,17 @@ public void deploy(@NotNull ArtifactWriter artifactWriter, 
@NotNull ArtifactId i
         }
     }
 
+    public static String getNameFromArtifactId(ArtifactId id) {
+        StringBuilder nameBuilder = new StringBuilder()

Review comment:
       Why not use ArtifactId.toMvnName() ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org